[$1000] Android - There is no focus in compose box after tapping on deep link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #15994

Action Performed:

1. Go to NewDot app
2. Log in with any account
3. Send yourself a link to a public report you're not already a member of on NewDot (from a different account).
4. Click on that link, and verify you can access the report.

Expected Result:

There is focus in compose box after tapping on deep link

Actual Result:

There is no focus in compose box after tapping on deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.85.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

15994.Android.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d0ad62d564fa664e
• Upwork Job ID: 1637758356240424960
• Last Price Increase: 2023-03-20

[MelvinBot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

reviewing

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d0ad62d564fa664e

[MelvinBot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Julesssss]

Awaiting proposals

[tienifr]

@Julesssss @dylanexpensify I think this is a feature request. Currently on native There is focus in compose box only happens if we access a new chat (without any messages). For existing chat it will not focus on the compose box when accessing the chat.

[Julesssss]

Ah right. It would be good to confirm that this is only occurring on Andorid and not iOS then.

[tienifr]

@Julesssss it's the same behavior for both Android & iOS for me

[burczu]

Hey, it's Bartek from Callstack, I would like to take care of this issue

[MelvinBot]

📣 @burczu You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Awaiting your proposal @burczu thanks! Anyone else also can submit their proposals before Bartek's

[BeeMargarida]

Hi, just leaving a heads up that I'll be taking over for @burczu while he is on vacation

[MelvinBot]

📣 @BeeMargarida You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[BeeMargarida]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening the report page of the existing chat, the composer component is not focused automatically.

What is the root cause of that problem?

This is actually a new feature, since with the current logic, the input is only focused if the chat is empty.

What changes do you think we should make in order to solve the problem?

Two changes need to happen:

• Identify that the opening of the report page came from a deep link and not just normal navigation inside the app
  • Necessary to pass a parameter fromDeepLink that identifies that it's from deep link in actions/Report.js#L1379. There are 2 options:
    1. Support passing params in Navigation.navigate and DeprecatedCustomActions.pushDrawerRoute
    2. Pass the param by route like Navigation.navigate(ROUTES.getReportRoute(reportID) + '?fromDeepLink=true'); and fetch it's value in ReportScreen
  • Receive param in ReportScreen and propagate through ReportFooter -> ReportActionCompose
• Change ReportActionCompose.js#L796 so that it passes autoFocus=true not only if it's visible and the chat is empty (for mobile), but also if it came from a deep link

What alternative solutions did you explore? (Optional)

N/A

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[twisterdotcom]

Just waiting on the PR.

[BeeMargarida]

Was the proposal above accepted?

[Santhosh-Sellavel]

@Julesssss
Sorry for the delay here,

I think we should put this on hold and do nothing about this for now.

Reasons

Well, this issue is not specific to deep link flow. It happens in normal cases too. Issue outline focus is inconsistent between mobile native & mweb apps for which we have issue #10731 to unify the focus across platforms and make it consistent on mobile i.e

Always focus the input, but prevent keyboard from opening on mobile & mWeb

And we have done some work there on the respective upstream repos and waiting for the release on the RNW.

[twisterdotcom]

Ah, we don't usually assign until a proposal is accepted. I see @mountiny assigned @BeeMargarida.

[Santhosh-Sellavel]

@twisterdotcom Since they are from callstack we will assign them upfront

[situchan]

I think this should be added to the Focus Tracking issue #15992

[twisterdotcom]

@Julesssss that makes sense to me. Should we close and link this to #15992

[Julesssss]

@Julesssss that makes sense to me. Should we close and link this to #15992

Yeah, makes sense to me 👍