[HOLD for payment 2023-08-02] [$250] Migrate index.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/DatePicker/index.js
  • type: React.Component
  • has state values: false
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidMount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e1cb4c2da152efa
• Upwork Job ID: 1686847396210348032
• Last Price Increase: 2023-08-02
• Automatic offers:
• shubham1206agra | Contributor | 25912631

[muxriddinmuqimov77]

I'd like to work on this issue

[s-alves10]

I'd love to work on this.

[marcaaron]

Taking this one off HOLD.

[rayane-djouah]

@marcaaron I'd like to work on this

[melvin-bot]

This issue has not been updated in over 15 days. @srikarparsi eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mejed-alkoutaini]

I'm able to work on this if needed!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Convert Date Picker to Functional Component #20864

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[shubham1206agra]

@marcaaron Since the PR was reverted. Can I try it converting this functional component?

[melvin-bot]

Triggered auto assignment to @garrettmknight (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

📣 @0xmiroslav We're missing your Upwork ID to automatically send you an offer for the Reviewer role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Contributor role ($250)

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($250)

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@sobitneupane, @srikarparsi, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[srikarparsi]

Hi @lschurr! Can you please pay @shubham1206agra for creating this PR and @sobitneupane for testing this PR whenever you get a chance?

[lschurr]

Sure! The automation says both are $250. Is that correct @srikarparsi?

[srikarparsi]

Yup, that's right, thanks @lschurr!

[lschurr]

Payment summary:

• @shubham1206agra $250 (paid in Upwork)
• @sobitneupane $250 (please request in NewDot)

[lschurr]

Do we need any regression tests or anything further? Can this be closed @srikarparsi?

[srikarparsi]

Hey yeah closing this out! I don't think regression tests are needed because they already covered this case which is why the issue was reported.

[sobitneupane]

Requested payment on newDot.

#16138 (comment)

[JmillsExpensify]

Reviewed the details for @sobitneupane. $250 approved for payment via NewDot based on BZ summary above.