[Close the contract] IOU messages cannot be reacted to

[stitesExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Request money from a user
2. Try to react

Expected Result:

You can react to the message

Actual Result:

You can't react to the message

Workaround:

No

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856 n/a
Notes/Photos/Videos: Any additional supporting documentation n/a
Expensify/Expensify Issue URL: n/a
Issue reported by: @stitesExpensify
Slack conversation: n/a

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4530d915e523b09
• Upwork Job ID: 1640322784276393984
• Last Price Increase: 2023-03-27

[MelvinBot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4530d915e523b09

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[conorpendergrast]

Requests, and cancels 👍

[stitesExpensify]

Web PR is merged for this! We need to wait for it to be deployed and then we can merge the app portion

[Santhosh-Sellavel]

Cool!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Un-restrict IOU reactions #16667

If no regressions arise, payment will be issued on 2023-04-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A, reported internally by @stitesExpensify
• Contributor that fixed the issue - N/A, fixed internally by @stitesExpensify
• Contributor+ that helped on the issue and/or PR - @Santhosh-Sellavel - $1000

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

We agreed not to do the checklist here!

• [@Santhosh-Sellavel / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@conorpendergrast] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[conorpendergrast]

@stitesExpensify As you mention in the PR, the UI/ UX side of this bug was deliberate, given the backend bug. I think that we can skip the BugZero Checklist, do you agree?

[conorpendergrast]

@stitesExpensify Also, $1000 for @Santhosh-Sellavel for C+, correct?

[stitesExpensify]

I think that we can skip the BugZero Checklist, do you agree?

Yep!

Also, $1000 for @Santhosh-Sellavel for C+, correct?

Correct!

[conorpendergrast]

Thanks!

[conorpendergrast]

Removing the hold, paying today

[conorpendergrast]

The hire buttons aren't there for this job, so I'm trying to work out why to make sure I can pay this

[conorpendergrast]

Worked it out, thanks for Dylan and Joe. Contract offered to @Santhosh-Sellavel, paying the base rate of $1000, as this was merged a few hours more than 3 business days after the PR was taken off hold.

[Santhosh-Sellavel]

Bonus is not applicable for internal PRs @conorpendergrast

[conorpendergrast]

Haha, ok yes thanks @Santhosh-Sellavel. Paid now!

The End Contract flow is not working, so I guess that's a problem for Tomorrow Conor

[conorpendergrast]

Contracted ended today. All done, thanks everyone!