Un-restrict IOU reactions

[stitesExpensify]

Details

When we released emoji reactions there was a backend bug that caused IOU reactions to disappear when being reacted to. To prevent this from appearing in the front end we prevented users from reacting to IOU message.

Now that the backend has been fixed, we can un-restrict the ability to react to IOUs.

Fixed Issues

$ #16549
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

1. Open NewDot with different accounts on 2 devices (or incognito tab)
2. Send an IOU (money request or send)
3. React to the IOU
4. Wait a few seconds and make sure the IOU doesn't disappear for either user, and both users can see the reaction
5. Send a normal message and react
6. Wait a few seconds and make sure the message doesn't disappear for either user, and both users can see the reaction

• Verify that no errors appear in the JS console

Offline tests

1. Go offline
2. Open NewDot with different accounts on 2 devices (or incognito tab)
3. Send an IOU (money request or send)
4. React to the IOU
5. Send a normal message and react
6. Go back online
7. Make sure that your emojis can be seen by both users, and that the IOU doesn't disappear

QA Steps

1. Open NewDot with different accounts on 2 devices (or incognito tab)
2. Send an IOU (money request or send)
3. React to the IOU
4. Wait a few seconds and make sure the IOU doesn't disappear for either user, and both users can see the reaction
5. Send a normal message and react
6. Wait a few seconds and make sure the message doesn't disappear for either user, and both users can see the reaction

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-03-29_15-44-47.mp4

Mobile Web - Chrome

2023-03-29_15-43-33.mp4

Mobile Web - Safari

2023-03-29_15-27-27.mp4

Desktop

2023-03-29_15-46-46.mp4

iOS

2023-03-29_15-17-03.mp4

Android

2023-03-29_15-42-33.mp4

[MelvinBot]

@Santhosh-Sellavel @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Santhosh-Sellavel]

IOU Messages get disappeared for me

Old IOU

Screen.Recording.2023-03-30.at.12.08.03.AM.mov

New IOU

Screen.Recording.2023-03-30.at.12.10.25.AM.mov

[Santhosh-Sellavel]

Please check the above

[stitesExpensify]

My apologies, I'll put this on hold, this should have been a draft PR. There is a backend change that needs to be deployed before this will work

[stitesExpensify]

hi @Santhosh-Sellavel can you please re-test now that the backend is deployed?

[Santhosh-Sellavel]

Will test it later today.

[Santhosh-Sellavel]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-04-07.at.7.35.58.AM.mov

Mobile Web - Chrome

Screen_Recording_20230407_222621_Chrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-07.at.22.13.36.mp4

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-07.at.22.11.47.mp4

Android

Screen_Recording_20230407_223529_New.Expensify.mp4

[Santhosh-Sellavel]

@stitesExpensify Looks good mostly I noticed two bugs.

1. Sometimes React/undo-reaction not updating properly (Cannot reproduce consistently)
2. Check the below video after react/undo-react composer gets focused on mWeb Android and weirdly keyboard opens up

Screen_Recording_20230407_222823_Chrome.mp4

But this is not specific to IOU alone

[Santhosh-Sellavel]

Tests well!

[stitesExpensify]

@Santhosh-Sellavel are either of those specific to IOU reactions? I think both will happen with other types of messages as well

[Santhosh-Sellavel]

@Santhosh-Sellavel are either of those specific to IOU reactions? I think both will happen with other types of messages as well

Yes @stitesExpensify

[Santhosh-Sellavel]

Can I report it in slack?

[grgia]

Good to merge? Or waiting until those bugs are handled?

[stitesExpensify]

Sorry, I'm a bit confused. @Santhosh-Sellavel are you saying that:

1. Those bugs do happen for other message types
   or
2. Those bugs only happen for IOU messages

[stitesExpensify]

Also, is that bug in your video the same as this one? #15818

[stitesExpensify]

Sometimes React/undo-reaction not updating properly

I think that might be this one #16506

[Santhosh-Sellavel]

@stitesExpensify Yes this one

Sometimes React/undo-reaction not updating properly

I think that might be this one #16506

[Santhosh-Sellavel]

@stitesExpensify Looks good mostly I noticed two bugs.

1. Sometimes React/undo-reaction not updating properly (Cannot reproduce consistently)
2. Check the below video after react/undo-react composer gets focused on mWeb Android and weirdly keyboard opens up

But this is not specific to IOU alone

What about (2)?

[stitesExpensify]

Is 2 the same as this bug? #15818

[Santhosh-Sellavel]

Is 2 the same as this bug? #15818

I was confused too. But no it was a different bug.

[stitesExpensify]

Sorry, and to clarify, does that happen to all comments? Or only IOU? If it's all comments, then feel free to report it in expensify-bugs. If not, then I should fix it here before we merge

[Santhosh-Sellavel]

Cool, I'll check that again it's not happening on latest staging

[Santhosh-Sellavel]

Sorry for the delay, I can confirm this occurs for the normal message too. It's reproducible on staging too. So we are good to go!

Staging

Staging_s.mp4

Dev

Screen_Recording_20230412_015054_Chrome.mp4

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.2.99-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅