Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-11 #17298

Closed
26 tasks done
OSBotify opened this issue Apr 11, 2023 · 9 comments
Closed
26 tasks done

Deploy Checklist: New Expensify 2023-04-11 #17298

OSBotify opened this issue Apr 11, 2023 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 11, 2023

Release Version: 1.2.99-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.99-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.99-3 has been deployed to staging 🎉

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 12, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.99-4 🚀

@francoisl
Copy link
Contributor

Checking #17309 and #16952, there are no QA steps needed.

@francoisl francoisl self-assigned this Apr 12, 2023
@mvtglobally
Copy link

@francoisl Regression is almost completed

PR #16941 is failing #17354. Repro in PROD. Checking off
PR #16869 we are facing a spinner when opening the app after popup, but actual PR steps seem pass. Can you validate as well?
PR #17250 is failing #17333. Not repro in prod, but it's a new feature, so didn't have Blocker label

@mvtglobally
Copy link

Regression is completed

@francoisl
Copy link
Contributor

PR #16869 we are facing a spinner when opening the app after popup, but actual PR steps seem pass. Can you validate as well?

I'm experiencing the same thing, but I can also reproduce the issue with the production desktop app, so I don't think it's a regression from this PR. I'll check this off, but can you please still open a regular issue to get this looked into?

@francoisl
Copy link
Contributor

Retested #17250 and confirmed it works on Android & iOS. I think it might have not worked initially if you tested before we cherry-picked 1.2.99-6. Either way, we're all set here!

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants