[HOLD for payment 2023-04-26] [HOLD for payment 2023-04-24] [$1000] The tooltip of the group profile is displaying a blank space on the right side, making it look weird.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Website
2. Create a group with multiple members
3. Go to group chat and hover over profile.

Expected Result:

The tooltip should not have any blank space on its sides.

Actual Result:

The tooltip is displaying a blank space on the right side of the text.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680205984931229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e05c0d676c4933a0
• Upwork Job ID: 1642861884599095296
• Last Price Increase: 2023-04-03

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

Reproduced

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01e05c0d676c4933a0

[MelvinBot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are a few space on the avatar group tooltip wrapper.

What is the root cause of that problem?

Tooltip has a maximum width of 375.

App/src/components/Tooltip/tooltipPropTypes.js

Line 49 in 4ee21e9

maxWidth: variables.sideBarWidth,

Because the text is very long, the text breaks to the next line and left some space on the right. This issue happens depends on how long the tooltip text.

What changes do you think we should make in order to solve the problem?

We should change how the text would break. We can simply apply word-break to the tooltip text style here

App/src/styles/getTooltipStyles.js

Lines 191 to 201 in 4ee21e9

	tooltipTextStyle: {
	color: themeColors.textReversed,
	fontFamily: fontFamily.EXP_NEUE,
	fontSize: tooltipFontSize,
	overflow: 'hidden',
	lineHeight: variables.lineHeightSmall,
	// To measure tooltip text width correctly we render it freely i.e. text should not wrap to parent's boundaries.
	// More info: https://github.com/Expensify/App/issues/15949#issuecomment-1483011998
	...(tooltipContentWidth ? {} : styles.pre),
	},

...wordBreak.breakAll,

Before:

After:

[0xmiros]

The screenshot in issue description is deprecated.

This should be the correct one:
#16578 (comment)

[bernhardoj]

I think that would be a different case as the reaction tooltip render it's own component.

EDIT: I see now, we can apply the same fix to both tooltip text and reaction text if we want.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The tooltip of the group profile is displaying a blank space on the right side, making it look weird

What is the root cause of that problem?

In the TooltipRenderedOnPageBody.js, firstly we set tooltipContentWidth to undefined

App/src/components/Tooltip/TooltipRenderedOnPageBody.js

Lines 88 to 96 in ebc03db

	componentDidUpdate(prevProps) {
	if (prevProps.text === this.props.text && prevProps.renderTooltipContent === this.props.renderTooltipContent) {
	return;
	}
	// Reset the tooltip text width to 0 so that we can measure it again.
	// eslint-disable-next-line react/no-did-update-set-state
	this.setState({tooltipContentWidth: undefined}, this.updateTooltipContentWidth);
	}

Next, if the offSetWidth > maxWidth (in this case, max width is 375px), we will update the width of tooltips is maxwidth

App/src/styles/getTooltipStyles.js

Lines 103 to 105 in ebc03db

	const wrapperWidth = tooltipContentWidth && (tooltipContentWidth < maxWidth
	? tooltipContentWidth + (spacing.ph2.paddingHorizontal * 2) + 1
	: maxWidth);

But then we don't update the tooltipContentWidth so that the tooltipContentWidth still be the old value

What changes do you think we should make in order to solve the problem?

In TooltipRenderedOnPageBody.js, We need to re-calculate the tooltipContentWidth one more time if it is greater than maxWidth

What alternative solutions did you explore? (Optional)

NA

Result

[mollfpr]

@bernhardoj I think we still want an email still in the same line so it is easy to read it.

@dukenv0307 Could you share the result using shorten email? I wondering if it's still showing only 3 line emails.

[mollfpr]

@0xmiroslav What we have here is a tooltip in the avatar group, and what you attach is in the reaction tooltip.

I wonder if we can apply the same solution for the reaction tooltip.

[0xmiros]

If they have the same root cause, solution should also be same and can be applied to reaction tooltip as well.
If different solution and need more research, can be separate issue.

[mollfpr]

Sounds good!

[dukenv0307]

@mollfpr This is the result of using shorten email, the number of lines will depend on the width of content

[mollfpr]

@dukenv0307 That looks good to me. Can we also fix the tooltip on the reaction chat?

[dukenv0307]

@mollfpr It works well in the tooltip on the reaction chat

[mollfpr]

Next, if the offSetWidth > maxWidth (in this case, max width is 375px), we will update the width of tooltips is maxwidth

But then we don't update the tooltipContentWidth so that the tooltipContentWidth still be the old value

@dukenv0307 Just a question to understand the root cause is. Could you explain when we didn't update the tooltipContentWidth and why we still using the old value of tooltipContentWidth? Thanks!

[dukenv0307]

@mollfpr Currently, If tooltipContentWidth (ex: 1200px) > maxWidth (ex: 375px), we will update wrapperWidth (the width of tooltips) is maxWidth (375px)

App/src/styles/getTooltipStyles.js

Lines 103 to 105 in ebc03db

	const wrapperWidth = tooltipContentWidth && (tooltipContentWidth < maxWidth
	? tooltipContentWidth + (spacing.ph2.paddingHorizontal * 2) + 1
	: maxWidth);

But at this time, because the email is too long it automatically breaks the line, It makes the offsetWidth of tooltips smaller(ex: 260px) and we don't have any logic to update tooltipContentWidth = current offsetWidth (260px) (tooltipContentWidth still be 1200px) so the wrapperWidth is not updated (it still be 375px)
Note: tooltipContentWidth only be used to calculate the wrapperWidth. So that if the wrapperWidth is correct, we won't need to update tooltipContentWidth. But in this case, after updating the wrapperWidth, the wrapperWidth still be wrong (Because the email is too long, it automatically breaks the line).
To resolve this problem, we need to update tooltipContentWidth one more time then wrapperWidth also be updated one more time

[mollfpr]

Thanks @situchan! Yeah, we should clean that up. @dukenv0307 Could you open a PR for the update so we can CP the PR before it's hit production?

[dukenv0307]

@mollfpr I am doing on it. The PR will be ready soon

[dukenv0307]

@mollfpr The PR is ready to review. Please check.

[puneetlath]

@bfitzexpensify let's make sure @situchan gets paid for a bug report on this one as well.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Regression of console error #17494

If no regressions arise, payment will be issued on 2023-04-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @bfitzexpensify] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Re: regression test, I think it's reasonable to update the Create Group Conversation regression test with an extra step like:

• Verify the tooltip is correctly spaced when hovering over the profile images of all users in the group

[mollfpr]

@bfitzexpensify Yes! That seems an excellent place to put in the regression test.

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Blank space on the right side of tooltip #17218
• Fix: Regression of console error #17494

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @bfitzexpensify] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/278028

[bfitzexpensify]

Offers sent out @situchan @Tushu17 @mollfpr

@dukenv0307 I couldn't find you on Upwork - can you please apply to the job here?

Regression test update is in https://github.com/Expensify/Expensify/issues/278028

[dukenv0307]

@bfitzexpensify I've applied, my profile is https://www.upwork.com/freelancers/~01f5cbe690701118a2, thank you!

[bfitzexpensify]

@dukenv0307 offer was sent last week, please accept and I'll finalize payment - thanks!

[dukenv0307]

@bfitzexpensify I've accepted, thanks!

[bfitzexpensify]

Great, that's all paid out now. @mollfpr once you complete the steps in #16800 (comment) we can close this one out.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

We have refactored the tooltip body in this PR #15325, but I don't think that PR is wrong doing it.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) to catch this type of bug sooner. Link to discussion:

Regression steps should be enough.

[bfitzexpensify]

Cool, thanks! Agreed with your points. OK, let's close this one out.