Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #15992] [$1000] Focus is not returned to the editor text field when a user opens settings sidebar and closes it #16844

Closed
1 of 6 tasks
kavimuru opened this issue Apr 1, 2023 · 61 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Apr 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Hover over an existing comment > click on ‘edit’ icon
  2. Click on profile avatar
  3. Close settings sidebar

Expected Result:

Focus should be returned to the editor text field

Actual Result:

Focus is returned to chat box

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.119.mp4
2023-04-01.01.21.28.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680301816029279

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0151a26bfc95a8613e
  • Upwork Job ID: 1643250384957026304
  • Last Price Increase: 2023-04-04
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 1, 2023
@MelvinBot
Copy link

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 4, 2023
@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label Apr 4, 2023
@melvin-bot melvin-bot bot changed the title Focus is not returned to the editor text field when a user opens settings sidebar and closes it [$1000] Focus is not returned to the editor text field when a user opens settings sidebar and closes it Apr 4, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0151a26bfc95a8613e

@MelvinBot
Copy link

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 4, 2023
@MelvinBot
Copy link

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@garrettmknight
Copy link
Contributor

Reproduced, agreed that the focus should return to the editor, opening up!

@melvin-bot melvin-bot bot removed the Overdue label Apr 4, 2023
@bernhardoj
Copy link
Contributor

bernhardoj commented Apr 4, 2023

Maybe we should add this issue to a tracking issue here #15992

@michaelhaxhiu
Copy link
Contributor

@bernhardoj just noticed you posted a similar question ^ to me, which is happening on this slack thread.

@garrettmknight
Copy link
Contributor

Added, putting this on hold similar to the other linked issue in that GH.

@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2023
@garrettmknight garrettmknight added Overdue Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 7, 2023
@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2023
@garrettmknight garrettmknight changed the title [$1000] Focus is not returned to the editor text field when a user opens settings sidebar and closes it [HOLD] [$1000] Focus is not returned to the editor text field when a user opens settings sidebar and closes it Apr 7, 2023
@garrettmknight
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@lschurr
Copy link
Contributor

lschurr commented Jan 22, 2024

On hold

@lschurr lschurr removed the Overdue label Jan 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@lschurr
Copy link
Contributor

lschurr commented Jan 22, 2024

Not overdue - not sure why the overdue label keeps sticking.

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2024
@lschurr
Copy link
Contributor

lschurr commented Jan 31, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 9, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Feb 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 19, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 28, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 7, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 15, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 25, 2024

Hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@lschurr
Copy link
Contributor

lschurr commented Apr 1, 2024

This has been on hold forever and the other GHs are closed as Not a Priority: #15992, #16362

Should we close this one as well @francoisl @mollfpr?

@francoisl
Copy link
Contributor

Ok, works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests