Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-16] CreateTask Front-End #16855

Closed
thienlnam opened this issue Apr 2, 2023 · 20 comments
Closed

[HOLD for payment 2023-05-16] CreateTask Front-End #16855

thienlnam opened this issue Apr 2, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Apr 2, 2023

https://docs.google.com/document/d/1uFj0Oh9qtFJ-EH-lg00oMflo8uhkV2yXUT8Tbg6cKws/edit#bookmark=id.3uu2uj4fl14

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01940c9db6113377bf
  • Upwork Job ID: 1659627543688757248
  • Last Price Increase: 2023-05-19
@thienlnam thienlnam added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 2, 2023
@MelvinBot
Copy link

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2023
@thienlnam thienlnam assigned thienlnam and unassigned twisterdotcom Apr 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@thienlnam
Copy link
Contributor Author

Going to be working with IR on this

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 12, 2023
@thienlnam thienlnam removed the Reviewing Has a PR in review label Apr 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 20, 2023
@thienlnam thienlnam added Daily KSv2 and removed Weekly KSv2 labels Apr 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2023
@thienlnam
Copy link
Contributor Author

Navigation PR is merged, this issue is ready to be worked on - assigning someone from IR

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@cdanwards
Copy link
Contributor

Taking on this issue!

@MelvinBot

This comment was marked as off-topic.

@MelvinBot
Copy link

@cdanwards, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cdanwards
Copy link
Contributor

Optimistic Task Creation and AssignTask functions have been created. The UI for the Assignee selection has also been created. Currently working on the Room selection and have some questions about scope needed to finish this as well as clarifying share destinations.

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 9, 2023
@melvin-bot melvin-bot bot changed the title CreateTask Front-End [HOLD for payment 2023-05-16] CreateTask Front-End May 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 15, 2023
@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01940c9db6113377bf

@melvin-bot

This comment was marked as outdated.

@thienlnam thienlnam assigned fedirjh and unassigned aimane-chnaif May 19, 2023
@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@thienlnam
Copy link
Contributor Author

thienlnam commented May 19, 2023

Assigning BZ so we can get @fedirjh paid for the internal review of this PR

cdanwards is working with us through the infinite-red contract and so does not need to be paid through Upwork

cc @twisterdotcom (original pullerbear from when I added the NewFeature label)

@twisterdotcom
Copy link
Contributor

Okay, sorry. I just need to pay out @fedirjh $1k for the Internal PR review via Upwork?

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@thienlnam
Copy link
Contributor Author

Yup that's correct!

@melvin-bot melvin-bot bot added the Overdue label May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

@cdanwards, @twisterdotcom, @thienlnam, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@twisterdotcom
Copy link
Contributor

Sorry! So sorry for the lateness. @fedirjh - payment invite here: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/24722499

@melvin-bot melvin-bot bot removed the Overdue label May 25, 2023
@twisterdotcom
Copy link
Contributor

Payment sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

6 participants