[HOLD for payment 2023-06-05] [$1000] Assign task- 404 error in the console appears when create a task #19134

mvtglobally · 2023-05-17T18:27:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login
Go to any #announce
Create a task

Expected Result:

No errors in console

Actual Result:

404 error in the console appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6058823_Recording__608.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e1b763b4e7b70a1
Upwork Job ID: 1658927033624666112
Last Price Increase: 2023-05-19

melvin-bot · 2023-05-17T18:27:45Z

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-05-17T18:27:47Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

conorpendergrast · 2023-05-17T20:02:51Z

Yep, reproduced!

conorpendergrast · 2023-05-17T20:06:33Z

@thienlnam I think this should be over to you! I'll label it Internal to get the ball rolling, and will also then assign you too

melvin-bot · 2023-05-17T20:06:43Z

Job added to Upwork: https://www.upwork.com/jobs/~012e1b763b4e7b70a1

conorpendergrast · 2023-05-17T20:06:46Z

If I'm wrong, let me know!

melvin-bot · 2023-05-17T20:06:47Z

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

thienlnam · 2023-05-19T19:10:59Z

The error is with AuthenticatePusher, not sure why that is showing up. The EditTask command should now be on production and so that error shouldn't be happening anymore

thienlnam · 2023-05-19T19:11:13Z

I think we can have this external for someone to investigate

melvin-bot · 2023-05-19T19:11:28Z

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-05-19T19:11:33Z

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-05-19T19:11:36Z

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

phuchoang23 · 2023-05-20T10:12:42Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task- 404 error in the console appears when create a task

What is the root cause of that problem?

404 error is come from this API to authorize Pusher when our App need to subscribe to a socket channel.

I suspect the API to create Task (+ report) is not finished yet, then we navigate to taskReport in this line
The ReportScreen will load and it triggers this line to subscribe to private socket channels of the report

App/src/pages/home/report/ReportActionsView.js

Lines 230 to 233 in 7378626

    
           if (!this.didSubscribeToReportTypingEvents && didCreateReportSuccessfully) { 
        
               Report.subscribeToReportTypingEvents(this.props.report.reportID); 
        
               this.didSubscribeToReportTypingEvents = true; 
        
           }

=> Can cause 404 error because the create Task API is not finished yet (report is not created yet)

Screenshots when navigate to a newly chatReport and a newly taskReport

newly taskReport

newly chatReport

What changes do you think we should make in order to solve the problem?

To solve this problem we need to ensure the taskReport is created successfully before subscribe to its private channels

More details:
We need to follow this condition:

App/src/pages/home/report/ReportActionsView.js

Lines 225 to 229 in 7378626

    
           // Ensures subscription event succeeds when the report/workspace room is created optimistically. 
        
           // Check if the optimistic `OpenReport` or `AddWorkspaceRoom` has succeeded by confirming 
        
           // any `pendingFields.createChat` or `pendingFields.addWorkspaceRoom` fields are set to null. 
        
           // Existing reports created will have empty fields for `pendingFields`. 
        
           const didCreateReportSuccessfully = !this.props.report.pendingFields || (!this.props.report.pendingFields.addWorkspaceRoom && !this.props.report.pendingFields.createChat);

That means when build optimisticTaskReport data, we need to add pendingFields.createChat with CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD (and isOptimisticReport: true so it won't trigger OpenReport API when it's not ready).

                pendingFields: {
                    createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                },
                isOptimisticReport: true,

And reset those fields in successData.

We used this trick in some other places:

Result:

conorpendergrast · 2023-05-22T09:16:56Z

Unassigning @laurenreidexpensify as I'm already assigned as BugZero

thesahindia · 2023-05-23T10:21:11Z

I don't think I will be able to review this today. I have too much on my plate at the moment. @conorpendergrast, can you please reassign?

conorpendergrast · 2023-05-23T10:23:43Z

Asked in Slack

phuchoang23 · 2023-05-25T10:59:00Z

@aimane-chnaif @thienlnam bump for code review

conorpendergrast · 2023-05-26T13:48:31Z

PR reviewed and on Staging

melvin-bot · 2023-05-29T23:17:46Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-05-29T23:17:48Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fixed 404 error in the console appears when create a task #19513

If no regressions arise, payment will be issued on 2023-06-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter - N/A, Applause
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-29T23:17:51Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

conorpendergrast · 2023-06-06T19:51:01Z

Argh, Upwork isn't letting me hire on the existing job. I'll have to create new ones - tomorrow!

conorpendergrast · 2023-06-07T12:35:16Z

Looks like this was merged in less than 3 business days, so adding a 50% urgency bonus for C and C+

conorpendergrast · 2023-06-07T12:38:57Z

@aimane-chnaif contract sent via Upwork
@phuchoang23 Can you reply here with your Upwork profile URL please?

phuchoang23 · 2023-06-07T13:01:02Z

@conorpendergrast Here is my Upwork profile
https://www.upwork.com/freelancers/~01ae621d43ddc5931a

phuchoang23 · 2023-06-07T13:28:41Z

@conorpendergrast Did you send contract to me via Upwork?

conorpendergrast · 2023-06-07T13:49:46Z

I will shortly send the contract, yes!

conorpendergrast · 2023-06-07T14:15:15Z

@aimane-chnaif paid
@phuchoang23 contract sent!

phuchoang23 · 2023-06-07T14:30:55Z

@conorpendergrast I accepted the offer

conorpendergrast · 2023-06-07T14:38:18Z

@phuchoang23 Paid!

conorpendergrast · 2023-06-07T14:40:14Z

Alright, just the BugZero checklist here

phuchoang23 · 2023-06-08T02:19:54Z

@conorpendergrast Thanks 👍

conorpendergrast · 2023-06-09T18:59:57Z

@aimane-chnaif Bump on the BugZero checklist here please!

aimane-chnaif · 2023-06-09T19:22:38Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Create Task FrontEnd Changes #17992

[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17992/files#r1224672801

[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[@aimane-chnaif] Determine if we should create a regression test for this bug.

[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This bug was introduced while implementing new feature of create task.
This should have been caught earlier in PR review if they tested offline case.
As offline test is already in PR checklist, no further regression test step is needed.

conorpendergrast · 2023-06-12T12:22:35Z

Got it. Sounds like we're all done. Closing, thanks all!

mvtglobally added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 17, 2023

melvin-bot bot assigned conorpendergrast May 17, 2023

conorpendergrast added the Internal Requires API changes or must be handled by Expensify staff label May 17, 2023

melvin-bot bot assigned thesahindia May 17, 2023

conorpendergrast assigned thienlnam May 17, 2023

thienlnam added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels May 19, 2023

melvin-bot bot changed the title ~~Assign task- 404 error in the console appears when create a task~~ [$1000] Assign task- 404 error in the console appears when create a task May 19, 2023

melvin-bot bot assigned laurenreidexpensify May 19, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 19, 2023

melvin-bot bot added the Overdue label May 22, 2023

conorpendergrast unassigned laurenreidexpensify May 22, 2023

melvin-bot bot removed the Overdue label May 22, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 29, 2023

melvin-bot bot changed the title ~~[$1000] Assign task- 404 error in the console appears when create a task~~ [HOLD for payment 2023-06-05] [$1000] Assign task- 404 error in the console appears when create a task May 29, 2023

melvin-bot bot removed the Reviewing Has a PR in review label May 29, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 5, 2023

aimane-chnaif mentioned this issue Jun 9, 2023

Create Task FrontEnd Changes #17992

Merged

80 tasks

melvin-bot bot added the Overdue label Jun 12, 2023

conorpendergrast closed this as completed Jun 12, 2023

melvin-bot bot removed the Overdue label Jun 12, 2023

[HOLD for payment 2023-06-05] [$1000] Assign task- 404 error in the console appears when create a task #19134

[HOLD for payment 2023-06-05] [$1000] Assign task- 404 error in the console appears when create a task #19134

Comments

mvtglobally commented May 17, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented May 17, 2023

melvin-bot bot commented May 17, 2023 • edited by conorpendergrast Loading

Bug0 Triage Checklist (Main S/O)

conorpendergrast commented May 17, 2023

conorpendergrast commented May 17, 2023

melvin-bot bot commented May 17, 2023

conorpendergrast commented May 17, 2023

melvin-bot bot commented May 17, 2023

thienlnam commented May 19, 2023

thienlnam commented May 19, 2023

melvin-bot bot commented May 19, 2023

melvin-bot bot commented May 19, 2023

melvin-bot bot commented May 19, 2023

phuchoang23 commented May 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

conorpendergrast commented May 22, 2023

thesahindia commented May 23, 2023

conorpendergrast commented May 23, 2023

phuchoang23 commented May 25, 2023 • edited Loading

conorpendergrast commented May 26, 2023

melvin-bot bot commented May 29, 2023

melvin-bot bot commented May 29, 2023 • edited by conorpendergrast Loading

melvin-bot bot commented May 29, 2023 • edited by conorpendergrast Loading

conorpendergrast commented Jun 6, 2023

conorpendergrast commented Jun 7, 2023

conorpendergrast commented Jun 7, 2023

phuchoang23 commented Jun 7, 2023

phuchoang23 commented Jun 7, 2023

conorpendergrast commented Jun 7, 2023

conorpendergrast commented Jun 7, 2023

phuchoang23 commented Jun 7, 2023

conorpendergrast commented Jun 7, 2023

conorpendergrast commented Jun 7, 2023

phuchoang23 commented Jun 8, 2023

conorpendergrast commented Jun 9, 2023

aimane-chnaif commented Jun 9, 2023 • edited Loading

conorpendergrast commented Jun 12, 2023

mvtglobally commented May 17, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 17, 2023 •

edited by conorpendergrast

Loading

phuchoang23 commented May 25, 2023 •

edited

Loading

melvin-bot bot commented May 29, 2023 •

edited by conorpendergrast

Loading

melvin-bot bot commented May 29, 2023 •

edited by conorpendergrast

Loading

aimane-chnaif commented Jun 9, 2023 •

edited

Loading