[HOLD for payment 2023-05-25] [HOLD #16855] CancelTask Front-End

[thienlnam]

https://docs.google.com/document/d/1uFj0Oh9qtFJ-EH-lg00oMflo8uhkV2yXUT8Tbg6cKws/edit#bookmark=id.6y8rx09sza5u

[MelvinBot]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[thienlnam]

Going to be working with IR on this

[thienlnam]

On hold

[cdanwards]

On hold

[thienlnam]

Same as above, assigning these out this week

[thienlnam]

This is still holding on this auth PR https://github.com/Expensify/Expensify/issues/272947

But can be worked on in conjunction to the auth PR going out.

To trigger a task report view, just force isTaskReport to return true and click on any chat report

[arosiclair]

A little confused by the section in the doc. Is the goal of this GH to add a "Cancel menu" option the to task report view? And when selected it runs a cancelTask action that calls the Auth command?

[thienlnam]

Yeah that's correct - the Cancel option should actually already exist, you just have to hook up functionality to it

Basically
Create the CancelTaskReportAction optimistically, and then pass that optimistic reportActionID, taskReportID to the endpoint CancelTask

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• CancelTask frontend #18747

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[arosiclair]

Hey @anmurali not sure why we unassigned you but could you handle C+ payment for this? @fedirjh did the review

[arosiclair]

Bump @anmurali

[anmurali]

Is it $1000? Is there a bonus of any kind?

[thienlnam]

Yup that's correct @anmurali No speed bonus for reviewing internal PRs

[anmurali]

Sent offer

[fedirjh]

@anmurali Thanks! Accepted

[anmurali]

Paid