CancelTask frontend #18747

arosiclair · 2023-05-10T21:16:50Z

Details

Adds action for cancelling a task

Fixed Issues

$ #16857

Tests

Create a task
In the task report, Three-dot menu > Cancel
Verify the task report appears archived
Navigate to the chat report with the user
Verify there's a "Canceled task" message
Click the Canceled task message
Verify it navigates to the canceled task report

Offline tests

Same as Tests but go offline after Step 1

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

src/libs/ReportUtils.js

…l-task-action

…siclair-cancel-task-action

arosiclair · 2023-05-15T17:09:18Z

@thienlnam I merged your completeTask branch to use the TaskAction component so your changes are gonna appear here until we get your PR merged. Holding until then

src/CONST.js

src/pages/home/report/ReportActionItem.js

src/libs/ReportUtils.js

src/libs/actions/Task.js

arosiclair · 2023-05-15T18:46:27Z

Suggestions look good though I'm gonna wait for your PR to get finalized before putting them in just so that I don't have to resolve conflicts over and over. Ping me when that's ready!

…l-task-action

melvin-bot · 2023-05-15T22:40:02Z

@fedirjh @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh

Looks good , left few comment to address some bugs

src/libs/actions/Task.js

fedirjh · 2023-05-16T01:31:44Z

src/pages/home/HeaderView.js

-
-                // Implementing in https://github.com/Expensify/App/issues/16857
-                onSelected: () => {},
+                onSelected: () => Task.cancelTask(props.report.reportID, props.report.parentReportID, props.report.reportName, props.report.stateNum, props.report.statusNum),


When we cancel the task , the Three dots are still visible and clickable with not action :

We decided to just hide this menu when the task is canceled

fedirjh · 2023-05-16T01:33:42Z

src/pages/home/report/ReportActionItem.js

@@ -204,7 +204,7 @@ class ReportActionItem extends Component {
                    checkIfContextMenuActive={this.checkIfContextMenuActive}
                />
            );
-        } else if (this.props.action.actionName === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) {
+        } else if (this.props.action.actionName === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED || this.props.action.actionName === CONST.REPORT.ACTIONS.TYPE.TASKCANCELED) {


We should add a check inside TaskPreview , If the task is canceled then disable the checkbox that marks the task as complete

Checkbox should now be disabled when the task is canceled

fedirjh · 2023-05-16T01:45:11Z

I think the Mark as done button should be replaced with a danger or gray canceled button when the task is canceled

…l-task-action

arosiclair · 2023-05-16T15:27:15Z

Thanks for the review I'm taking these questions to slack internally to get some answers (convo)

thienlnam · 2023-05-16T16:35:38Z

Looks like we're failing a lint but should be ready to test after that is fixed

thienlnam · 2023-05-16T17:02:41Z

Oh, also #18747 (comment) as well - let us know when it's ready

…l-task-action

arosiclair · 2023-05-16T18:20:23Z

Ready for another review!

fedirjh

Looks good to me, I will create reviewer checklist shorlty

fedirjh · 2023-05-16T19:08:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-16.at.7.41.19.PM.mov

Mobile Web - Chrome

CtaskmChrome.mov

Mobile Web - Safari

IOS.Safari.mov

Desktop

CTaskDesktop.mov

iOS

CTaskIOS.mov

Android

CTaskAndroid.mov

thienlnam

Looks great, thank you!

OSBotify · 2023-05-16T19:19:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-17T01:07:48Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-18T06:50:59Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

0xmiros · 2023-07-14T15:51:14Z

src/pages/home/HeaderView.js

+            selector: (account) =>
+                account && {
+                    guideCalendarLink: account.guideCalendarLink,
+                    primaryLogin: account.primaryLogin,


Is there a reason why primaryLogin is added here?

Not really sure might have just been added in a bad merge. If it isn't being used still I think it's fine to remove

rushatgabhane · 2023-08-02T07:07:18Z

src/CONST.js

@@ -463,6 +463,7 @@ const CONST = {
                CLOSED: 'CLOSED',
                CREATED: 'CREATED',
                TASKEDITED: 'TASKEDITED',
+                TASKCANCELED: 'TASKCANCELED',


beep boop 🤖 🐧

This PR caused #21314 (comment)

Because we have a typo-ish here.
The backend uses TASKCANCELLED (notice the double LL)

arosiclair added 2 commits May 10, 2023 16:26

add initial cancel task action with optimistic state and status changes

5ba5bee

create optimistic cancel task report action

fde26f3

arosiclair self-assigned this May 10, 2023

remove unused const

067e77e

arosiclair requested a review from thienlnam May 10, 2023 21:21

arosiclair commented May 10, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

arosiclair added 8 commits May 11, 2023 11:52

Merge branch 'main' of github.com:Expensify/App into arosiclair-cance…

b9c9f50

…l-task-action

make canceled task actions visible

dd199e5

add CancelTaskAction

3ac8891

Merge branch 'main' of github.com:Expensify/App into arosiclair-cance…

39e0a12

…l-task-action

match other task actions

adad9a4

Merge branch 'jack-completeTask' of github.com:Expensify/App into aro…

e5c08b5

…siclair-cancel-task-action

use TaskAction for cancel actions

1017659

update the report optimistically for the LHN

eb825c7

arosiclair changed the title ~~Add CancelTask action~~ [HOLD] Add CancelTask action May 15, 2023

thienlnam requested changes May 15, 2023

View reviewed changes

src/CONST.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

src/libs/actions/Task.js Outdated Show resolved Hide resolved

arosiclair added 4 commits May 15, 2023 17:22

Merge branch 'main' of github.com:Expensify/App into arosiclair-cance…

a9f6882

…l-task-action

use shared optimistic task action helper

e68d5ea

combine TaskAction logic

0d86edd

added spanish translation

1dea583

arosiclair requested a review from thienlnam May 15, 2023 22:38

arosiclair changed the title ~~[HOLD] Add CancelTask action~~ CancelTask frontend May 15, 2023

arosiclair marked this pull request as ready for review May 15, 2023 22:39

arosiclair requested a review from a team as a code owner May 15, 2023 22:39

melvin-bot bot requested review from fedirjh and marcaaron and removed request for a team May 15, 2023 22:40

fedirjh reviewed May 16, 2023

View reviewed changes

arosiclair added 2 commits May 16, 2023 10:18

Merge branch 'main' of github.com:Expensify/App into arosiclair-cance…

1d1ec1e

…l-task-action

added jsdoc for cancelTask

e0bef3a

disable TaskPreview checkbox when canceled

c8e284a

arosiclair added 4 commits May 16, 2023 13:37

disable done button when task is canceled

af6d95c

hide three dot menu when canceled

3ed87e9

Merge branch 'main' of github.com:Expensify/App into arosiclair-cance…

e234c0d

…l-task-action

revert Podfile.lock change

c0377c4

arosiclair force-pushed the arosiclair-cancel-task-action branch from 7b42786 to c0377c4 Compare May 16, 2023 18:19

arosiclair requested a review from fedirjh May 16, 2023 18:20

fedirjh approved these changes May 16, 2023

View reviewed changes

thienlnam approved these changes May 16, 2023

View reviewed changes

thienlnam merged commit fa372fc into main May 16, 2023

thienlnam deleted the arosiclair-cancel-task-action branch May 16, 2023 19:11

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[HOLD for payment 2023-05-25] [HOLD #16855] CancelTask Front-End #16857

Closed

0xmiros reviewed Jul 14, 2023

View reviewed changes

rushatgabhane reviewed Aug 2, 2023

View reviewed changes

rushatgabhane mentioned this pull request Aug 2, 2023

[HOLD for payment 2023-07-26] [$1000] Web - Order of task notification messages incorrect when back online #21314

Closed

6 tasks

0xmiros mentioned this pull request Aug 14, 2023

[HOLD for payment 2023-10-10] [$500] email is not shown in authenticator app #19366

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CancelTask frontend #18747

CancelTask frontend #18747

arosiclair commented May 10, 2023 •

edited

Loading

arosiclair commented May 15, 2023

arosiclair commented May 15, 2023

melvin-bot bot commented May 15, 2023

fedirjh left a comment

fedirjh May 16, 2023

arosiclair May 16, 2023

fedirjh May 16, 2023

arosiclair May 16, 2023

fedirjh commented May 16, 2023

arosiclair commented May 16, 2023

thienlnam commented May 16, 2023

thienlnam commented May 16, 2023

arosiclair commented May 16, 2023

fedirjh left a comment

fedirjh commented May 16, 2023

thienlnam left a comment

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

0xmiros Jul 14, 2023

arosiclair Jul 14, 2023

rushatgabhane Aug 2, 2023

CancelTask frontend #18747

CancelTask frontend #18747

Conversation

arosiclair commented May 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

arosiclair commented May 15, 2023

arosiclair commented May 15, 2023

melvin-bot bot commented May 15, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh May 16, 2023

Choose a reason for hiding this comment

arosiclair May 16, 2023

Choose a reason for hiding this comment

fedirjh May 16, 2023

Choose a reason for hiding this comment

arosiclair May 16, 2023

Choose a reason for hiding this comment

fedirjh commented May 16, 2023

arosiclair commented May 16, 2023

thienlnam commented May 16, 2023

thienlnam commented May 16, 2023

arosiclair commented May 16, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented May 16, 2023

Reviewer Checklist

Screenshots/Videos

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

0xmiros Jul 14, 2023

Choose a reason for hiding this comment

arosiclair Jul 14, 2023

Choose a reason for hiding this comment

rushatgabhane Aug 2, 2023

Choose a reason for hiding this comment

arosiclair commented May 10, 2023 •

edited

Loading