Deploy Checklist: New Expensify 2023-05-16

[OSBotify]

Release Version: 1.3.15-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Allow money request deletion #17348
• Display report preview using new reportAction data source #18423
• 17016 migrate switch #18512
• Use IOU/Expense reportID for IOU actions #18604
• fix: fix firefox redirection from old dot #18631
• Add pay button to money request header #18692
• Show transaction amount & description in report header for "transaction thread" #18695
• Allow policy admins to delete any message in rooms #18735
• CancelTask frontend #18747
• [Manual Requests] Create thread for Manual Request when opening IOUPreview #18760
• Fix: isReportMessageAttachment returns false if report action is not an attachment #18766
• fix: allow pasting magic codes in iOS Safari #18771
• Update Details Page for Threads #18772
• UI MoneyRequestHeader Polish #18775
• Fix: preferredSkinTone type warning #18789
• Change LHN header to Expensify #18802
• Complete Task Front End  #18806
• fix/18515: Update comment before setting new state #18814
• Use Math.round() instead of Math.trunc() to fix floating-point precision issues #18816
• Colour change for reaction bubbles #18819
• align lastMessageText formatting with backend by trimming leading and trailing spaces #18822
• Remove additional letters #18837
• Remove borderWidth of fullScreen smallScreen modal and modify PDF width #18851
• Fix - Pressing enter twice on selecting currency from search closes the send money/request money option #18265 #18853
• [2FA] fix: Submit 2FA code after refresh #18854
• fix: add a timeout on PressableWithFeedback for disable removal #18865
• [No QA] Add information about Prettier into our style guide #18869
• Clean up Thread UI #18876
• Fix header/lhn for threads #18880
• Fix composer flickers when sending multiple lines of message on Android #18884
• fix: add red border to the magic code input #18885
• Fix send money show "$0.00" in preview card #18902
• Update expensify-common to avoid removing line break before and after heading #18930
• Show tasks in LHN #18931
• Corrected - IOU Description extends beyond the page if recipient name is long #18933
• Fix remove button remains enabled when removing a user in other device #18934
• Fix search preview #18941
• update report preview message to use workspace name, not admin name #18945
• Bug fixes: QR codes #18946
• Update Expensify-Playbook-for-Small-to-Medium-Sized-Businesses.md #18954
• fix stale focusedIndex when maxIndex changed in ArrowKeyFocusManager #18955
• Fix holding down on the plus emoji icon selects the comment text #18957
• [No QA] just use regular echo for prettier lint #18959
• Feat: added margin between delete popover and payment method #18977
• Show IOU preview for send money flow #18981
• fix: fix escape shortcut for closing of popovers #18982
• [NoQA] Fix linter issue #18985
• Reopen Task #18986
• Fix skeleton overlap at Invite Member Page #18993
• fix: update version expensify common repo #18994
• ci: fix check if debug property exists #19001
• Feat: Adding border Separator to currency selection Page #19002
• feat: update submit button capitalisation #19005
• prevent grouping created action message #19019
• Prevent additional requests on settled request reports #19033
• Fix Image Flashing Bug #19056
• Fix crash with task action hover #19065
• Fix 0 Replies Bug FE #19106
• Fallback on report #19127
• using props reportID #19148

Internal QA:

• Allow all filetypes to be uploaded #18521 - @youssef-lr

Deploy Blockers:

• [HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] senders avatar and name are missing on create new chat and send message #19010
• [HOLD for payment 2023-05-29] in workspace chat, workspace details are missing in header #19123
• [HOLD for payment 2023-05-29] Infinite loading when navigating to a chat without access #19143
• [$1000] Web - Settings - After pressing the Esc key, Help tab is highlighted with a blue frame #19144
• [$1000] Pin/Unpin Offline - Chat returns to previous status when returning online after reload #19154
• "You don't have access to this chat" is not displayed when opening a deeplink with valid id #19166
• IOU - App is crashing when Settle Elsewhere #19171

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.15-0 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-1 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-1 has been deployed to staging 🎉

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-4 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-5 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-6 🚀

[isagoico]

Failing PRs

• 17016 migrate switch #18512 was failing because of this comment looks like it's expected behavior from @robertKozik 17016 migrate switch #18512 (comment)
• Clean up Thread UI #18876 (comment) is failing only on Android - issue here [HOLD for payment 2023-06-01] Android - Threads - Date is not truncated and very close to screen border  #19142
• Show transaction amount & description in report header for "transaction thread" #18695 is failing in all platforms because of LHN - Request money from WS shows negative number #19147

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-6 has been deployed to staging 🎉

[yuwenmemon]

#18512 was failing because of this #18512 (comment) looks like it's expected behavior from @robertKozik #18512 (comment)

Safe to check that off. It is indeed expected behavior.

[yuwenmemon]

#18876 (comment) is failing only on Android - issue here Android - Threads - Date is not truncated and very close to screen border #19142

Not a blocker either (thread). Checking that one off as well!

[isagoico]

Issues #19150 and #19149 failing the following PRs:

1. Reopen Task #18986
2. Complete Task Front End  #18806

CC @thienlnam

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-7 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-8 🚀

[jasperhuangg]

Checking off #19143 retested it after #19148 was merged and it doesn't appear to be happening anymore

[yuwenmemon]

Issues #19150 and #19149 failing the
following PRs:

#18986
Complete Task Front End #18806
CC @thienlnam

Not blockers as these features are internal to us: https://expensify.slack.com/archives/C07J32337/p1684364590953329

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-7 has been deployed to staging 🎉

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-8 has been deployed to staging 🎉

[mountiny]

Checking #18695 off and also checking #18902 off as they have been fixed and working in staging

[isagoico]

Left a comment in #18880 (comment) - I think this may be caused by the fact that both workspace chats (individual) and threads are behind betas (might be talking nonsense tho 😅)

[mvtglobally]

current summary

PR #18695 is failing in all platforms because of #19147. Fix wa pushed to prod https://github.com/Expensify/Web-Expensify/pull/37478. Ok to check it off?
PR #18880 note added #18880 (comment)
PR #18902 Can you help us QA internally?
PR #18934 is failing #19155. repro in PROD checking off

[yuwenmemon]

PR #18695 is failing in all platforms because of #19147. Fix wa pushed to prod https://github.com/Expensify/Web-Expensify/pull/37478. Ok to check it off?

Yep, we can check it off!

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.15-12 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.15-12 has been deployed to staging 🎉

[mvtglobally]

#19170 not a blocker as per https://expensify.slack.com/archives/C01GTK53T8Q/p1684383441386149

[yuwenmemon]

The final deploy blocker will be fixed API side, so since nothing needs to be updated with the NewDot code I'm going to deploy it. Details in this thread: https://expensify.slack.com/archives/C9YU7BX5M/p1684388267859979?thread_ts=1684343607.069549&cid=C9YU7BX5M

[yuwenmemon]