[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] senders avatar and name are missing on create new chat and send message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. click on + button
2. select new chat option
3. type email id with whom you don’t have any chat history
4. go to chat
5. send message

Expected Result:

senders avatar and name are missing

Actual Result:

should show senders avatar and name

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.14-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-15.at.2.28.37.PM.mov

Bug6057168_2023_05_16_12_00_Img_9496.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan and Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684141166139909

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

This came from #18672
I raised PR to fix

[rushatgabhane]

PR reviewed and merged!

[arosiclair]

Thank you for taking care of this guys!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• prevent grouping created action message #19019

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR: Edit Task Front End #18672
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Edit Task Front End #18672 (comment)
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arosiclair]

I don't think any additional regression tests are needed since Applause caught this

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• prevent grouping created action message #19019

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[stephanieelliott]

I'll had to create an Upwork job manually for payment on this: https://www.upwork.com/jobs/~01d55baf443fdbd072

Seems like @0xmiroslav was C and @rushatgabhane are C+, yeah?

[0xmiros]

@stephanieelliott yes correct. Also qualifies for speed bonus as C+ are also external 🙂

[stephanieelliott]

Hey @0xmiroslav @rushatgabhane I extended the offer to you on Upwork. Please accept when you get a chance and I will issue payment!

[gadhiyamanan]

@stephanieelliott reporting bonus is pending

[rushatgabhane]

@stephanieelliott applied to the job using account "Satish Gabhane" https://www.upwork.com/ab/proposals/1663748952331366401
Thanks!

[stephanieelliott]

@0xmiroslav you're been paid!

@gadhiyamanan and @rushatgabhane I have pending offers for you two, please accept the job on Upwork and I will pay out ASAP. Thanks!

[gadhiyamanan]

@stephanieelliott accepted, thanks!

[rushatgabhane]

accepted, thanks!

[stephanieelliott]

Everyone has been paid! Thank you