Allow all filetypes to be uploaded #18521

youssef-lr · 2023-05-06T06:39:18Z

Details

Fixed Issues

Tests

Verify that no errors appear in the JS console

Helpful for testing: https://file-examples.com/

Test uploading common image filetypes works as expected: jpeg/jpg, png, tiff.
Test that gifs do not lose animation when uploaded.
Test uploading of .webp images works as expected.
Test uploading HEIC/HEIF images display them as links, as we do not currently support converting them neither in App nor in the backend.
Test uploading PDFs display a thumbnail. Test uploading this PDF file which has a mimetype of application/octet-stream works as expected and a thumbnail is displayed.
Test uploading various non image/PDF file works and a link is displayed for them.
Test downloading the uploaded files works as expected.

How HEIC images and links should be displayed:

When uploading images from iOS, including HEIC, they should all be displayed as images as iOS automatically converts them to JPEG.

Offline tests

Not applicable.

QA Steps

Verify that no errors appear in the JS console

Helpful for testing: https://file-examples.com/

Test uploading common image filetypes works as expected: jpeg/jpg, png, tiff.
Test that gifs do not lose animation when uploaded.
Test uploading of .webp images works as expected.
Test uploading HEIC/HEIF images display them as links, as we do not currently support converting them neither in App nor in Web-PDF. Ideally we should create a follow up issue to support this.
Test uploading PDFs display a thumbnail. Test uploading this PDF file which has a mimetype of application/octet-stream works as expected and a thumbnail is displayed.
Test uploading various non image/PDF file works and a link is displayed for them.
Test downloading the uploaded files works as expected.

How HEIC images and links should be displayed:

When uploading images from iOS, including HEIC, they should all be displayed as images as iOS automatically converts them to JPEG.

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-16.at.15.10.41.mov

Mobile Web - Chrome

Mobile Web - Safari

RPReplay_Final1684249237.mov

Desktop

Screen.Recording.2023-05-16.at.15.16.36.mov

iOS

Android

melvin-bot · 2023-05-06T06:39:48Z

@fedirjh @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr · 2023-05-06T06:40:29Z

Woops sorry guys this isn't ready yet.

src/components/AttachmentModal.js

github-actions · 2023-05-16T11:35:50Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

src/languages/es.js

youssef-lr · 2023-05-16T14:19:36Z

Web & desktop screen recordings added. Working on mobile next.

mountiny

Thanks for the updates

mountiny · 2023-05-16T17:14:19Z

@rushatgabhane can you please do that tests and complete the checklist? thanks!

rushatgabhane · 2023-05-16T17:26:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-16.at.22.54.49.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-05-16.at.22.59.30.mov

iOS

Screen.Recording.2023-05-16.at.23.03.18.mov

Android

Screen.Recording.2023-05-16.at.23.06.50.mov

rushatgabhane

@youssef-lr LGMT!

Verified that blacklisted extensions show correct error message.
Verified that large file upload shows correct error message.
Verified that HEIC is converted to JPEG and upload on iOS.
Verified that GIF preserves it's "play" effect.
Verified that password protected PDFs work as expected.
PDF, and Images upload and download as expected.

rushatgabhane · 2023-05-16T17:53:20Z

src/CONST.js

@@ -35,7 +35,62 @@ const CONST = {

    API_ATTACHMENT_VALIDATIONS: {
        // Same as the PHP layer allows
-        ALLOWED_EXTENSIONS: ['webp', 'jpg', 'jpeg', 'png', 'gif', 'pdf', 'html', 'txt', 'rtf', 'doc', 'docx', 'htm', 'tiff', 'tif', 'xml', 'mp3', 'mp4', 'mov'],
+        /* eslint-disable-next-line max-len */
+        UNALLOWED_EXTENSIONS: [


NAB (pls freely ignore) : Is Unallowed even a word? I'd name it as disallowed / blacklisted

Suggested change

UNALLOWED_EXTENSIONS: [

BLACKLISTED_EXTENSIONS: [

Is Unallowed even a word?

Yes it is 😄

I'm gonna go ahead and merge as we really need this live asap.

Disallowed would also work, but we try to stay away from the blacklist/whitelist terms because of racial connotations.

…upload Allow all filetypes to be uploaded (cherry picked from commit d34ed34)

…-18521 🍒 Cherry pick PR #18521 to staging 🍒

OSBotify · 2023-05-16T19:26:27Z

🚀 Cherry-picked to staging by https://github.com/youssef-lr in version: 1.3.14-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-17T00:17:46Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:29:39Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:47:27Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Allow all filetypes to be uploaded

8914ea0

youssef-lr requested a review from a team as a code owner May 6, 2023 06:39

melvin-bot bot removed the request for review from a team May 6, 2023 06:39

melvin-bot bot requested review from fedirjh and neil-marcellini May 6, 2023 06:39

youssef-lr removed request for fedirjh and neil-marcellini May 6, 2023 06:40

youssef-lr marked this pull request as draft May 6, 2023 06:41

youssef-lr self-assigned this May 8, 2023

youssef-lr requested review from flodnv and tgolen May 8, 2023 22:43

youssef-lr marked this pull request as ready for review May 8, 2023 22:43

youssef-lr added the Internal Requires API changes or must be handled by Expensify staff label May 8, 2023

Fix linting

43d95df

tgolen requested changes May 9, 2023

View reviewed changes

src/components/AttachmentModal.js Show resolved Hide resolved

Wip, prevent certain files from being uploaded

22e95bd

youssef-lr added the CP Staging label May 16, 2023

youssef-lr changed the title ~~[HOLD Web-E #37316] Allow all filetypes to be uploaded~~ Allow all filetypes to be uploaded May 16, 2023

mountiny added InternalQA This pull request required internal QA and removed Internal Requires API changes or must be handled by Expensify staff labels May 16, 2023

mountiny requested changes May 16, 2023

View reviewed changes

src/languages/es.js Outdated Show resolved Hide resolved

youssef-lr added 2 commits May 16, 2023 14:32

Update Spanish translation

6c3da98

Update translation

e55d25f

tgolen previously approved these changes May 16, 2023

View reviewed changes

youssef-lr added 2 commits May 16, 2023 15:20

Merge branch 'main' into youssef_allow_all_filetypes_upload

d0b0b30

Prettier

66a996c

youssef-lr dismissed tgolen’s stale review via 66a996c May 16, 2023 14:25

mountiny approved these changes May 16, 2023

View reviewed changes

mountiny requested a review from rushatgabhane May 16, 2023 17:14

rushatgabhane approved these changes May 16, 2023

View reviewed changes

rushatgabhane reviewed May 16, 2023

View reviewed changes

youssef-lr merged commit d34ed34 into main May 16, 2023

youssef-lr deleted the youssef_allow_all_filetypes_upload branch May 16, 2023 17:58

OSBotify pushed a commit that referenced this pull request May 16, 2023

Merge pull request #18521 from Expensify/youssef_allow_all_filetypes_…

5476be8

…upload Allow all filetypes to be uploaded (cherry picked from commit d34ed34)

OSBotify mentioned this pull request May 16, 2023

🍒 Cherry pick PR #18521 to staging 🍒 #19055

Merged

OSBotify added a commit that referenced this pull request May 16, 2023

Merge pull request #19055 from Expensify/OSBotify-cherry-pick-staging…

854f9b2

…-18521 🍒 Cherry pick PR #18521 to staging 🍒

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] [Feature] Support all file types for attachments #11189

Closed

OSBotify mentioned this pull request May 17, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow all filetypes to be uploaded #18521

Allow all filetypes to be uploaded #18521

youssef-lr commented May 6, 2023 •

edited

Loading

melvin-bot bot commented May 6, 2023

youssef-lr commented May 6, 2023

github-actions bot commented May 16, 2023

youssef-lr commented May 16, 2023

mountiny left a comment

mountiny commented May 16, 2023

rushatgabhane commented May 16, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 16, 2023 •

edited

Loading

youssef-lr May 16, 2023

tgolen May 17, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Allow all filetypes to be uploaded #18521

Allow all filetypes to be uploaded #18521

Conversation

youssef-lr commented May 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 6, 2023

youssef-lr commented May 6, 2023

github-actions bot commented May 16, 2023

youssef-lr commented May 16, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented May 16, 2023

rushatgabhane commented May 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane May 16, 2023 • edited Loading

Choose a reason for hiding this comment

youssef-lr May 16, 2023

Choose a reason for hiding this comment

tgolen May 17, 2023

Choose a reason for hiding this comment

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

youssef-lr commented May 6, 2023 •

edited

Loading

rushatgabhane commented May 16, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 16, 2023 •

edited

Loading