[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] [Feature] Support all file types for attachments

[JmillsExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Try to upload a CSV, XLSX, HEIF or HEFV image. None of them work!

Expected Result:

We should support all file types, especially since we have an antivirus scanner handling all attachments.

Actual Result:

The upload files with the following error message.

Workaround:

No workarounds

Platform:

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): Everyone
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663790246088889

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kevinksullivan]

https://www.upwork.com/jobs/~011d5256eaf415611d

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Current assignee @neil-marcellini is eligible for the Engineering assigner, not assigning anyone new.

[neil-marcellini]

Hmm is this a front end only error? What do you think @Santhosh-Sellavel?

[Santhosh-Sellavel]

@neil-marcellini

We have frontend restrictions but could be a backend too as per this comment

App/src/CONST.js

Lines 16 to 18 in 3780e0f

	// Same as the PHP layer allows
	ALLOWED_EXTENSIONS: ['jpg', 'jpeg', 'png', 'gif', 'pdf', 'html', 'txt', 'rtf', 'doc', 'docx', 'htm', 'tiff', 'tif', 'xml', 'mp3', 'mp4', 'mov'],

[neil-marcellini]

Thanks for looking into that! I think we should make this internal since I imagine most of the work will be on the backend.

[JmillsExpensify]

The timing for this is super tight so I'm going to add the daily label back as well.

[youssef-lr]

Draft PRs created and it's working nicely for me locally. PRs should be ready for review on Monday!

[rushatgabhane]

PR reviewed and merged!! 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow all filetypes to be uploaded #18521

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow all filetypes to be uploaded #18521

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[JmillsExpensify]

@youssef-lr quick question on this issue: Should it still be open?

[JmillsExpensify]

Further, @rushatgabhane have been paid you out for this one? I see you reviewed one of the linked PRs.

[youssef-lr]

I think we can close!

[JmillsExpensify]

Alrighty!

[JmillsExpensify]

@rushatgabhane please reach out over New Expensify if anything remains outstanding for you.

[anmurali]

I paid Rushat on New Dot

[JmillsExpensify]

Thanks!