[hold for https://github.com/Expensify/Web-Expensify/pull/38169] Chat - Unexpected error message when trying to upload a CSV file

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open iOS/Android/Desktop App or navigate to staging.new.expensify.com
2. Login with any account
3. Go to any conversation
4. Select ''+'' button > Add attachment
5. Send an CSV file

Expected Result:

The user should be able to upload and send a CSV file without errors

Actual Result:

When attempting to send a CSV file, the app returns an error message stating that the attachment is invalid

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.40.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6127163_Desktop_app_-_CSV_file.mp4

Expensify/Expensify Issue URL:

Issue reported by: Aplause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d938cefb22022fc
• Upwork Job ID: 1679935282985816064
• Last Price Increase: 2023-07-14

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Unexpected error message when trying to upload a CSV file

What is the root cause of that problem?

We're not allowing csv file from backend, as the backend responded it's "Invalid attachment file":

What changes do you think we should make in order to solve the problem?

Incase we want it consistent with the backend, we can add 'csv' as a unallowed extension here

What alternative solutions did you explore? (Optional)

N/A

[joekaufmanexpensify]

I can reproduce on web. This seems like maybe it's a regression, as I see @youssef-lr had previously worked on an issue here, where I see we added support for CSVs.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014d938cefb22022fc

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

[youssef-lr]

We merged a PR in the backend that should fix this.

[joekaufmanexpensify]

Ah okay cool. @youssef-lr mind linking the PR here so I can take a look?

[youssef-lr]

Here you go @joekaufmanexpensify https://github.com/Expensify/Web-Expensify/pull/38169

[joekaufmanexpensify]

Sounds great, thanks! I'll leave this open for now. Then, once that PR is deployed, I'll verify that it did in fact fix this bug, and then close out the issue, if so.

[joekaufmanexpensify]

I see the above PR was deployed. Just tested this on my end, and this bug is now fixed. Closing as this is all set!