[HOLD for payment 2023-05-03] [$1000] Screen is shaking when scrolling while user edit a comment between 2 tabs.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a new report, try to send few message (Make sure the content of the message has over 15 lines), open that report in another tab.
2. From the first tab, try to edit a multiple lines message, make sure the content is scrollable.
3. From the second tab, delete all the content of that message, return the first tab try to scroll to bottom few times.
4. Notice that screen is shaking while scrolling.

Expected Result:

User should scroll to bottom without any issue.

Actual Result:

Screen is shaking while scrolling.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-04.at.18.21.16.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680608255498089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4cdb2f5c5e79041
• Upwork Job ID: 1645761324986847232
• Last Price Increase: 2023-04-18

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

I''m finding this one pretty hard to reproduce based on the instructions above - @kavimuru @hungvu193 can you break this down a bit further? Thanks

[hungvu193]

@laurenreidexpensify I think I can give you more information here.

• Try to create a new conversation
• Make sure the content of the edit message has over 15 lines after that try to scroll to the bottom, you will see

Screen.Recording.2023-04-09.at.22.09.59.mov

[MelvinBot]

@laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c4cdb2f5c5e79041

[MelvinBot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[laurenreidexpensify]

Thanks @hungvu193

[aldo-expensify]

I'm having problems reproducing too

@hungvu193 can you copy and paste here what you typed in the input to reproduce?

[hungvu193]

@aldo-expensify
you can try this one:

[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
https://staging.new.expensify.com/r/6006786908332036
https://staging.new.expensify.com/r/6006786908332036
https://staging.new.expensify.com/r/6006786908332036
https://staging.new.expensify.com/r/6006786908332036
https://staging.new.expensify.com/r/6006786908332036

And the evidence for latest staging:

Screen.Recording.2023-04-13.at.09.42.43.mov

[aldo-expensify]

Thanks @hungvu193 , I'm still unable to reproduce :(. Do you use your mouse wheel to scroll? or the track pad? or something else?

Is this consistently happening for you? or you get it after trying many times?

Trying to reproduce

Screen.Recording.2023-04-13.at.9.46.28.AM.mov

[hungvu193]

@aldo-expensify I can reproduce everytime, I'm using mac touchpad.
Can you try these steps and let me know if it works?

1. Go to new report.
2. Chat 3,4 messages.
3. Send a very long message, just to make sure content of edit message is scrollable, like this:

[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)
[https://staging.new.expensify.com/r/6006786908332036](https://staging.new.expensify.com/r/6006786908332036)

4. Edit the message, delete all the content but don't save, now open that report in another tab.
5. Scroll inside your edit message then scroll outside.

Screen.Recording.2023-04-14.at.10.06.08.mov

[aldo-expensify]

@hungvu193 ahh thanks, now I reproduced it. I had completely missed the stuff about using 2 tabs 🤦

[hungvu193]

@s77rt Yeah, It's no longer be reproducible with latest main.

Screen.Recording.2023-04-24.at.16.26.10.mov

@hungvu193 Can you please test and confirm the bug reported here #16931 (comment) will no longer be reproducible?

[thesahindia]

Do you think we can remove it now?

Yeah, it can be removed.

[Pujan92]

@Pujan92 @thesahindia a confirmation please on #16931 (comment)

Yes, as it is not producible after navigation reboot then we can remove it.

[s77rt]

@thesahindia @Pujan92 Thank you!

[s77rt]

@hungvu193 Thanks once again for your proposal and for the follow up 👍. Let's go with your suggested fix option 2 (remove numberOfLines and onNumberOfLinesChange from ReportActionItemMessageEdit).

🎀 👀 🎀 C+ reviewed

cc @aldo-expensify

[aldo-expensify]

Thanks for the thorough investigation! I agree with removing this stuff if it is no longer needed and adds unnecessary complexity + bugs.

[MelvinBot]

📣 @hungvu193 You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hungvu193]

Thanks guys, PR (#17899) is ready @s77rt @aldo-expensify

[laurenreidexpensify]

Offers sent in Upwork for @hungvu193 and @s77rt

[hungvu193]

@laurenreidexpensify Thank you. I've just applied

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix screen shaking when editing between 2 tabs #17899

If no regressions arise, payment will be issued on 2023-05-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/280594

[s77rt]

• The PR that introduced the bug has been identified: composer set correct numberOfLines on intitial render #15296
• The offending PR has been commented on: composer set correct numberOfLines on intitial render #15296 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1682504657797639
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal (Web Only)

1. Login to NewDot in 2 tabs
2. Open same chat in both tabs (chat must be scrollable i.e. have previous messages)
3. Tab 1: Send a long multiline message e.g. 25 lines
4. Tab 1: Edit the message: delete the content but do not press the 'Save' button
5. Tab 2: Verify the message is in edit mode
6. Tab 2: Verify the message content is not cleared
7. Tab 2: Scroll inside the edit message
8. Tab 2: Scroll outside the edit message
9. Tab 2: Verify that you were able to scroll smoothly

[laurenreidexpensify]

great work everyone!