[HOLD for payment 2023-10-24] [$2000] There is a delay of 1-2 seconds when a new workspace is created in the Android app.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the "Settings" of the app.
2. Tap on "Workspaces".
3. Select "New workspace".
   Notice the app almost freezes when the "New workspace" button is pressed for couple of seconds.

Expected Result

There should not be any delay, and the app should function smoothly like web.

Actual Result

The app freezes or experiences a delay of 1-2 seconds when the "New workspace" button is pressed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native Offline and Online
• Android / Chrome Offline and Online
• iOS / native Offline and Online
• iOS / Safari Offline and Online
• MacOS / Chrome / Safari Offline and Online
• MacOS / Desktop Offline and Online

Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.2.mp4

az_recorder_20230404_142437.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680610152510499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174b5420e1b80f716
• Upwork Job ID: 1645860223341436928
• Last Price Increase: 2023-09-21
• Automatic offers:
• s77rt | Reviewer | 27148524

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[NicMendonca]

@usmantariq96 I tested this on a pixel 6 pro, and my delay isn't as slow as in your video. I agree there is a 0.5 second delay, and not as quick as web, but I wonder if hardware matters here?

[NicMendonca]

assigning @Christinadobrzyn to watch over this while I am OOO!

[usmantariq96]

I am not sure, tested it on Realme 3.

[MelvinBot]

📣 @usmantariq96! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Christinadobrzyn]

I can replicate this in all our platforms some of the platforms have less of a delay than others (from what I can generally tell). I wonder if this is an expected behaviour. Asking the team here - 291788

[Christinadobrzyn]

Puneet mentioned this might be part of a bigger API command update. Not sure if this should be closed in favour of a different GH

cc @iwiznia @flodnv

[MelvinBot]

@NicMendonca, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Based on this convo - https://expensify.slack.com/archives/C049HHMV9SM/p1681225595834389?thread_ts=1680610152.510499&cid=C049HHMV9SM

Testing this offline has the same delayed behaviour when creating a workspace. So going to add the external label for some help on this.

[MelvinBot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[MelvinBot]

Current assignees @NicMendonca and @Christinadobrzyn are eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0174b5420e1b80f716

[MelvinBot]

Current assignees @NicMendonca and @Christinadobrzyn are eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @usmantariq96 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [#16935] Workspace creation with Policy Draft info #29256

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)
• @s77rt requires payment offer (Reviewer)
• @usmantariq96 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/330237

[s77rt]

• The PR that introduced the bug has been identified: I think this existed for a while that there is no specific PR that caused the lag but it was due to the App getting bigger and adding more onyx subscriptions for workspaces.
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: i think we had few threads regarding this issue already. Nothing that we can add to the checklist here
• Determine if we should create a regression test for this bug: I'm not sure if we add regression tests for performance related issues. cc @Christinadobrzyn

[Christinadobrzyn]

Asking QA about a regression test for this - https://expensify.slack.com/archives/C9YU7BX5M/p1698170976258769

they said:

We don't have performance regression tests atm. We ask our testers to report any noticeable performance issue when executing the regression tests.

After checking the issue - I think we can give the tester team more details on how much should actions take in NewDot. So, for example: Report any actions in NewDot that take more than 0.5s (or whatever number should be used - 0.5s is an example).

Do you think you could write up a regression test step like that @s77rt?

[s77rt]

Regression Test Proposal

1. Go to Settings > Workspaces
2. Press New workspace button
3. Verify you are redirected to the workspace page instantly (action should take no more than 1 sec)

cc @Christinadobrzyn

[Christinadobrzyn]

Thanks @s77rt! Created regression test GH

Payouts due based on old payment structure:

Issue Reporter: $250 @usmantariq96 (paid in Upwork)
Contributor: $2000 + $1000 speed bonus @gedu (contractor - not paid in Upwork)
Contributor+: $2000 + $1000 speed bonus @s77rt (paid in Upwork)

Eligible for 50% #urgency bonus? Yes, based on #16935 (comment)

@s77rt upwork job is here - payment sent
@usmantariq96 upwork job is here - can you please apply to it?

[usmantariq96]

@Christinadobrzyn applied.
Thanks

[Christinadobrzyn]

Awesome! Thanks @usmantariq96 - I paid you through Upwork.

It looks like there's some additional communication in the PR #29256

Do we need to keep this open?

[s77rt]

@Christinadobrzyn I think urgency bonus may still apply here. @gedu was assigned on Oct 11th at 8:58pm. PR was merged on Oct 16th at 7:52pm. This is still within the 3 business days period with 14th and 15th excluded (weekend).

As for the communication in the PR, it's not something that we would keep the issue open for. It can be closed.

[Christinadobrzyn]

Ah yes, thank you for catching that @s77rt! The speed bonus is '3 business days' not just 3 days.

I added a bonus to the payment schedule (I paid you the bonus through Upwork)- #16935 (comment)

closing this!