[HOLD for payment 2023-05-23] [$1000] Chat - The cursor absent in the chat input field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Login with any account
3. Open any different chats one by one

Expected Result:

The cursor present in input field.

Actual Result:

The cursor is sometimes present, but in most cases absent in the chat input field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.97.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Record_2023-04-08-19-28-32_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ec7a699a5894775
• Upwork Job ID: 1645416218945282048
• Last Price Increase: 2023-05-02

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010ec7a699a5894775

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[0xmiros]

@kbecciv @bfitzexpensify what is "chat input field"? I checked video but it's mainly focusing on IOU amount input.

[kbecciv]

@0xmiroslav This is composed box

[0xmiros]

@0xmiroslav This is composed box

@kbecciv you mean around 12s-14s in video?

[kbecciv]

@0xmiroslav
Very very sorry, I attached a wrong video, just added a new one. The input field was missing on 7s -8s on video.

[vladbogza123]

Proposal

What is the root cause of that problem?

The issue here is that the keyboard does not pop up on a chat input when clicking around to different chats. We get the functionality sometimes because IOS or Android can auto-highlight an input.

What changes do you think we should make in order to solve the problem?

Add a piece of logic that highlights each input in each chat. That way the keyboard pops up each time.

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[ericsonrd]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor behavior is not consistent across native and mWeb. It shouldn’t show up on non-empty chats.

What is the root cause of that problem?

The <Composer> component logic pretty much ensures the input is auto-focused all the time. In native platforms, autofocus behave a differently and the provided logic doesn’t fully apply, thus no auto-focusing when chat is not empty on native.

What changes do you think we should make in order to solve the problem?

A small modification to the autofocus logic should be added leaving out instances where the chat is not empty. This solution doesn’t involve reverting #14230. This modification should be done:

autoFocus={!this.props.modal.isVisible && (this.willBlurTextInputOnTapOutside && this.isEmptyChat() || this.isEmptyChat())}

What alternative solutions did you explore?

n/a

Results

• Android Native:

  chatInput720android.mov

• Android mWeb:

  chatInput720mWeb.mov

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[MelvinBot]

📣 @vladbogza! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vladbogza123]

Contributor details
Your Expensify account email: vladimirbogza@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0117583cb41393c914

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[0xmiros]

This is expected behavior.
This can be issue only when chat is empty but cursor absent.
@kbecciv your video shows that most reports are not empty (enough message history) and it's expected that cursor is absent.

[flodnv]

Why isn't the automation working?

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 You have been assigned to this job by @flodnv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Current assignee @flodnv is eligible for the External assigner, not assigning anyone new.

[dukenv0307]

@0xmiroslav @flodnv The PR is ready to review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Auto focus on mWeb when open report with enough chat history #18699

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

All payments issued. @0xmiroslav please complete the BugZero checklist #17187 (comment) - thanks!

[0xmiros]

• The PR that introduced the bug has been identified. Link to the PR: Fix mWeb Compose Focus bug #14230
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/14230/files#r1205230193
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should have been caught during PR review.

This was caught by Applause team so no further regression test step is needed.

• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[bfitzexpensify]

Great, let's close this out. Thanks for the work here everyone!