Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] System launches keyboard every time a user makes a selection on ‘Inivite new memebers’ section, forcing the user to close the keyboard every time the user wants to make further selections #17193

Closed
1 of 6 tasks
kavimuru opened this issue Apr 9, 2023 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Apr 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on ‘profile’ avatar
  2. Click on ‘Workspaces’ link
  3. Open an existing ‘Workspace’
  4. Click on ‘Manage members’ link
  5. Click on ‘Invite’ button
  6. Click on search bar to bring focus to the search bar
  7. Close the launched keyboard
  8. Make a selection
  9. Observe that keyboard is lauchned
  10. Close the keyboard, and repeat step 8 to step 10
  11. Observe that keyboard is launched everytime when making selection or deselection

Expected Result:

Keyboard should remain closed when the user is making a selection or deselection

Actual Result:

Keyboard is launched every time user makes a selection or deselection, forcing the user to close the keyboard multiple time to make further selections

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

video_2023-04-08_10-51-02.mp4
az_recorder_20230408_211414.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680941415147559

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0133771c67cde4613b
  • Upwork Job ID: 1648735513710501888
  • Last Price Increase: 2023-04-19
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 9, 2023
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stephanieelliott stephanieelliott added the Needs Reproduction Reproducible steps needed label Apr 10, 2023
@stephanieelliott
Copy link
Contributor

Adding Needs Reproduction label as I am unable to test this on Android

@Natnael-Guchima
Copy link

Natnael-Guchima commented Apr 11, 2023

@stephanieelliott It works fine on Android. The issue is only observable on mobile web Chrome.

@melvin-bot melvin-bot bot added the Overdue label Apr 13, 2023
@stephanieelliott
Copy link
Contributor

Hm, I'm not able to repro it on iOS mweb Chrome. So it sounds like it is isolated only to Android mweb Chrome. Are you saying that you are able to repro it on Android mweb Chrome @Natnael-Guchima?

@melvin-bot melvin-bot bot removed the Overdue label Apr 13, 2023
@Natnael-Guchima
Copy link

Natnael-Guchima commented Apr 13, 2023

Hm, I'm not able to repro it on iOS mweb Chrome. So it sounds like it is isolated only to Android mweb Chrome. Are you saying that you are able to repro it on Android mweb Chrome @Natnael-Guchima?

XRecorder_13042023_194103.mp4

Screenshot_20230413-194619.jpg

Yes, the issue might be contained to Android mWeb. I am able to reproduce it on Android web Chrome @stephanieelliott . When you select members makes sure that the focus is maintained on the search bar. That might be it that made it hard to reproduce.

Can you send me a video recording of you trying to reproduce the issue, so that I might see if there is a difference in the reproduction step we are following?

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@MelvinBot
Copy link

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott stephanieelliott removed the Needs Reproduction Reproducible steps needed label Apr 18, 2023
@stephanieelliott
Copy link
Contributor

Ah ok I see now, thanks for the video. Now that I understand I don't think this is a bug. Keeping focus on the keyboard assumes you are preparing to type something -- I would expect the keyboard to launch each time focus is returned to the search bar.

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2023
@Natnael-Guchima
Copy link

Ah ok I see now, thanks for the video. Now that I understand I don't think this is a bug. Keeping focus on the keyboard assumes you are preparing to type something -- I would expect the keyboard to launch each time focus is returned to the search bar.

Hmmm, but it is not consistent on Android and mWeb - on mobile web Chrome it launches the keyboard and on Android it doesn't.

screen-20230418-201733.mp4

@stephanieelliott
Copy link
Contributor

Thanks for bearing with me, @Natnael-Guchima! For context, I’m digging into the behavior across platforms because I suspected the behavior could be related to nuances between keyboard settings, and is also somewhat low-value or better suited for a polish phase.

However, I agree that the behavior should at least be consistent between platforms and the Android case does look sorta janky. Gonna go ahead and put labels on this to move this forward.

@stephanieelliott stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Apr 19, 2023
@melvin-bot melvin-bot bot changed the title System launches keyboard every time a user makes a selection on ‘Inivite new memebers’ section, forcing the user to close the keyboard every time the user wants to make further selections [$1000] System launches keyboard every time a user makes a selection on ‘Inivite new memebers’ section, forcing the user to close the keyboard every time the user wants to make further selections Apr 19, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0133771c67cde4613b

@MelvinBot
Copy link

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 19, 2023
@MelvinBot
Copy link

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Natnael-Guchima
Copy link

Thanks for bearing with me, @Natnael-Guchima! For context, I’m digging into the behavior across platforms because I suspected the behavior could be related to nuances between keyboard settings, and is also somewhat low-value or better suited for a polish phase.

However, I agree that the behavior should at least be consistent between platforms and the Android case does look sorta janky. Gonna go ahead and put labels on this to move this forward.

No problem. Yes, let's see if we can come across a consistent, expected behavior for this issue that can be worth pursuing. If we can't we can close this issue and move on.

@MelvinBot
Copy link

@mananjadhav @pecanoro @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2023
@pecanoro
Copy link
Contributor

I can't reproduce this on my pixel 7 using the last version on staging. The keyboard is never launched when I click on the members so I am going to close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants