-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] System launches keyboard every time a user makes a selection on ‘Inivite new memebers’ section, forcing the user to close the keyboard every time the user wants to make further selections #17193
Comments
Triggered auto assignment to @stephanieelliott ( |
Bug0 Triage Checklist (Main S/O)
|
Adding |
@stephanieelliott It works fine on Android. The issue is only observable on mobile web Chrome. |
Hm, I'm not able to repro it on iOS mweb Chrome. So it sounds like it is isolated only to Android mweb Chrome. Are you saying that you are able to repro it on Android mweb Chrome @Natnael-Guchima? |
XRecorder_13042023_194103.mp4Yes, the issue might be contained to Android mWeb. I am able to reproduce it on Android web Chrome @stephanieelliott . When you select members makes sure that the focus is maintained on the search bar. That might be it that made it hard to reproduce. Can you send me a video recording of you trying to reproduce the issue, so that I might see if there is a difference in the reproduction step we are following? |
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Ah ok I see now, thanks for the video. Now that I understand I don't think this is a bug. Keeping focus on the keyboard assumes you are preparing to type something -- I would expect the keyboard to launch each time focus is returned to the search bar. |
Hmmm, but it is not consistent on Android and mWeb - on mobile web Chrome it launches the keyboard and on Android it doesn't. screen-20230418-201733.mp4 |
Thanks for bearing with me, @Natnael-Guchima! For context, I’m digging into the behavior across platforms because I suspected the behavior could be related to nuances between keyboard settings, and is also somewhat low-value or better suited for a polish phase. However, I agree that the behavior should at least be consistent between platforms and the Android case does look sorta janky. Gonna go ahead and put labels on this to move this forward. |
Job added to Upwork: https://www.upwork.com/jobs/~0133771c67cde4613b |
Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @pecanoro ( |
No problem. Yes, let's see if we can come across a consistent, expected behavior for this issue that can be worth pursuing. If we can't we can close this issue and move on. |
@mananjadhav @pecanoro @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
I can't reproduce this on my pixel 7 using the last version on staging. The keyboard is never launched when I click on the members so I am going to close it! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Keyboard should remain closed when the user is making a selection or deselection
Actual Result:
Keyboard is launched every time user makes a selection or deselection, forcing the user to close the keyboard multiple time to make further selections
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
video_2023-04-08_10-51-02.mp4
az_recorder_20230408_211414.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680941415147559
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: