[HOLD for payment 2023-06-29] [$1000] Keyboard is popping up everytime user selects a contact when creating a new group #20636

kavimuru · 2023-06-12T23:51:45Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on FAB
Click on "New group"
Select a contact
Hide the keyboard
Select another contact

Expected Result:

Keyboard should not popup every time user selects a new contact as this behavior is not seen on Android app

Actual Result:

Keyboard pops up every time user selects a new contact

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.26-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230607_183004_Chrome.mp4

az_recorder_20230612_194921.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686153010639509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0100b196cb7f4e7c43
Upwork Job ID: 1668689630840729600
Last Price Increase: 2023-06-13

melvin-bot · 2023-06-12T23:51:49Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-12T23:51:51Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

huzaifa-99 · 2023-06-13T02:00:35Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to prevent the keyboard from opening up on every option selected in new group creation

What is the root cause of that problem?

We are passing shouldFocusOnSelectRow as true in case of group chats to OptionsSelector in NewChatPage which is causing refocus on the text input and opening the keyboard

What changes do you think we should make in order to solve the problem?

We should remove shouldFocusOnSelectRow from OptionsSelector in NewChatpage

<OptionsSelector
    // shouldFocusOnSelectRow={this.props.isGroupChat} - remove this
    // ... other code
/>

The WorkspaceInvitePage has the same issue which we can also fix by not passing shouldFocusOnSelectRow prop.

Alternatively, if we want to keep the focus on the input field on desktop web but not on mobile web, then we can only add shouldFocusOnSelectRow for mobile platform and when we are creating a group chat, something like this

shouldFocusOnSelectRow={this.props.isGroupChat && !Browser.isMobile()}

What alternative solutions did you explore? (Optional)

N/A

joekaufmanexpensify · 2023-06-13T18:36:49Z

Reproduced on Android mobile web. Also confirmed we don't do this on android native, or iOS native. I agree we should not open the keyboard every time a new contact is selected.

2023-06-13_14-34-48.mp4

melvin-bot · 2023-06-13T18:39:47Z

Job added to Upwork: https://www.upwork.com/jobs/~0100b196cb7f4e7c43

melvin-bot · 2023-06-13T18:39:50Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-13T18:39:56Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

melvin-bot · 2023-06-13T18:40:01Z

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Santhosh-Sellavel · 2023-06-13T21:57:51Z

@huzaifa-99 you mean !Browser.isMobile() right?

Santhosh-Sellavel · 2023-06-13T22:02:17Z

@marcaaron @huzaifa-99's proposal looks good to me.
🎀 👀 🎀
C+ Reviewed

huzaifa-99 · 2023-06-13T22:05:02Z

@huzaifa-99 you mean !Browser.isMobile() right?

yes, thanks for spotting

huzaifa-99 · 2023-06-13T22:05:19Z

@marcaaron @huzaifa-99's proposal looks good to me. 🎀 👀 🎀 C+ Reviewed

Thank you for the review

marcaaron · 2023-06-13T22:49:52Z

if we want to keep the focus on the input field on desktop web but not on mobile web, then we can only add shouldFocusOnSelectRow for mobile platform and when we are creating a group chat, something like this

I think we do. If that's the current behavior we should not change it. So that would be the alternate proposal in this case?

@Santhosh-Sellavel you may have implied with your previous question that the alternative proposal is what we want - though, not sure. In the future, try make it clear whether you are recommending the main proposal or anything from the alternate proposal. Thank you 🙇

melvin-bot · 2023-06-13T22:50:01Z

📣 @huzaifa-99 You have been assigned to this job by @marcaaron!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

huzaifa-99 · 2023-06-13T22:59:38Z

if we want to keep the focus on the input field on desktop web but not on mobile web, then we can only add shouldFocusOnSelectRow for mobile platform and when we are creating a group chat, something like this

I think we do. If that's the current behavior we should not change it. So that would be the alternate proposal in this case?

@Santhosh-Sellavel you may have implied with your previous question that the alternative proposal is what we want - though, not sure. In the future, try make it clear whether you are recommending the main proposal or anything from the alternate proposal. Thank you 🙇

Thanks for the feedback, yes keeping focusing on desktop and not on web would be the alternate proposal. Pr will be up soon

huzaifa-99 · 2023-06-14T00:34:20Z

@Santhosh-Sellavel @marcaaron PR up for review #20731

melvin-bot · 2023-06-16T18:55:12Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @huzaifa-99 got assigned: 2023-06-13 22:50:01 Z
when the PR got merged: 2023-06-16 18:55:11 UTC
days elapsed: 3

On to the next one 🚀

Santhosh-Sellavel · 2023-06-16T19:02:31Z

@joekaufmanexpensify It got merged within 3 biz days. Melvin is confused here.

Natnael-Guchima · 2023-06-26T13:40:29Z

@Natnael-Guchima I'd say no. We closed the issue you reported because we were not able to reproduce it. Whereas the bug in this issue was consistently reproducible, which is why we took action here.

Given the behavior you reported was not consistently reproducible, we wouldn't issue a reporting bonus for it.

@joekaufmanexpensify If you saw my conversations with @stephanieelliott you can see I have been reproducing the issue consistently and I have been providing a clear steps to reproduce the issue. There are 4 videos reproducing the issue perfectly on the closed GH. If you are convinced that the steps were not clear on the action performed section, it is alright.

huzaifa-99 · 2023-06-26T14:08:13Z

@huzaifa-99 offer sent for $1,000! ($500 will be issued as bonus)

Accepted, Thank you!

Santhosh-Sellavel · 2023-06-26T20:13:50Z

@joekaufmanexpensify I will get done with the checklist this week. Regarding payment I'm just waiting for the internal process, please check here

joekaufmanexpensify · 2023-06-28T19:27:50Z

Sounds good, thanks!

joekaufmanexpensify · 2023-06-28T21:57:50Z

@Santhosh-Sellavel we are all set to test your payment. Could you please complete your portion of the BZ checklist, and then I'll post new steps for payment in Slack.

Santhosh-Sellavel · 2023-06-29T17:06:34Z

Pinged you on a Slack thread about payment. Caught up on other priority items, I'll complete the checklist this week in a day or two!

joekaufmanexpensify · 2023-06-29T18:35:17Z

Sounds good! As soon as the BZ checklist is complete, we'll issue the payments on this issue (besides yours, which is held for the new process).

Santhosh-Sellavel · 2023-07-02T22:00:57Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: This was untouched for a long time Standardize arrow navigation in OptionsLists #7702

[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/7702/files#r1249819025

[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This could be caught with our existing checklist so we are good here!

[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. Not sure whether worth adding it

[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Steps here we decide to add so

[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once the above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/297223

cc: @marcaaron Let me know if you differ on any of the above. What do you think about adding regression tests here?

Santhosh-Sellavel · 2023-07-02T22:01:25Z

Regression Steps

Go to the new chat page from the fab icon
In desktop/web Verify if the search input is focused then it should remain focused when any member is selected.
In native & mWeb, Verify that selecting a member is not focusing on the search input again.
Follow steps 2 and 3 for the workspace invite member page.

👍 or 👎

marcaaron · 2023-07-03T21:43:00Z

Verify that selecting a member is not focusing on the search input again.

I would rephrase this like:

Verify if the search input is focused then it should lose focus when any member is selected.

But otherwise 👍

Nathan-Mulugeta · 2023-07-04T04:07:02Z

Hey guys payment has not been processed for this issue. @joekaufmanexpensify

huzaifa-99 · 2023-07-05T12:31:25Z

Hey guys payment has not been processed for this issue. @joekaufmanexpensify

bump ^

joekaufmanexpensify · 2023-07-05T12:40:33Z

Thanks! I was OOO the past two days, and previously we were waiting for the BZ checklist to be completed (which is required before we issue payments). I will finish this up and issue payment today.

joekaufmanexpensify · 2023-07-05T13:07:00Z

Added regressions test issue above. Only change I made is that I made step 1 specific to new group, rather than new chat as I think new chat was a typo (given this issue only applies when there is the ability to select multiple invitees).

joekaufmanexpensify · 2023-07-05T13:07:11Z

BZ checklist is now complete! All set to issue payment.

joekaufmanexpensify · 2023-07-05T13:09:15Z

@huzaifa-99 $1,500 sent and contract ended!

joekaufmanexpensify · 2023-07-05T13:13:47Z

@Nathan-Mulugeta $250 sent and contract ended!

joekaufmanexpensify · 2023-07-05T13:13:53Z

Upwork job closed.

joekaufmanexpensify · 2023-07-05T13:14:13Z

This one is all set, besides paying @Santhosh-Sellavel, which is on hold for the new payment process.

huzaifa-99 · 2023-07-05T13:15:24Z

@joekaufmanexpensify TYSM, also apologies I didn't knew you were OOO.

joekaufmanexpensify · 2023-07-05T13:17:44Z

Of course, and no worries at all!

joekaufmanexpensify · 2023-07-06T16:17:47Z

Still held on paying Santhosh

anmurali · 2023-07-07T11:53:57Z

Santhosh has been paid on New Dot

joekaufmanexpensify · 2023-07-07T12:40:52Z

Great, thanks!

joekaufmanexpensify · 2023-07-07T12:41:27Z

@Santhosh-Sellavel closing for now as payment has been issued. LMK if there are any issues receiving it!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2023

melvin-bot bot assigned joekaufmanexpensify Jun 12, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2023

melvin-bot bot changed the title ~~Keyboard is popping up everytime user selects a contact when creating a new group~~ [$1000] Keyboard is popping up everytime user selects a contact when creating a new group Jun 13, 2023

melvin-bot bot assigned Santhosh-Sellavel Jun 13, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2023

melvin-bot bot assigned marcaaron Jun 13, 2023

marcaaron assigned huzaifa-99 Jun 13, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2023

huzaifa-99 mentioned this issue Jun 14, 2023

Fix Keyboard popping up when member selected in new group page or in workspace invite page #20731

Merged

57 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jun 14, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 28, 2023

Santhosh-Sellavel mentioned this issue Jul 2, 2023

Standardize arrow navigation in OptionsLists #7702

Merged

20 tasks

joekaufmanexpensify closed this as completed Jul 7, 2023

mollfpr mentioned this issue Jul 13, 2023

[$1000] Keyboard closes while selecting members on invite page on mWeb vs keyboard stays open on android #22510

Closed

6 tasks

[HOLD for payment 2023-06-29] [$1000] Keyboard is popping up everytime user selects a contact when creating a new group #20636

[HOLD for payment 2023-06-29] [$1000] Keyboard is popping up everytime user selects a contact when creating a new group #20636

Comments

kavimuru commented Jun 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 12, 2023

melvin-bot bot commented Jun 12, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

huzaifa-99 commented Jun 13, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented Jun 13, 2023

melvin-bot bot commented Jun 13, 2023

melvin-bot bot commented Jun 13, 2023

melvin-bot bot commented Jun 13, 2023

melvin-bot bot commented Jun 13, 2023

Santhosh-Sellavel commented Jun 13, 2023

Santhosh-Sellavel commented Jun 13, 2023

huzaifa-99 commented Jun 13, 2023 • edited Loading

huzaifa-99 commented Jun 13, 2023

marcaaron commented Jun 13, 2023

melvin-bot bot commented Jun 13, 2023

huzaifa-99 commented Jun 13, 2023

huzaifa-99 commented Jun 14, 2023

melvin-bot bot commented Jun 16, 2023

Santhosh-Sellavel commented Jun 16, 2023

Natnael-Guchima commented Jun 26, 2023 • edited Loading

huzaifa-99 commented Jun 26, 2023

Santhosh-Sellavel commented Jun 26, 2023

joekaufmanexpensify commented Jun 28, 2023

joekaufmanexpensify commented Jun 28, 2023

Santhosh-Sellavel commented Jun 29, 2023

joekaufmanexpensify commented Jun 29, 2023

Santhosh-Sellavel commented Jul 2, 2023 • edited by joekaufmanexpensify Loading

Santhosh-Sellavel commented Jul 2, 2023 • edited Loading

Regression Steps

marcaaron commented Jul 3, 2023

Nathan-Mulugeta commented Jul 4, 2023

huzaifa-99 commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023 • edited Loading

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

huzaifa-99 commented Jul 5, 2023

joekaufmanexpensify commented Jul 5, 2023

joekaufmanexpensify commented Jul 6, 2023

anmurali commented Jul 7, 2023

joekaufmanexpensify commented Jul 7, 2023

joekaufmanexpensify commented Jul 7, 2023

kavimuru commented Jun 12, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 12, 2023 •

edited by joekaufmanexpensify

Loading

huzaifa-99 commented Jun 13, 2023 •

edited

Loading

huzaifa-99 commented Jun 13, 2023 •

edited

Loading

Natnael-Guchima commented Jun 26, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 2, 2023 •

edited by joekaufmanexpensify

Loading

Santhosh-Sellavel commented Jul 2, 2023 •

edited

Loading

joekaufmanexpensify commented Jul 5, 2023 •

edited

Loading