[HOLD for payment 2023-04-26] [HOLD for payment 2023-04-24] Web - Chat - Typing from emoji picker also fills composer input unnecessarily

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Right click any message
3. Click "Add reaction" icon
4. Click "Change default skin tone" on emoji picker
5. Type anything

Expected Result:

Emoji picker search input is filled and composer input is not filled

Actual Result:

Both emoji picker search input and composer input are filled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.0.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

bug.mov

Recording.2489.mp4

Expensify/Expensify Issue URL:

Issue reported by:@situchan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681367247044099

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

@kbecciv this doesn't happen on production so deploy blocker

[PauloGasparSv]

Assigning myself here, will try to fix this!

That bug was introduced here #16098 by this P.R. #17138

This is the second regression caused by that, the first being #17360 where cmd+c and cmd+v would input c and v in the composer.

Investigating this error and will try to come up with a fix P.R. in a bit.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Current assignee @PauloGasparSv is eligible for the Engineering assigner, not assigning anyone new.

[PauloGasparSv]

The issue is happening because we only check for inputs in the emojiPicker from the composer but our isEmojiPickerVisible only checks for that picker and not the individual reportActions/messages pickers.

I'm trying to figure out if we can check if there are other emojiPickers opened inside of the composer logic.

[getusha]

@PauloGasparSv I was able to fix it!

here is what i did, checked if the current active element is input and return early, this should be enough and checking the target element is not quite useful

Screen.Recording.2023-04-13.at.2.15.33.PM.mov

[PauloGasparSv]

Not only that solution works but it also removes the need for this logic we already had I think right?

// If we're typing on another input/text area, do not focus
if (e.target.nodeName === 'INPUT' || e.target.nodeName === 'TEXTAREA') {
    return;
}

Making some tests here!

[PauloGasparSv]

@muttmuure can you confirm if it's ok to assign @getusha to create a P.R. fix for this? I think we should go with that solution.

Since it's a regression I'm not sure if the original P.R.'s author is the one supposed to do that or how compensation works in this case.

[PauloGasparSv]

Following this internal slack question I'll create the P.R. for this and CP it to staging before I clock off using @getusha's proposal

[muttmuure]

Only C+ gets a penalty for a regression, Contributors are expected to fix the regression, but we shouldn't be blocked on that if a fix is already found.

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

PR Merged 🎉

[PauloGasparSv]

P.R. was CP'd to staging here cc @mountiny

[mountiny]

Fixed in staging

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert: 17138 17360 listen keydown from user #17475

If no regressions arise, payment will be issued on 2023-04-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@PauloGasparSv] The PR that introduced the bug has been identified. Link to the PR:
• [@PauloGasparSv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@PauloGasparSv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@muttmuure] Determine if we should create a regression test for this bug.
• [@PauloGasparSv] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Nobody to be padi so I think we can close

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert: 17138 17360 listen keydown from user #17475

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@PauloGasparSv] The PR that introduced the bug has been identified. Link to the PR:
• [@PauloGasparSv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@PauloGasparSv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@muttmuure] Determine if we should create a regression test for this bug.
• [@PauloGasparSv] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: