Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed
26 tasks done
OSBotify opened this issue Apr 13, 2023 · 13 comments
Closed
26 tasks done

Deploy Checklist: New Expensify 2023-04-13 #17379

OSBotify opened this issue Apr 13, 2023 · 13 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 13, 2023

Release Version: 1.3.0-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 13, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.0-0 🚀

@mvtglobally
Copy link

mvtglobally commented Apr 14, 2023

@francoisl Regression is completed

Deploy Blockers:

Web - Chat - Typing from emoji picker also fills composer input unnecessarily #17413
Android - Setting - Android Staging app has noticeable lag as compared to PROD #17427

PR #16794 is failing #17410
PR #16932 is failing #17409. Repro in prod
PR #17072 is failing #17426. Partially blocked as well - Not sure if this is Beta or need specific accounts, but we are not able to run Transfer balance
PR #17136 is failing #17410
PR #17221 is failing #17458. Repro in prod, checking off
PR #16624 we are blocked to run this PR

@francoisl
Copy link
Contributor

Thanks, will look into these shortly.

@francoisl
Copy link
Contributor

The blockers are still under investigation, here's an update on where we're at with the rest:

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 17, 2023
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.0-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.0-1 has been deployed to staging 🎉

@mountiny mountiny added Daily KSv2 and removed Monthly KSv2 labels Apr 17, 2023
@mountiny mountiny self-assigned this Apr 17, 2023
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.0-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.0-2 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

Checking #16794 and #17136 off as it does not seem they would be reliably reproducible.

@mountiny
Copy link
Contributor

Checking #16932 off since th tests are passing.

@mountiny
Copy link
Contributor

Checking #17072 off since the problem raised during QA does not seem like a deploy blocker

@mountiny
Copy link
Contributor

The CP seemed to fix the issues so I think we should be fine to deploy 🎉
image

Checking off all the deploy blockers.

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants