Fix Plaid triggered again on selector bank accounts page after coming back from offline #17136

hoangzinh · 2023-04-07T15:20:17Z

Details

Fixed Issues

$ #15861
PROPOSAL: #15861 (comment)

Tests

Note: If you want to test Plaid login in dev/staging, you can enable Use Staging Server in Setting > Preferences

On any devices, login to an Expensify account
Go to Setting > Payments
Click Add payment method > Bank account
Proceed with Plaid identification until selector page is displayed
Go offline
Go online
Verify that Plaid is not triggered again
Select a bank account and try to submit clicking the button
Verify that User can proceed with submitting chosen account

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-07.at.22.39.58.-.web-1080.mp4

Mobile Web - Chrome

Screen.Recording.2023-04-07.at.23.14.08.-.android.chrome.-.1080.mp4

Mobile Web - Safari

Screen.Recording.2023-04-07.at.23.27.45.-.ios.safari.-.1080.mp4

Desktop

Screen.Recording.2023-04-07.at.22.55.41.-.desktop.-.1080.mp4

iOS

Screen.Recording.2023-04-07.at.23.30.30.-.ios.-.1080.mp4

Android

Screen.Recording.2023-04-07.at.23.03.29.-.android.1080.mp4

…ck from offline

MelvinBot · 2023-04-07T16:47:03Z

@grgia @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiros · 2023-04-07T16:55:49Z

src/components/AddPlaidBankAccount.js

+    /**
+     * @returns {Boolean}
+     */
+    hasPlaidBankData() {


Maybe hasPlaidData is better name. If fails, no bank data but just error.

0xmiros · 2023-04-07T16:59:01Z

src/components/AddPlaidBankAccount.js

-        if ((this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken)
-            || !_.isEmpty(lodashGet(this.props.plaidData, 'bankAccounts'))
-            || !_.isEmpty(lodashGet(this.props.plaidData, 'errors'))) {
+        if ((this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken) || this.hasPlaidBankData()) {


I am not sure why this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken is needed here.
If needed, it means that this can be true even if no plaid data, and this should be added as well in componentDidUpdate which is the reason why I selected @situchan's proposal.

If we're not sure about it, I recommend we should not add it until we know it. Otherwise, let's say this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken is true but no plaid data like you said. What is user seeing in the screen now? Maybe a black screen. I think it's bad UX than we let user redo Plaid again.
I think the most important thing in this case is we need to ensure it has either bank accounts or error so user can know what to do next.

@grgia what are your thoughts on this?

@grgia Just in case you miss this one, do you have any opinion on this? Basically I can replicate conditions we have in componentDidAmount, but I'm afraid that it would lead to strange behavior that I mentioned above. So to be safe, I would like to keep it clean as possible. We can back and update this condition if we find a case that doesn't work.

bump for speed up

I think that we should keep the this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken checks

I have addressed your feedbacks @grgia @0xmiroslav

src/components/AddPlaidBankAccount.js

grgia · 2023-04-12T08:26:29Z

src/components/AddPlaidBankAccount.js

-        if ((this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken)
-            || !_.isEmpty(lodashGet(this.props.plaidData, 'bankAccounts'))
-            || !_.isEmpty(lodashGet(this.props.plaidData, 'errors'))) {
+        if ((this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken) || this.hasPlaidBankData()) {


I think that we should keep the this.props.receivedRedirectURI && this.props.plaidLinkOAuthToken checks

…nentDidUpdate

0xmiros · 2023-04-12T09:58:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.MP4

Desktop

desktop.mov

iOS

Android

android.mp4

0xmiros

LGTM 🎉
@grgia all you!

grgia

LGTM!

OSBotify · 2023-04-12T12:02:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-13T03:43:54Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-17T22:58:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Prevent Plaid triggered again on selector bank accounts page after ba…

2630132

…ck from offline

hoangzinh force-pushed the df/15861 branch from 3db0e06 to 2630132 Compare April 7, 2023 15:24

hoangzinh changed the title ~~Fix Plaid triggered again on selector bank accounts page after back from offline~~ Fix Plaid triggered again on selector bank accounts page after coming back from offline Apr 7, 2023

Rename method

93f32d0

hoangzinh marked this pull request as ready for review April 7, 2023 16:46

hoangzinh requested a review from a team as a code owner April 7, 2023 16:46

melvin-bot bot requested review from 0xmiros and grgia and removed request for a team April 7, 2023 16:47

0xmiros reviewed Apr 7, 2023

View reviewed changes

Rename method hasPlaidData

dff8672

grgia reviewed Apr 12, 2023

View reviewed changes

Reuse checking Plaid bank login for both componentDidAmount and compo…

a7f8c8b

…nentDidUpdate

0xmiros approved these changes Apr 12, 2023

View reviewed changes

grgia approved these changes Apr 12, 2023

View reviewed changes

grgia merged commit 1df7d58 into Expensify:main Apr 12, 2023

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

kbecciv mentioned this pull request Apr 13, 2023

Payments - Error message displayed when selecting the any bank account after back online #17410

Closed

6 tasks

MelvinBot mentioned this pull request Apr 17, 2023

[HOLD for payment 2023-04-24] [$2000] Connect Bank Account - Plaid triggered again after several clicks on selector page in offline mode #15861

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Plaid triggered again on selector bank accounts page after coming back from offline #17136

Fix Plaid triggered again on selector bank accounts page after coming back from offline #17136

hoangzinh commented Apr 7, 2023 •

edited

Loading

MelvinBot commented Apr 7, 2023

0xmiros Apr 7, 2023

0xmiros Apr 7, 2023

hoangzinh Apr 7, 2023

0xmiros Apr 7, 2023

hoangzinh Apr 10, 2023

hoangzinh Apr 11, 2023

grgia Apr 12, 2023

hoangzinh Apr 12, 2023

grgia Apr 12, 2023

0xmiros commented Apr 12, 2023 •

edited

Loading

0xmiros left a comment

grgia left a comment

OSBotify commented Apr 12, 2023

OSBotify commented Apr 13, 2023

OSBotify commented Apr 17, 2023

Fix Plaid triggered again on selector bank accounts page after coming back from offline #17136

Fix Plaid triggered again on selector bank accounts page after coming back from offline #17136

Conversation

hoangzinh commented Apr 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmiros commented Apr 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 12, 2023

OSBotify commented Apr 13, 2023

OSBotify commented Apr 17, 2023

hoangzinh commented Apr 7, 2023 •

edited

Loading

0xmiros commented Apr 12, 2023 •

edited

Loading