IOS - Chat - Main composer is displayed when editing second message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #17221

Action Performed:

1. Open NewDot app
2. Open any chat
3. Send 2 messages
4. Start edit for both messages

Expected Result:

Main compose box should not be displayed

Actual Result:

Main compose box appears on the screen once I start to edit second message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.0.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6018008_IMG_9466.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0193911d4ae1a59365
• Upwork Job ID: 1648310272611299328
2023-07-17
• Automatic offers:
• | | 0
• s-alves10 | Contributor | 25753192

[MelvinBot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[zanyrenney]

I can reproduce this in production --

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0193911d4ae1a59365

[MelvinBot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[MelvinBot]

Triggered auto assignment to @techievivek (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

📣 @prempratapsingh! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[chriscoderdr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Main composer is displayed when editing second message

What is the root cause of that problem?

toggleReportActionComposeView (which hides or shows the composer view) is being call with true when the first comment lost focus because the keyboardDidHideListener

What changes do you think we should make in order to solve the problem?

As we are calling toggleReportActionComposeView when the user click save changes and cancel we don't need this call on keyboardDidHide.

But fixing that issue there is another related problem that we see:
If you're editing 2 comments or more at the same time and press save changes or cancel in one of them composer view will be displayed.

To fix that second problem, I propose we take away the responsibility to call toggleReportActionComposeView from each individual message edit (ReportActionItemMessageEdit) and instead take that to ReportActionsList so we can know if more than one edit is being done and call it accordingly.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MelvinBot]

📣 @chriscoderdr! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[chriscoderdr]

Contributor details
Your Expensify account email: christiangomezdev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01cd7e16173e014f7b

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[techievivek]

@aimane-chnaif Can you please have a look at the above proposal by @chriscoderdr

[zanyrenney]

Heading OOO, reapplying the Bug0 label for active management.

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

❌ There was an error making the offer to @s77rt for the Reviewer role. The BZ member will need to manually hire the contributor. cc @thienlnam

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @HezekielT You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

@sonialiap We have decided to share the bounty equal between @HezekielT and @s-alves10, and @s-alves10 alone would be eligible for the 50% bonus if the PR gets merged in 3 business days.

[s-alves10]

@s77rt

PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @s-alves10, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @s-alves10 got assigned: 2023-07-26 03:13:04 Z
• when the PR got merged: 2023-07-28 18:14:51 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show main composer when there is no focused draft #23618

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment
• @HezekielT requires payment
• @s-alves10 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist is not due yet. We reverted the PR.

@techievivek Can we re-open this for proposals?

[techievivek]

I think it would mess up the automation here 🤣, what would happen to the existing payment? Also, do we need to update the bounty to 1000 again?

[s77rt]

There is no payment due here. If it may be easier we can close this issue and move it to the new one?

[techievivek]

Ok, just to confirm, we don't pay anything if the PR gets reverted? I agree that moving the discussion to the new issue would be better.

[s-alves10]

There is one issue related to main composer
#23908

I think it'd be good to close this issue as well and create a new issue containing all cases we've found.
I can create a bug report for this if you don't mind
And I think $2000 is reasonable for the start price

[techievivek]

To summarize what happened over here, we reverted the PR selected for this issue and we will need to investigate further to find a proper fix for the bug(it's a complex one). Therefore, we have decided to close this issue and continue the discussion or propose new solutions at #23908. Additionally, I agree that a starting price of $2000 is reasonable for this bug. Thank you all for your efforts.

We have to make no payment over here.