[HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list #17760

kavimuru · 2023-04-20T23:33:19Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Navigate to any chat
Send 2-3 images
Decrease the screen size
Open the first image and try increasing the screen size

Expected Result:

User shouldn't see other images while increasing the screen size

Actual Result:

On increasing screen size next image gets visible

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-20.at.5.53.52.PM.mov

Recording.293.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681993540527479

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011195db019e2042bb
Upwork Job ID: 1649474118394445824
Last Price Increase: 2023-04-28

MelvinBot · 2023-04-20T23:33:24Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-04-20T23:33:27Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

joekaufmanexpensify · 2023-04-21T18:01:54Z

Agreed, this is a bug. Reproduced on web.

MelvinBot · 2023-04-21T18:04:14Z

Job added to Upwork: https://www.upwork.com/jobs/~011195db019e2042bb

MelvinBot · 2023-04-21T18:04:17Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-04-21T18:04:27Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

MelvinBot · 2023-04-21T18:04:34Z

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

AmjedNazzal · 2023-04-22T21:13:17Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

On increasing the screen size the user can see the previous image in the list

What is the root cause of that problem?

In AttachmentCarousel we are deciding the width of the container that will hold each image in the carousel inside of the renderCell function, the width of this container is supposed to fill the screen so that the other items in the FlatList are not shown on screen, however we are setting the width using state.containerWidth that is being updated using onLayout. the problem with that is that it's not getting updated fast enough when the browser get resized quickly thus leading to the cell not filling the view and for other previous and next images to show for a split second.

App/src/components/AttachmentCarousel/index.js

Lines 198 to 200 in 4947508

    
           renderCell(props) { 
        
               const style = [props.style, styles.h100, {width: this.state.containerWidth}];

App/src/components/AttachmentCarousel/index.js

Lines 232 to 235 in 4947508

    
           return ( 
        
               <View 
        
                   style={[styles.attachmentModalArrowsContainer, styles.flex1]} 
        
                   onLayout={({nativeEvent}) => this.setState({containerWidth: nativeEvent.layout.width + 1})}

What changes do you think we should make in order to solve the problem?

We can update the width of the cell using a seperate more quickly updated value by using useWindowDimensions().width from react-native. that way, the width will be updated fast and the issue is resolved.

/**
* Defines how a container for a single attachment should be rendered
* @param {Object} props
* @returns {JSX.Element}
*/
renderCell(props) {
   const style = [props.style, styles.h100, {width: useWindowDimensions().width}];

We can leave everything else to use the state value of the containerWidth as it was and just change the renderCell.

What alternative solutions did you explore? (Optional)

Result

Sorry for the slow performance in the screen recording.

Screen.Recording.2023-04-23.at.12.05.01.AM.mov

joekaufmanexpensify · 2023-04-24T12:54:04Z

Next step here is to review this proposal.

joekaufmanexpensify · 2023-04-25T19:40:46Z

@aimane-chnaif thoughts on this proposal?

joekaufmanexpensify · 2023-04-27T19:43:00Z

Still pending review

aimane-chnaif · 2023-04-27T19:44:18Z

There's only 1 proposal so far. reviewing shortly

MelvinBot · 2023-04-28T16:00:04Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

joekaufmanexpensify · 2023-04-28T20:26:05Z

Great, thanks!

joekaufmanexpensify · 2023-05-01T12:35:07Z

@aimane-chnaif wanted to check in to see if you could review the proposal on this issue soon? TY!

joekaufmanexpensify · 2023-05-02T20:01:56Z

Proposal still pending review

aimane-chnaif · 2023-05-03T12:46:53Z

@AmjedNazzal thanks for proposal. The root cause is correct and solution also works.
However, I am thinking of deprecating renderCell which was introduced here to support carousel arrow press events on touchable devices.

aimane-chnaif · 2023-05-03T12:48:27Z

@AmjedNazzal please update your proposal based on latest codebase.
AttachmentCarousel component is much changed in #17647

Fix - On increasing the screen size the user can see the previous image in the list #17760

melvin-bot · 2023-05-16T22:58:04Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-05-16T22:58:05Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix - On increasing the screen size the user can see the previous image in the list #17760 #18615

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-16T22:58:06Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Attachment Carousel Virtual Caching #16973
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/16973/files#r1202887868
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This was overlooked while refactoring carousel and also edge case so no further discussions needed. Just commenting on offending PR is enough.
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

joekaufmanexpensify · 2023-05-19T18:12:06Z

@AmjedNazzal offer sent!

joekaufmanexpensify · 2023-05-19T18:12:55Z

@aimane-chnaif offer sent!

joekaufmanexpensify · 2023-05-19T18:14:11Z

@thesahindia offer sent!

joekaufmanexpensify · 2023-05-19T18:14:36Z

@aimane-chnaif when you have a chance, could you also please complete your assigned steps on the BZ checklist?

AmjedNazzal · 2023-05-19T18:19:12Z

@joekaufmanexpensify Thank you! accepted

joekaufmanexpensify · 2023-05-22T13:12:31Z

All set to issue payment soon. Still need to complete BZ checklist steps though.

joekaufmanexpensify · 2023-05-23T19:17:28Z

Bumped BZ checklist steps in Slack.

aimane-chnaif · 2023-05-23T19:30:58Z

The PR that introduced the bug has been identified. Link to the PR: Attachment Carousel Virtual Caching #16973

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/16973/files#r1202887868

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This was overlooked while refactoring carousel and also edge case so no further discussions needed. Just commenting on offending PR is enough.

Is it easy to test for this bug? No
Is the bug related to an important user flow? (For example, adding a bank account) No
Is it an impactful bug? No

Based on that, we can skip regression test proposal.

joekaufmanexpensify · 2023-05-23T19:58:19Z

Great, ty! BZ checklist is now complete.

joekaufmanexpensify · 2023-05-23T20:07:20Z

@AmjedNazzal was assigned to this issue on May 8th at 6:16 PM UTC. The PR was merged on May 12th at 2:12 AM UTC. This is slightly longer than 3 business days, so this does not qualify for a speed bonus. We'll hit 7 full days of the regression reporting bonus later this evening, and then issue payment!

joekaufmanexpensify · 2023-05-24T12:51:27Z

@AmjedNazzal $1,000 sent and contract ended!

joekaufmanexpensify · 2023-05-24T12:52:13Z

@aimane-chnaif $1,000 sent and contract ended!

joekaufmanexpensify · 2023-05-24T12:53:12Z

@thesahindia $250 sent and contract ended!

joekaufmanexpensify · 2023-05-24T12:53:46Z

Upwork job closed.

joekaufmanexpensify · 2023-05-24T12:54:08Z

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

AmjedNazzal · 2023-05-24T14:35:45Z

Thank you! recieved

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 20, 2023

melvin-bot bot assigned joekaufmanexpensify Apr 20, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 21, 2023

melvin-bot bot changed the title ~~On increasing the screen size the user can see the previous image in the list~~ [$1000] On increasing the screen size the user can see the previous image in the list Apr 21, 2023

melvin-bot bot assigned aimane-chnaif Apr 21, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 21, 2023

melvin-bot bot assigned chiragsalian Apr 21, 2023

melvin-bot bot added the Overdue label Apr 24, 2023

melvin-bot bot removed the Overdue label Apr 24, 2023

melvin-bot bot added the Overdue label May 1, 2023

melvin-bot bot removed the Overdue label May 1, 2023

joekaufmanexpensify added the Reviewing Has a PR in review label May 10, 2023

chiragsalian added a commit that referenced this issue May 12, 2023

Merge pull request #18615 from AmjedNazzal/Issue17760

5fd5419

Fix - On increasing the screen size the user can see the previous image in the list #17760

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 16, 2023

melvin-bot bot changed the title ~~[$1000] On increasing the screen size the user can see the previous image in the list~~ [HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list May 16, 2023

melvin-bot bot removed the Reviewing Has a PR in review label May 16, 2023

aimane-chnaif mentioned this issue May 23, 2023

Attachment Carousel Virtual Caching #16973

Merged

67 tasks

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 23, 2023

joekaufmanexpensify closed this as completed May 24, 2023

[HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list #17760

[HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list #17760

Comments

kavimuru commented Apr 20, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Apr 20, 2023

MelvinBot commented Apr 20, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

joekaufmanexpensify commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

AmjedNazzal commented Apr 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

joekaufmanexpensify commented Apr 24, 2023

joekaufmanexpensify commented Apr 25, 2023

joekaufmanexpensify commented Apr 27, 2023

aimane-chnaif commented Apr 27, 2023

MelvinBot commented Apr 28, 2023

joekaufmanexpensify commented Apr 28, 2023

joekaufmanexpensify commented May 1, 2023

joekaufmanexpensify commented May 2, 2023

aimane-chnaif commented May 3, 2023

aimane-chnaif commented May 3, 2023 • edited Loading

melvin-bot bot commented May 16, 2023

melvin-bot bot commented May 16, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented May 16, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented May 19, 2023 • edited Loading

joekaufmanexpensify commented May 19, 2023

joekaufmanexpensify commented May 19, 2023

joekaufmanexpensify commented May 19, 2023

AmjedNazzal commented May 19, 2023

joekaufmanexpensify commented May 22, 2023

joekaufmanexpensify commented May 23, 2023

aimane-chnaif commented May 23, 2023

joekaufmanexpensify commented May 23, 2023

joekaufmanexpensify commented May 23, 2023

joekaufmanexpensify commented May 24, 2023

joekaufmanexpensify commented May 24, 2023

joekaufmanexpensify commented May 24, 2023

joekaufmanexpensify commented May 24, 2023

joekaufmanexpensify commented May 24, 2023

AmjedNazzal commented May 24, 2023

kavimuru commented Apr 20, 2023 •

edited by melvin-bot bot

Loading

MelvinBot commented Apr 20, 2023 •

edited by joekaufmanexpensify

Loading

aimane-chnaif commented May 3, 2023 •

edited

Loading

melvin-bot bot commented May 16, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented May 16, 2023 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented May 19, 2023 •

edited

Loading