[$1000] Payment method dropdown option resets everytime we click on amount and go back

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app on any device
2. Click on plus and click on send money
3. Select USD as currency, add any amount and click on continue
4. Change payment method from 'Pay with PayPal' to 'I will settle elsewhere'
5. Click on amount, click back and observe the payment method selection has changed back to 'Pay with PayPal'

Expected Result:

App should not change payment method back to default on just visit of amount page

Actual Result:

App changes payment method back to default on visit of amount page and coming back

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.3-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

payment.method.changes.to.default.on.amount.page.visit.mp4

Recording.308.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682071567004949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a42d8836ae8668cf
• Upwork Job ID: 1650557626009874432
• Last Price Increase: 2023-06-27

[MelvinBot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[anmurali]

Can reproduce

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a42d8836ae8668cf

[MelvinBot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @dangrous (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

I'm fairly certain this is going to have the same solution as:
#17637
and
#17710
@parasharrajat let me know if you agree and if so we can probably close this out?

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The payment method on the Send Money page keeps resetting after switching between the amount screen and the payment screen.

What is the root cause of that problem?

The SettlementButton component contains a ButtonWithMenu component which is recreated every time the user navigates away and back to the page.

What changes do you think we should make in order to solve the problem?

Add a state variable that stores the currently selected payment option to the MoneyRequestModal and pass a handler as a prop down through the children components up to the ButtonWithMenu component which updates the state for the modal. Also pass this state variable as a prop to the ButtonWithMenu component to set the selected option.

Quick summary of changes.

1. In the MoneyRequestModal component

const [selectedPaymentMethodIndex, setSelectedPaymentMethodIndex] = useState(0);

Add the following props to MoneyConfirmPage.

onSelectPaymentMethod={setSelectedPaymentMethodIndex}
selectedPaymentMethod={selectedPaymentMethodIndex}

2. Add the same pair of props to MoneyRequestConfirmationList in the MoneyConfirmPage component.

onSelectPaymentMethod={props.onSelectPaymentMethod}
selectedPaymentMethod={props.selectedPaymentMethod}

3. Add the same pair to SettlementButton in the MoneyRequestConfirmationList component.

onSelectPaymentMethod={this.props.onSelectPaymentMethod}
selectedPaymentMethod={this.props.selectedPaymentMethod}

4. Add the same pair to ButtonWithMenu in the SettlementButton component.

onSelectPaymentMethod={this.props.onSelectPaymentMethod}
selectedPaymentMethod={this.props.selectedPaymentMethod}

5. Update the ButtonWithMenu component.

const selectedItem = this.props.options[this.props.selectedPaymentMethod];
...
onSelected: () => {
    if (_.isFunction(this.props.onSelectPaymentMethod)) {
        this.props.onSelectPaymentMethod(index);
    }
},

What alternative solutions did you explore? (Optional)

None.

[Christinadobrzyn]

I think #17866 is a dupe of this issue

@parasharrajat or @dangrous could you confirm in the #17866 issue?

[parasharrajat]

It does not sound duplicate to me. We are talking about the button state between navigations here. @Christinadobrzyn @dangrous

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[parasharrajat]

Do you agree on #17805 (comment) @dangrous and @Christinadobrzyn?

[dangrous]

Yeah I think it's separate? Not 100% sure but better to err on the side of separate rather than risk not fixing one of these.

[aimane-chnaif]

I suggest to hold this for #17662 since money request pages are being refactored in that PR.

[dangrous]

Yeah I think that's right - I'll put this on hold! Keeping $$$ the same for now since we figured that out before the week was up, but we can revisit as needed in the future.

[dangrous]

Holding still

[anmurali]

Still on hold

[dangrous]

Holding

[dangrous]

Gonna put this on weekly while it's on hold

[dangrous]

Still holding

[dangrous]

still holding

[dangrous]

still on hold

[dangrous]

HODL

[dangrous]

still waiting

[dangrous]

PR fixing #17662 is on staging! We can probably move ahead with retesting and (if necessary) updating proposals

[akinwale]

Looks like the bug has been fixed as I can no longer reproduce it on the latest main.

[dangrous]

Confirmed that I don't see this happening on main anymore. @anmurali or @parasharrajat can you give it one last test to be sure, and if so we can just close this (after handling any necessary payments, I think it would just be bug reporting?)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[anmurali]

Confirmed! Closing.