[HOLD for payment 2023-05-22] [$1000] Red dot persists after removing phone number contact method

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to contact method and click on "New contact method"
2. Add an email that is already associated with an expensify account or a secondary contact method in another account
3. Observe that a red dot appears and disappears when the email is removed
4. Click on "New contact method" again and enter a phone number that is already associated with an Expensify account or a secondary contact method in another account.
5. Remove the phone number and observe that the red dot does not disappear.

Expected result:

The red dot should disappear for both email and phone number contact methods when they are removed.

Actual result:

The red dot only disappears for email contact methods, but not for phone number contact methods.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.344.mp4

2023-04-24.11.20.31.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1682325700089009
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138225fb0a2d307ea
• Upwork Job ID: 1651356624830840832
• Last Price Increase: 2023-05-03

[MelvinBot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Red dot sticks to the profile item even though the phone number contact method removed

What is the root cause of that problem?

While adding the phone number as a new contact method 2 methods get added in the onyx for the loginList(1 optimistic without sms domain & 1 with sms domain which is set by the api onyx response). In case of the error, both methods have the field errorFields, now if we remove the method then other method remains in the onyx and causes this issue.

Screen.Recording.2023-05-05.at.2.09.09.AM.mov

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Line 90 in bb13d03

User.addNewContactMethodAndNavigate(userLogin, password);

What changes do you think we should make in order to solve the problem?

On submitting the new contact method, add sms domain if it is a phone number which will create the sms domain entry in the onyx loginList and same as a key we are receiving in the api response. With this, we only have a single key for the contact method in the onyx and the issue will get resolved.

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Line 90 in bb13d03

User.addNewContactMethodAndNavigate(userLogin, password);

User.addNewContactMethodAndNavigate(OptionsListUtils.addSMSDomainIfPhoneNumber(userLogin), password);

Result

Screen.Recording.2023-04-25.at.2.36.39.AM.mov

[alexpensify]

I'll test tomorrow.

[alexpensify]

I can replicate:

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0138225fb0a2d307ea

[MelvinBot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[timon0305]

Yes, I am doable

[MelvinBot]

📣 @timon0305! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[timon0305]

ok

[MelvinBot]

📣 @BC-Expert! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[timon0305]

Contributor Details
Email: timon0305@outlook.com
Upwork Profile: https://www.upwork.com/freelancers/~010b886808236ee99c

[alexpensify]

@timon0305 and @BC-Expert if either of you are interested, please submit a proposal. Thank you!

[alexpensify]

We are still waiting on proposals here.

[Pujan92]

Just to point out I have made a proposal earlier here

[alexpensify]

I appreciate the reminder. @rushatgabhane - please review @Pujan92's proposal? thanks!

[jliexpensify]

Hi @rushatgabhane - just curious if you think this GH is related to this newly opened one? #18208

If so, could that new one be closed/put on HOLD in favour of yours? Thanks!

[alexpensify]

@rushatgabhane - can you please review the proposal and Jason's question? Thank you!

[pecanoro]

@jliexpensify They are super similar, the problem is probably the same in both but I think the fix will be in too different parts in the code as I think we call two different API endpoints. Not completely sure though.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

I'm heading OOO tomorrow for about a week so adding another BZ member while I'm away to help keep the train moving! 🚂 Sorry I didn't get to this one today, appreciate you @twisterdotcom!!!!

[pecanoro]

Has this been fully paid? Can we close it?

[alexpensify]

I'm catching up from being OOO and online again. It looks like @dylanexpensify reassigned the GH label before going OOO and @twisterdotcom was assigned by Melvin to complete the next steps. Ted, can we get an update here? If no payment has been made, then I'll work on the payment tomorrow.

[Nathan-Mulugeta]

Hey @alexpensify , no payment has been processed yet.

[alexpensify]

I chatted with Ted today, and this one got mixed in the stack. Sorry that the payment was not initiated sooner. I've taken over this GH since I'm back online. I've completed the payment process in Upwork for @Nathan-Mulugeta and @Pujan92. I'm waiting for @rushatgabhane to accept and will close out the GH when the final payment is sent out via Upwork.

[rushatgabhane]

@alexpensify thank you, I applied using account "Satish Gabhane"
context - my upwork 👎 https://expensify.slack.com/archives/C02NK2DQWUX/p1683614947522329

[alexpensify]

Ok, with this news, I've hired @rushatgabhane's father for this job but it's really @rushatgabhane. Everyone has been paid via Upwork at the bonus has been applied. I'm closing this GH-- great work everyone!

[rushatgabhane]

Hi @alexpensify I think you forgot to settle the job 😄

[alexpensify]

Hmmm, I think the job is closed. @rushatgabhane can you screenshot what you are seeing? Thanks!

[rushatgabhane]

This is what i see - https://www.upwork.com/nx/wm/workroom/33722677/overview

https://www.upwork.com/nx/wm/workroom/33722677/messages

[rushatgabhane]

@alexpensify let me know if i can help with anything else

[rushatgabhane]

All settled, thank you so much! @alexpensify

[alexpensify]

Good catch @rushatgabhane-- I'm working to correct this right now.

[alexpensify]

Heads up, new offers have been sent to @Nathan-Mulugeta and @Pujan92. Please accept and I can finish the process. Thanks!

[Nathan-Mulugeta]

Accepted offer @alexpensify

[alexpensify]

Alright, everyone has been paid via Upwork. I'm going to close this GH now.