[HOLD for payment 2023-05-16] [$1000] wrong keyboard type on add New contact method

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go Settings > Profile > Contact methods
2. click on New contact method button
3. click on Email/Phone number input field

Expected:

keyboard type should be email address (same as login screen)which contains @ symbol

Actual:

default keyboard appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682411521345929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b8315d0c90ac132
• Upwork Job ID: 1651615643428438016
• Last Price Increase: 2023-04-27

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

keyboard type is default instead of email address while adding a New contact method

What is the root cause of that problem?

keyboard type is not added for the New contact method input field

What changes do you think we should make in order to solve the problem?

add keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS} to below TextInput field and add import CONST from '../../../../CONST';

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 106 to 113 in f3fae40

	<TextInput
	label={`${props.translate('common.email')}/${props.translate('common.phoneNumber')}`}
	ref={loginInputRef}
	value={login}
	onChangeText={handleLoginChange}
	autoCapitalize="none"
	returnKeyType={Permissions.canUsePasswordlessLogins(props.betas) ? 'done' : 'next'}
	/>

[sophiepintoraetz]

Able to reproduce!

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016b8315d0c90ac132

[MelvinBot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Current assignee @johnmlee101 is eligible for the External assigner, not assigning anyone new.

[johnmlee101]

@eVoloshchak I think #18003 (comment) the proposal by @gadhiyamanan makes sense. Will let you confirm that we should go with that

[eVoloshchak]

@gadhiyamanan's proposal looks good to me too!
Let's proceed with it
🎀👀🎀 C+ reviewed!
cc: @johnmlee101

[MelvinBot]

📣 @gadhiyamanan You have been assigned to this job by @johnmlee101!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gadhiyamanan]

PR is ready for review @eVoloshchak @johnmlee101

[melvin-bot]

@johnmlee101, @eVoloshchak, @sophiepintoraetz, @gadhiyamanan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix email keyboard type #18236

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

All right - looks like this meets the 50% bonus so am I correct that the payments are:
@gadhiyamanan: $250 + $1500 = $1750
@eVoloshchak: $1500 (I also need you to complete the steps here)

If so, can you accept the hire form? 🙏

[gadhiyamanan]

@sophiepintoraetz accepted, thanks!

[sophiepintoraetz]

Hey @eVoloshchak - can you please complete the C+ checks before I release payment?

[eVoloshchak]

Sure, will complete the checklist in a couple of hours

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: New contact method #15330

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15330/files#r1197903786

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think additional discussion is needed, it's a small issue that was just missed during the review

• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? No
  Is it an impactful bug? No
  This is a very small issue, we don't need to create a regression test for this I think

[sophiepintoraetz]

We're all set here - @eVoloshchak payment is en route.