Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Bank - Account number isn't updated and not match that from your other device. #18025

Closed
2 of 6 tasks
kbecciv opened this issue Apr 26, 2023 · 16 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Apr 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log into an account without a Workspace VBA set up (create a new workspace if needed) Used iOS App
  2. Go to Workspace settings > Connect bank account
  3. Select the Connect manually method to add a bank account
  4. Type in incorrect routing and account numbers
  5. In a second device (used Web Mac/Chrome), log in to the same account and navigate again to Workspace settings > Connect bank account
  6. Enter routing and account numbers that satisfy the requirements (ex 041215032 and 123456), then continue on and complete Step 2 in the flow
  7. Refresh the page in first device

Expected Result:

Verify that the Routing number and Account number are now updated to match that from your other device, and the inputs are disabled

Actual Result:

Account number isn't updated and not match that from your other device.
Issue reproduced on Desktop App + iOS App.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6032351_17748__iOS.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017a366153568a299f
  • Upwork Job ID: 1659316205631774720
  • Last Price Increase: 2023-05-18
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 26, 2023
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@MelvinBot
Copy link

@puneetlath 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@puneetlath
Copy link
Contributor

Hmm, interesting. I'm not sure whether this is something that we store on the server or locally. Looking into it.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

@puneetlath Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@puneetlath
Copy link
Contributor

@kbecciv was this part of an existing testrail flow that you were testing? Right now the way this is built, it doesn't share this info across devices, so I kind of feel like this is more of a feature request than an existing bug.

@melvin-bot melvin-bot bot removed the Overdue label May 11, 2023
@kbecciv
Copy link
Author

kbecciv commented May 12, 2023

@puneetlath No, this is not part of an existing TR flow, QA team found this issue when executing PR #17748

@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@puneetlath
Copy link
Contributor

Ok got it! I'll look into it then.

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

@puneetlath this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath puneetlath added the Internal Requires API changes or must be handled by Expensify staff label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~017a366153568a299f

@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@puneetlath
Copy link
Contributor

puneetlath commented May 19, 2023

@amyevans perhaps you could help me here since it seems the steps are coming from this PR.

From what I can see of this code, we don't actually save the bank account in the database yet when they've only manually entered a bank account/routing number on step 1. So there isn't an expectation that on a different device you would see the bank account/routing number. Am I misunderstanding?

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@amyevans
Copy link
Contributor

The video in the OP does not match the reproduction steps listed. I tested and it looks like it's working as expected!

test-18025.mov

@puneetlath
Copy link
Contributor

Ah perfect thank you! So you need to complete step 2 also. Ok going to go ahead close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants