[HOLD for payment 2023-06-08] [$2000] Scrolling on emoji suggestion scrolls the background on Android app but not on mWeb

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. type :he
3. Scroll on the emoji suggestion

Expected result:

The background should not be scrolled when scrolling over the emoji suggestion (Just like it doesn't on mWeb)

Actual result:

The background chat is being scrolled which is not consistent with the behavior of mWeb.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.7.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

az_recorder_20230427_185245.1.mp4

video5931661465718099629.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682597075395629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ed0711095eb0abe
• Upwork Job ID: 1653488906370875392
• Last Price Increase: 2023-05-18

[MelvinBot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[stephanieelliott]

Adding the External label!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010ed0711095eb0abe

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[FLS-UA]

Hi,
I would search for a solution in CSS:
.r-12vffkv {
pointer-events: none !important;
}

.r-12vffkv > * {
pointer-events: auto;
}

Because pointer parameter takes care of interaction with the user and probably android/native browser has something with that.

[MelvinBot]

📣 @FLS-UA! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[FLS-UA]

Contributor details
Your Expensify account email: andrikanich@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/yevhenandrikanych

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mollfpr]

@FLS-UA Thank you for your interest in fixing this issue. We have a template for proposing a proposal here, and also you can find another useful information in the CONTRIBUTING.MD and I'll be happy to review your proposal.

[FLS-UA]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Scrolling on emoji suggestion scrolls the background on Android app.

What is the root cause of that problem?
Pointer parameter, because it takes care of interaction with the user and probably android/native browser has something with that.

What changes do you think we should make in order to solve the problem?
I would search for a solution in CSS:
.r-12vffkv {
pointer-events: none !important;
}

.r-12vffkv > * {
pointer-events: auto;
}

[mollfpr]

@FLS-UA I'm unsure where to find .r-12vffkv class name in our codebase 😅

[FLS-UA]

[mollfpr]

@FLS-UA You should try cloning the App and go through the codebase.

[stephanieelliott]

Hey @FLS-UA were you able to follow the instructions given by #18112 (comment)?

[mollfpr]

Looks good to me! Tests on the mention suggestion work well too.

@arosiclair Let's go with @aswin-s proposal then.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

📣 @aswin-s You have been assigned to this job by @arosiclair!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aswin-s]

PR is open. #19621

[stephanieelliott]

PR is undergoing QA!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent scrolling in suggestions popup propagating to layers below #19621

If no regressions arise, payment will be issued on 2023-06-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

@mollfpr can you please complete the BugZero checklist? Once completed I will issue payment.

@aswin-s and @Nathan-Mulugeta you have been paid!

[mollfpr]

Sorry for the delay @stephanieelliott

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#14686

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#14686 (comment)

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This will be enough with the regression step.

[@mollfpr] Determine if we should create a regression test for this bug.

👍

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open a chat on Android device
2. Try to add an emoji in composer via keyboard using : (Example - :heart)
3. Verify that emoji suggestions are shown once two characters are added after :
4. Verify that trying to scroll inside the emoji suggestions popup is not scrolling the chat in background
5. Open mention suggestions by entering '@'
6. Verify that scrolling inside mention suggestions popup is also not scrolling the background.
7. Verify that scrolling inside suggestion popup is working properly on other platforms (iOS, Web, Desktop).
8. 👍 or 👎

[melvin-bot]

@arosiclair, @aswin-s, @mollfpr, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Issue for regression test: https://github.com/Expensify/Expensify/issues/291429

[stephanieelliott]

All paid, thanks!