-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-08] [HOLD] [Moderation] Create FlagCommentPage #18508
Comments
Eep! 4 days overdue now. Issues have feelings too... |
6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
will get to this next week! |
Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Triggered auto assignment to @shmaxey ( |
@shmaxey here's the deets on the copy! https://expensify.slack.com/archives/C03SSAQG5/p1684932257657339 |
Reviewing yellow columns here: https://docs.google.com/spreadsheets/d/1TvHXqVjPE8QU62Z546M9ESeGMo1JsCTKP3NBAKQtsW0/edit#gid=0 Done! |
Shoot, sorry @dangrous - I'll leave this 👐 |
Thank you @shmaxey! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-08. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Triggered auto assignment to @isabelastisser ( |
Bug0 Triage Checklist (Main S/O)
|
Not a bug, just getting a teammate to help with payment for @eVoloshchak's review |
@dangrous, please let me know what I need to do next. Create a job in Upwork and pay @eVoloshchak on June 8? What's the payment amount? |
I believe internal review is $1k (@eVoloshchak correct me if I'm wrong)! And yep, you got it - job for payment on 6/8. |
cool, thanks @dangrous ! ;) |
Not overdue. Payment on June 8! |
We're ready for payment @isabelastisser ! |
@isabelastisser is out until Wednesday - @eVoloshchak are you okay with waiting until then? If it's pressing I can find another team member to help out. |
@dangrous, sure, I can wait no problem |
@eVoloshchak sorry for the delay! I will issue the payment now. |
@eVoloshchak I extended the contract to you in Upwork now. Please accept it, and I will process the payment. Thanks! |
Part of NewDot Moderation - Tracking Issue and Design Doc
Design Doc Section
Routing
Add the new route to ModalStackNavigators.js with the name 'FlagComment_Root'
Since each report is flagged on a reportAction, we will update the route to include the reportActionID in ROUTES.js like flag/:reportActionID
Update linkingConfig.js to use that new route added above
These will be created in a similar manner to our Settings page. After a header section:
We’ll create a list of MenuItems with the appropriate severity and format:
A couple new things to point out in that logic:
The style will be the same as the description text style, but one font size smaller.
The text was updated successfully, but these errors were encountered: