Create FlagCommentPage #19412

dangrous · 2023-05-22T20:40:54Z

Details

This is prepping for moderation! You will not see any visual changes to the content right now - not until #19476 is complete - but you can check the props in your console/inspector to make sure that the moderationDecisions property for flagged messages is updated appropriately. You should also get a whisper back, both as the reporter and as the author of the flagged content.

You will also get the 1:1:1 too many commands alert for this on dev - that's because it's flagging the comment and sending two whispers (3x commands total). No way around this at the moment, we'll update the listing on PHP shortly.

Fixed Issues

$ #18508
$ #18503

Tests

Make sure the flag option is visible in the context menus of chats from other users - but not from concierge.
Make sure clicking the flag opens the flag content page.
Make sure that choosing a severity option successfully flags the comment. (Right now you can check the ReportActionItem.message.moderationDecisions to make sure the right decision is added correctly to the right report action. It should be "pending" for spam/inconsiderate, and "pendingHide" for everything else.) [THIS IS WHY WE NEED INTERNAL QA FOR NOW]
Ensure that choosing a severity option successfully sends a whisper to the reporter
Ensure that choosing a severity option successfully sends a whisper identifying the severity level to the reportee.

Verify that no errors appear in the JS console

Offline tests

Same as Tests; the whispers will of course not be sent but the moderationDecisions should be appropriately updated.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

I cannot run the iOS app currently due to XCode 14.3

Android

thienlnam

Nice - looks solid! Just a NAB

src/pages/FlagCommentPage.js

melvin-bot · 2023-05-26T20:20:44Z

@eVoloshchak @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-05-30T11:16:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-31.at.18.13.17.mov

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-05-31.at.18.14.42.mov

Desktop

Screen.Recording.2023-05-31.at.18.16.31.mov

iOS

Screen.Recording.2023-05-31.at.18.15.45.mov

Android

eVoloshchak

Found a couple of issues:

Navigate to a conversation
Right-click on someone elses message
Select "Reply in thread"
Right click on the message in thread
Select "Flag as offensive"
Press on any severity option
Notice nothing is happening and there's error in console

Screen.Recording.2023-05-30.at.14.36.19.mov

On mWeb/iOS/Android or web with isSmallScreenWidth = true

Select "Flag as offensive" on any message
Press on any severity option
Notice that you're navigated back twice (to the list with chats) instead of to the current chat

screen-20230530-143910.mp4

dangrous · 2023-05-30T15:41:46Z

Figured out the double navigation thing; the threads bit is becoming a little trickier. Have asked in Slack here - it's because the route is giving us the new, thread reportID, not the original - so the reportAction isn't found on the new report.

dangrous · 2023-05-31T14:55:33Z

okay i think i fixed the bugs you found @eVoloshchak.

@youssef-lr I am also sometimes getting that issue; doesn't seem like it's related to this, but we can look into it in PHP

youssef-lr · 2023-05-31T14:58:02Z

@dangrous it's weird though that it's only happening with whispers? as regular messages updates work properly.

dangrous · 2023-05-31T14:58:11Z

annnnnd it does look like attachments will work! I've updated to allow them to be flagged.

youssef-lr

LGTM! The bug I found should be fixed in the backend I think.

dangrous · 2023-05-31T15:09:03Z

sorry @youssef-lr I needed to add prettier, can you approve again (i'll still wait for confirmation from @eVoloshchak before merging tho)

eVoloshchak · 2023-05-31T15:11:23Z

Found one more edge case where the reveal button is hidden for a second

Flag message as Spam
Flag message as Bullying
Go to 'Reply in thread"
Go back to chat
Mark the same message as Spam

Screen.Recording.2023-05-31.at.18.08.25.mov

dangrous · 2023-05-31T15:22:22Z

ooh I think I know why that's happening, it's because onyx.merge goes much deeper than I thought. I thought that this part of the flagComment method was replacing the existing moderationDecisions but it's actually merging them, i.e. adding them. I can get around it in the meantime by just always looking at the latestdecision but not sure if there's a cleaner way.

dangrous · 2023-05-31T15:24:08Z

should be fixed now

eVoloshchak · 2023-05-31T15:24:54Z

Also I think this highlight should take up full width with paddings inside it (in case the UI is finalized)

dangrous · 2023-05-31T15:28:30Z

whatttt i fixed that.

dangrous · 2023-05-31T15:35:55Z

fixed. Thanks for being so thorough @eVoloshchak !

eVoloshchak

LGTM

OSBotify · 2023-05-31T18:11:41Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-01T03:03:53Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.21-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 · 2023-06-14T08:33:34Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            ReportUtils.canFlagReportAction(reportAction, reportID) &&
+            !isArchivedRoom &&
+            !isChronosReport &&
+            !ReportUtils.isConciergeChatReport(reportID) &&


Hi @dangrous Coming from #20197 In this issue, we come up with that ReportUtils.isConciergeChatReport will return true if it is main chat with Concierge (not include thread with Concierge). But the thread chat with Concierge also should not show flag option. Fortuantley, the below condition reportAction.actorEmail !== CONST.EMAIL.CONCIERGE, just handled this case so this condition !ReportUtils.isConciergeChatReport(reportID) is redundant. Should we remove it?
cc @eVoloshchak

I think that's right! Shouldn't be a need for that. cc @thienlnam in case you see anything wrong with that.

Yeah sounds good to me, as long as you don't see flag messages in a Concierge chat the problem is solved

mananjadhav · 2023-07-11T15:51:20Z

src/pages/FlagCommentPage.js

+    ));
+
+    return (
+        <ScreenWrapper includeSafeAreaPaddingBottom={false}>


I think when we created this component, we didn't add any access controls. Hence this caused a regression.

ahhhh nice catch, thank you for calling it out!

navigation and skeleton page

b8d5da8

dangrous self-assigned this May 22, 2023

dangrous changed the title ~~Create FlagCommentPage~~ [WIP] Create FlagCommentPage May 22, 2023

dangrous added 3 commits May 22, 2023 17:37

add menu items

d770146

include reportID and skeleton onPress

b7b0c69

add flag icons

d60f0d9

dangrous mentioned this pull request May 24, 2023

[No QA] Add Report.flagComment command #19405

Merged

57 tasks

add context menu action

e21c085

dangrous mentioned this pull request May 26, 2023

[HOLD] Add "Flag as Offensive" context menu action #19417

Closed

57 tasks

dangrous added 6 commits May 26, 2023 12:44

Merge branch 'main' into dangrous-flagcommentpane

37a2115

Merge branch 'main' into dangrous-flagcommentpane

7705873

add translations

52b5306

call the flagComment method

15e4aef

style and prettier

48f1be5

update to work with new backend logic re: moderationDecisions object

6709e2a

thienlnam reviewed May 26, 2023

View reviewed changes

src/pages/FlagCommentPage.js Outdated Show resolved Hide resolved

dangrous added 2 commits May 26, 2023 15:29

add constants for all severities

cb2d45e

prettier one more time

a020c49

dangrous changed the title ~~[WIP] Create FlagCommentPage~~ Create FlagCommentPage May 26, 2023

dont allow flagging of whispers from concierge

863422a

dangrous added the InternalQA This pull request required internal QA label May 26, 2023

dangrous marked this pull request as ready for review May 26, 2023 20:20

dangrous requested a review from a team as a code owner May 26, 2023 20:20

melvin-bot bot requested review from eVoloshchak and youssef-lr and removed request for a team May 26, 2023 20:20

eVoloshchak suggested changes May 30, 2023

View reviewed changes

fix display bugs

599d3c2

allow flagging of attachments

7e9adc8

youssef-lr previously approved these changes May 31, 2023

View reviewed changes

prettier

8789e03

dangrous dismissed youssef-lr’s stale review via 8789e03 May 31, 2023 15:08

look at latest moderationDecision

fa0fd0b

apply hover style to press as well

80b28d6

use getReportID

83929ca

eVoloshchak approved these changes May 31, 2023

View reviewed changes

youssef-lr approved these changes May 31, 2023

View reviewed changes

youssef-lr merged commit 36fe848 into main May 31, 2023

youssef-lr deleted the dangrous-flagcommentpane branch May 31, 2023 16:28

OSBotify mentioned this pull request May 31, 2023

Deploy Checklist: New Expensify 2023-05-31 #19896

Closed

37 tasks

This was referenced Jun 1, 2023

[HOLD for payment 2023-06-08] [HOLD] [Moderation] Create FlagCommentPage #18508

Closed

[HOLD for payment 2023-06-08] [HOLD] [Moderation] Create Flag Context Menu Action #18503

Closed

dukenv0307 reviewed Jun 14, 2023

View reviewed changes

mananjadhav reviewed Jul 11, 2023

View reviewed changes

mananjadhav mentioned this pull request Jul 11, 2023

[HOLD for payment 2023-07-10] [$1000] Users are able to flag their own comment #21212

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create FlagCommentPage #19412

Create FlagCommentPage #19412

dangrous commented May 22, 2023 •

edited

Loading

thienlnam left a comment

melvin-bot bot commented May 26, 2023

eVoloshchak commented May 30, 2023 •

edited

Loading

eVoloshchak left a comment

dangrous commented May 30, 2023

dangrous commented May 31, 2023

youssef-lr commented May 31, 2023

dangrous commented May 31, 2023

youssef-lr left a comment

dangrous commented May 31, 2023

eVoloshchak commented May 31, 2023

dangrous commented May 31, 2023

dangrous commented May 31, 2023

eVoloshchak commented May 31, 2023 •

edited

Loading

dangrous commented May 31, 2023

dangrous commented May 31, 2023

eVoloshchak left a comment

OSBotify commented May 31, 2023

OSBotify commented Jun 1, 2023

dukenv0307 Jun 14, 2023 •

edited

Loading

dangrous Jun 16, 2023

thienlnam Jun 16, 2023

mananjadhav Jul 11, 2023

dangrous Jul 11, 2023

Create FlagCommentPage #19412

Create FlagCommentPage #19412

Conversation

dangrous commented May 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

thienlnam left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 26, 2023

eVoloshchak commented May 30, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

dangrous commented May 30, 2023

dangrous commented May 31, 2023

youssef-lr commented May 31, 2023

dangrous commented May 31, 2023

youssef-lr left a comment

Choose a reason for hiding this comment

dangrous commented May 31, 2023

eVoloshchak commented May 31, 2023

dangrous commented May 31, 2023

dangrous commented May 31, 2023

eVoloshchak commented May 31, 2023 • edited Loading

dangrous commented May 31, 2023

dangrous commented May 31, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

OSBotify commented May 31, 2023

OSBotify commented Jun 1, 2023

dukenv0307 Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

dangrous Jun 16, 2023

Choose a reason for hiding this comment

thienlnam Jun 16, 2023

Choose a reason for hiding this comment

mananjadhav Jul 11, 2023

Choose a reason for hiding this comment

dangrous Jul 11, 2023

Choose a reason for hiding this comment

dangrous commented May 22, 2023 •

edited

Loading

eVoloshchak commented May 30, 2023 •

edited

Loading

eVoloshchak commented May 31, 2023 •

edited

Loading

dukenv0307 Jun 14, 2023 •

edited

Loading