Deploy Checklist: New Expensify 2023-05-31

[OSBotify]

Release Version: 1.3.21-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Open report for anonymous users #18293
• [No QA] Handle Moderated Messages in UI #19476
• 17021 - migrate ResendValidationForm to PressableWithFeedback #19528
• [No QA] Remove unused ReportTransactions and IOUTransactions #19552
• Fix error appear for a second when create a task for new member #19600
• fix 17289 regression don't show edit and download button when attachment is uploading #19618
• fix: prevent scrolling in suggestions popup propagating to layers below #19621
• [No QA] [HOOK REFACTOR] Form #19633
• fix: update height for text container #19653
• Fix: New tagline after marking as unread have overlapping line #19658
• Migrate ExceededCommentLength to functional component #19676
• Pass props.windowHeight to getBaseNavigationModalCardStyles #19682
• feat: add AnonymouseReportFooter component #19694
• feat: add isAnonymous prop to the the AvatarWithDisplayName component #19699
• Fix: user could enter a wrong rate: a number and a point and save successfully #19705
• fix: broken Anonymous report footer on native #19710
• Fix: Attachment Carousel not displaying images from Concierge #19724
• 17023 — migrate PasswordForm to PressableWithFeedback #19732
• 17028— migrate ChangeExpensifyLoginLink to PressableWithFeedback #19733
• Don't decode plain text on pasting text to composer #19738
• Migrate emoji skin tone list #19741
• [NoQA] fix: proper conditions in ReportActionItem #19761
• [NoQA] feat: reassure minimal setup #19811
• fix crash when open report for anonymous user #19818
• Fix recovery code cut from bottom #19822
• fix blank screen appears for a moment when logout #19841
• [No QA] Remove unused OpenPaymentDetailsPage #19864
• Fix chat loading after anonymous user clicks on sign-in #19866
• Fix: Parser Bug in IOU #19868

Internal QA:

• Create FlagCommentPage #19412 - @dangrous

Deploy Blockers:

• Log In - User is redirected to login page with error  #19910
• Log In - Invalid magic link redirects to login page with error "This password link is expired.."  #19911
• [$1000] iOS - Bank account - You are offline modal/page not displayed #19919
• [HOLD for payment 2023-06-28] IOS - Bank account- Error message nor displayed for incorrect validation code/ incorrect account number #19923

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.21-2 🚀

[AndrewGable]

Expensify is going to be leading the testing of this checklist as we have a deadline to get this out by tonight.

[AndrewGable]

#19528 ✅

[isagoico]

Will post regression updates here as well. As mentioned in this thread we will prioritize the following platforms for the regression test plan:

1. Web
2. iOS
3. Android
   Once we get those platforms out of the way, we'll proceed with Web and Desktop.

@AndrewGable let us know if there's any PRs that we should test. We're dividing efforts in the Applause team and we could assign 1 or 2 people to help with PRs.

[mvtglobally]

#19618 checking off as team already validated

[AndrewGable]

@isagoico @mvtglobally - Can Applause start from the bottom and just leave a comment on which PRs you are working on? e.g. start with #19868

[dangrous]

checked off #19412 - some minor unexpected results but nothing to prevent deploy

[JmillsExpensify]

Heads up #19621 doesn't pass though it's pretty minor. The entire page scrolls on mWeb/Safari when you try to scroll within the suggestions pop-up for emojis and mentions. I wouldn't call this a blocker though, shall I go ahead and sign off?

[AndrewGable]

Yep, let's make an comment on the issue, create a follow up issue and then check it off.

[JmillsExpensify]

Cool. I'll comment on the PR now and check off.

[trjExpensify]

QA'd #19618, tests pass. 👍

[isagoico]

@isagoico @mvtglobally - Can Applause start from the bottom and just leave a comment on which PRs you are working on? e.g. start with #19868

Yep! On it. Grabbing #19868

[JmillsExpensify]

#19738 passed on all platforms

[JmillsExpensify]

#19732 this flow and QA can no longer be tested now that passwordless is everywhere. I also confirmed here. Checking off.

[AndrewGable]

Checking off #19733 per @alexpensify's comment here: #19733 (comment)

[isagoico]

#19868 Results:

1. Web - ✅
2. mWeb - ✅
3. iOS - ✅
4. Android - ✅
5. Desktop - ✅

Pass in all platforms 🎉 Checking it off.

[trjExpensify]

Hitting some failures on Android and mWeb Safari executing the Concierge QA steps on #19724 here.

[marcaaron]

Checking off #19919 as it's NotABlocker

[AndrewGable]

Checked off #19724 with a comment for a follow up here: #19724 (comment)

[AndrewGable]

Decided against a deploy blocker for #19923 with this information here: #19923 (comment)

[AndrewGable]