[HOLD for payment 2023-06-28] IOS - Bank account- Error message nor displayed for incorrect validation code/ incorrect account number

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Scenario 1:

1. Log in with a applause.expensifail account (that does not have any bank account already added)
2. Enable staging Web secure server in Account Preferences if disabled
3. Navigate to the add bank account modal
4. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
5. Select the Manual method to add a bank account
6. Use the "Pending State Withdrawal Account" credentials (available below)
7. Verify that when you finish the flow - the modal asks for 3 amounts of test transactions
8. Submit three random amounts

Scenario 2

1. Log in with a applause.expensifail account (that does not have any bank account already added)
2. Enable staging Web secure server in Account Preferences if disabled
3. Navigate to the add bank account modal
4. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
5. Select the Connect with plaid method to add a bank account
6. On the bank account list select "Chase"
7. You'll be redirected to the "First Platypus Bank"
8. Enter the credentials "user_good / pass_good"
9. Continue until you're redirected to the choose an account screen in NewDot
10. Select the bank account ending in 1111
11. Verify you're redirected to the enter back account details manually (this is a special case for the Chase bank account selection)
12. Enter a incorrect bank account number (e.g 1111222233334444

Expected Result:

Scenario 1: Verify that you see the following error: The validate code you entered is incorrect, please try again
Scenario 2: Error for entering the wrong bank account and in which number should the bank account end with.

Actual Result:

No validation error message displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.21.2

Reproducible in staging?: yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Incorrect validation code

Bug6075984_RPReplay_Final1685564233.mp4

Incorrect account number issue

Bug6075988_CHYG7252.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Hello @AndrewGable ! We cannot check the issue in production, adding Deploy Blocker label.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

The reproducible steps don't match the videos shared. So I'm not sure which one is correct. FWIW I can reproduce what's shown in the video on prod too, so it wouldn't be a blocker. I'm waiting for applause to confirm.

[AndrewGable]

I can reproduce what's shown in the video on prod too

I think we should lean on this and investigate it as a normal bug

[luacmartins]

Sounds good!

[isagoico]

Uploaded correct videos! Apologies for the confusion with this one

[hungvu193]

I couldn't reproduce this but I found this one, is this a bug?

Screen.Recording.2023-06-01.at.10.10.12.mov

[kbecciv]

@luacmartins @AndrewGable Apologies for the confusion.

The first scenario: on step 11 error message not displayed for validation.

TR link https://expensify.testrail.io/index.php?/tests/view/3482503

RPReplay_Final1685564233.MP4

The second scenario: step 19. error for entering the wrong bank account is not displayed.

TR link https://expensify.testrail.io/index.php?/tests/view/3482507

Bug6075988_CHYG7252.mp4

[luacmartins]

Hm this is looking like a regression from my Form hook refactor PR - #19633. But I tested this flow thoroughly and didn't have any issues. I'll check again.

Gonna reassign this one to myself if that's ok @robertjchen?

[robertjchen]

yup, thanks!! 🙇

[melvin-bot]

@tjferriss, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Form useEffect #20091

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: [No QA] [HOOK REFACTOR] Form #19633
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [No QA] [HOOK REFACTOR] Form #19633 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@luacmartins] Determine if we should create a regression test for this bug. N/A
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

Checklist complete

[luacmartins]

Waiting on payment

[melvin-bot]

@tjferriss, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

@tjferriss did we pay @rushatgabhane for the PR review?

[rushatgabhane]

Made a manual request on new dot

[tewodrosGirmaA]

Hello @luacmartins , I've noticed that the application doesn't display an error message when we input "XXXXX6789" as the account number. In my testing scenario, this seems to be a unique case. Before closing this issue, I kindly request you to take a look at our conversation on Slack: Slack Conversation Link. It might provide some helpful insights. Thank you!

[luacmartins]

Replied in thread

[luacmartins]

@rushatgabhane has this been paid then?

[luacmartins]

@rushatgabhane did the manual request go through?

[tjferriss]

I just sent @rushatgabhane an offer: https://www.upwork.com/jobs/~013d27f378e338aa91.

Sorry for the delay, I should have re-assigned before heading out on vacation.

[rushatgabhane]

sorry i forgot to post confirmation here.
this has been paid on new dot

[rushatgabhane]

this issue and upwork job can be closed

[luacmartins]

Thanks everyone! Closing!