-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass props.windowHeight
to getBaseNavigationModalCardStyles
#19682
Conversation
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hmm, not sure why pullerbear didn't pick up the right reviewers, added myself and @eVoloshchak |
I made a "syntax error" and then edited the OP to fix it, maybe that |
Ahhh, that might do it! Looks like you have travis failures as well |
...to work around Safari CSS issues.
9a43055
to
b3454c0
Compare
@eVoloshchak |
Add this to Precondition - There is an IOU present between users A & B (to create an IOU, request money from another user). Open Details Pane of the IOU and grab the URL. Make sure you are logged out on mWeb (use an incognito window).
@cubuspl42, what exactly are the steps to get the Details Pane to show? How do we reproduce #17824? |
It seems you cannot really reproduce that issue literally as it was reported, as But the essence of the problem on the technical level remains, and can be easily observed on the "Request Money" modal: |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-05-29.at.00.35.05.movScreen.Recording.2023-05-29.at.00.32.21.movMobile Web - ChromeScreen.Recording.2023-05-29.at.00.35.57.movMobile Web - SafariScreen.Recording.2023-05-29.at.01.34.54.movDesktopScreen.Recording.2023-05-29.at.00.30.40.moviOSScreen.Recording.2023-05-29.at.01.37.31.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc: @alex-mechler
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.3.21-0 🚀
|
Tested |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.21-2 🚀
|
// Safari issues: | ||
// https://github.com/Expensify/App/issues/12005 | ||
// https://github.com/Expensify/App/issues/17824 | ||
height: `${windowHeight}px`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused a regression on Safari where the window height is not reliable.
...to work around Safari CSS issues.
Details
Use the height coming from
withWindowDimensions
(based on theDimensions
API) to work around some Safari bugs.Fixed Issues
$ #17824
PROPOSAL: #17824 (comment)
Tests
Before merging, on macOS Safari:
After merging, on staging, on iOS Safari:
Offline tests
QA Steps
See Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
macOS-Safari-resize-1.mp4
Mobile Web - Chrome
Mobile Web - Safari
ios-Safari-1.mp4
Desktop
iOS
Android