[HOLD for payment 2023-08-21] [$250] mWeb - Unresponsive view on 2 factors authentication screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to profile settings
2. Then click on security
3. Click on two factors authentication
4. Click on copy and and then go to next
5. Click on Textfield
6. Observe the screen

Expected Result:

Ui should be responsive. And show properly even keyboard is focused.

Actual Result:

Screen is unresponsive. Some view disappears while focused.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1690114710.MP4

RPReplay_Final1690202999.MP4

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690115036631379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01deea2e8f64727cde
• Upwork Job ID: 1683466421789040640
• Last Price Increase: 2023-08-08
• Automatic offers:
• s77rt | Reviewer | 26018994
• jscardona12 | Contributor | 26018995
• niravkakadiya25 | Reporter | 26018997

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Yeah, I can repro this one. The next confirmation button should be bottom-docked on this page, like the others. 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01deea2e8f64727cde

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When opening the keyboard on the 2FA page, the Next button is not placed at the bottom.

What is the root cause of that problem?

In iOS the viewport is not correctly updated when opening the keyboard, leading to the Next button not being positioned at the bottom of the page. This is a known issue in Safari:

element-hq/hydrogen-web#181 (comment)

What changes do you think we should make in order to solve the problem?

The VisualViewport API can be used to calculate the correct viewport size.

What alternative solutions did you explore? (Optional)

N/A

[ShogunFire]

It was happening when we had max height on keyboardAvoidingView but was supposed to be fixed here: https://github.com/Expensify/App/pull/16443/files

[AbeDev404]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Responsive view when the keyboard appears.

What is the root cause of that problem?

Cover the full page with KeyAvoidingView or SafeAreaView.

What changes do you think we should make in order to solve the problem?

Cover the full page with KeyAvoidingView or SafeAreaView.
And re-style the Next Button.

[s77rt]

@samh-nl Thanks for the proposal. I don't think your RCA is correct.

[s77rt]

@ShogunFire Yeah I remember such a bug. This one is probably a regression. This works fine on version 1.3.43-0.

[s77rt]

@DevWizard0000 Thanks for the proposal. Please follow the proposal template, we need to find the root cause first then we will work out a solution.

[s77rt]

Not overdue. Still looking for proposals

[trjExpensify]

@DevWizard0000 are you interesting in revising your proposal into the correct format?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ginsuma]

The root cause is minHeight from PR #23222:

App/src/styles/getNavigationModalCardStyles/index.website.js

Line 13 in 8b75ed6

minHeight: `${windowHeight}px`,

I followed the discussion between @s77rt and @jscardona12 on Slack here and saw both of you decided to remove it, but somehow it still exists.
When we open the keyboard, the content moves beyond the top screen. If the content has a height bigger than the current window height, it will not show fully because we added minHeight with the same value to the wrapper in RHP screens.
Currently, I don't find out any cases we need minHeight.

[studentofcoding]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unresponsive view on 2 factors authentication screen on Mobile

What is the root cause of that problem?

App/src/styles/getNavigationModalCardStyles/index.website.js

Line 13 in 8b75ed6

Use KeyAvoidingView or SafeAreaView to cover the full page

What changes do you think we should make in order to solve the problem?

Cover the full page with KeyboardAvoidingView or SafeAreaView.

What alternative solutions did you explore? (Optional)

N/A

cc: @s77rt

[jscardona12]

@ginsuma @s77rt it is needed because with the new navigation implementation the minHeight attribute was on develop. The fix shouldn't be deleting it, it should be setting up to 0. If you delete the minHeight it would cause a side effect.

[s77rt]

@ginsuma Thanks! Indeed that seems to be the offending PR, but we need those changes (or other changes) to fix the 3 mentioned issues in the code comments.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change position: absolute for position:fixed in getNavigationModalCard #24305

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @jscardona12 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Pass props.windowHeight to getBaseNavigationModalCardStyles #19682 and #20709: Use windowHeight in getNavigationModalCardStyles #23222
• The offending PR has been commented on: Pass props.windowHeight to getBaseNavigationModalCardStyles #19682 (comment) and #20709: Use windowHeight in getNavigationModalCardStyles #23222 (comment)
• A discussion in #expensify-bugs has been started: Not needed. This is a regression that could have been caught during PR testing
• Determine if we should create a regression test for this bug: No

[trjExpensify]

👋 payments are due here! As a regression, confirming that's $250 for the bug report only correct @s77rt?

[s77rt]

@trjExpensify Correct! 👍

[trjExpensify]

Cool, thanks for confirming. Settled up with @niravkakadiya25. Closing!

[sophiepintoraetz]

@trjExpensify @s77rt @jscardona12 - callstack suggested the PR caused this regression - mind taking a look and confirming? If so, I'll hand it over to the contributors to fix.

[s77rt]

@sophiepintoraetz Probably unrelated. That issue was reported to be reproducible in 1.3.52 but the PR targeting this issue was only deployed in 1.3.53.

FWIW I can't reproduce the linked issue.

[trjExpensify]

Hm, not sure if they are related on a first look, but @s77rt @cubuspl42 @jscardona12 might have a better idea!

[trjExpensify]

^^ shoulda' refreshed. 😂

[jscardona12]

Hi, I agree with @s77rt, and from my side is also not reproducible.

[trjExpensify]

Cool, @sophiepintoraetz I'm re-closing this done issue and will leave that new bug report up to yah to deal with.

[sophiepintoraetz]

Thanks @trjExpensify and @s77rt for the confirmation!