#20709: Use windowHeight in getNavigationModalCardStyles #23222

jscardona12 · 2023-07-19T23:57:28Z

Details

pass the windowHeight to the new navigationModalCard implementation in App/src/styles
/styles.js. , and apply it to the height property.

This would be re-applying the fix on this PR with previous fix
to the new implementation.

Fixed Issues

$ #20709
PROPOSAL: #20709 (comment)

Tests

First Scenario

Download the New Expensify app for the Smart Banner to appear.
Open in safari iOS the and navigate to newDot home.
Open settings clicking on profiles avatar
Scroll down
Sign out option should be visible and easily clickable.

Second Scenario

Download the New Expensify app for the Smart Banner to appear.
Open in safari iOS the and navigate to newDot home.
Open settings clicking on profiles avatar
Click on Workspaces
New workspace button should be fully visible and easily clickable

Verify that no errors appear in the JS console

Offline tests

QA Steps

First Scenario

Download the New Expensify app for the Smart Banner to appear.
Open in safari iOS the and navigate to newDot home.
Open settings clicking on profiles avatar
Scroll down
Sign out option should be visible and easily clickable.

Second Scenario

Download the New Expensify app for the Smart Banner to appear.
Open in safari iOS the and navigate to newDot home.
Open settings clicking on profiles avatar
Click on Workspaces
New workspace button should be fully visible and easily clickable

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

This just happens in Mobile Web - Safari

Web

Screen.Recording.2023-07-20.at.6.29.26.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-20.at.6.57.21.AM.mov

Mobile Web - Safari

withSolution.mp4

Desktop

Screen.Recording.2023-07-20.at.7.01.44.AM.mov

iOS

WhatsApp.Video.2023-07-20.at.6.41.12.AM.mp4

Android

Screen.Recording.2023-07-20.at.6.52.30.AM.mov

melvin-bot · 2023-07-19T23:57:32Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-07-19T23:57:46Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

src/libs/Navigation/AppNavigator/AuthScreens.js

src/styles/styles.js

s77rt · 2023-07-20T09:02:56Z

@jscardona12 Please consider the following:

Clear up the Details section
Add Tests
Add screenshots/videos for all platforms
Recheck the checklist (it's seems a bit messed up)

s77rt · 2023-07-20T09:04:12Z

Also please change the title to be more explanatory. It's a bit unclear.

jscardona12 · 2023-07-20T12:22:11Z

Hi @s77rt, code changes made and tested. and PR description comments applied as well.

s77rt · 2023-07-20T15:26:04Z

src/styles/getNavigationModalCardStyles/index.website.js

@@ -8,4 +8,5 @@ export default ({windowHeight, isSmallScreenWidth}) => ({
    // https://github.com/Expensify/App/issues/12005
    // https://github.com/Expensify/App/issues/17824


Can you add a link to the issue we are fixing as well

s77rt · 2023-07-20T15:30:42Z

Can you change the title to: Use windowHeight in getNavigationModalCardStyles

jscardona12 · 2023-07-20T15:39:16Z

@s77rt done

src/styles/getNavigationModalCardStyles/index.website.js

…fyJuanC into hotfix/20709

jscardona12 · 2023-07-20T18:19:18Z

@s77rt index.js added

jscardona12 · 2023-07-20T18:30:43Z

I have read the CLA Document and I hereby sign the CLA

s77rt · 2023-07-20T18:32:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt

LGTM! 🚀

s77rt · 2023-07-20T18:39:32Z

@jscardona12 Oops, we have a lint issue, please run prettier and commit changes

jscardona12 · 2023-07-20T19:15:30Z

Hi @johnmlee101 @s77rt, prettier run is up now.

OSBotify · 2023-07-21T15:41:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:49:54Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:23:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:12Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-08-15T13:42:45Z

src/styles/getNavigationModalCardStyles/index.website.js

    height: `${windowHeight}px`,
+    minHeight: `${windowHeight}px`,


This caused a regression on Safari where the window height is not reliable.

Expensify#20709: Add windowHeight to height and min-height property

3edfe66

jscardona12 requested a review from a team as a code owner July 19, 2023 23:57

melvin-bot bot removed the request for review from a team July 19, 2023 23:57

melvin-bot bot requested a review from s77rt July 19, 2023 23:57

jscardona12 mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-08-21] [HOLD for #23481] [$1000] mWeb - Sign out - Button hidden under bottom, hard to sign out #20709

Closed

6 tasks

s77rt suggested changes Jul 20, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved

src/styles/styles.js Outdated Show resolved Hide resolved

jscardona12 changed the title ~~#20709: Add windowHeight to height and min-height property~~ #20709: Add windowHeight to height and min-height property in navigationCard to fix signOut and Mew Worspace button being hide out when Smart Banner is visible Jul 20, 2023

20709: Start using again getNavigationModalCardStyle

aa20626

s77rt suggested changes Jul 20, 2023

View reviewed changes

jscardona12 changed the title ~~#20709: Add windowHeight to height and min-height property in navigationModalCard to fix signOut and New workspace button being hide out when Smart Banner is visible~~ #20709: Use windowHeight in getNavigationModalCardStyles Jul 20, 2023

Add issue related url comment

112b61b

s77rt suggested changes Jul 20, 2023

View reviewed changes

src/styles/getNavigationModalCardStyles/index.website.js Show resolved Hide resolved

jscardona12 added 2 commits July 20, 2023 13:01

Add index.js to getNavigationModalCardStyles

f72741f

Merge branch 'hotfix/20709' of https://github.com/jscardona12/Expensi…

510bc8b

…fyJuanC into hotfix/20709

s77rt approved these changes Jul 20, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 July 20, 2023 18:32

johnmlee101 previously approved these changes Jul 20, 2023

View reviewed changes

Run prettier

df683c3

jscardona12 dismissed johnmlee101’s stale review via df683c3 July 20, 2023 19:13

jscardona12 requested a review from johnmlee101 July 21, 2023 14:37

johnmlee101 approved these changes Jul 21, 2023

View reviewed changes

johnmlee101 merged commit c225999 into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

ginsuma mentioned this pull request Aug 1, 2023

[HOLD for payment 2023-08-21] [$250] mWeb - Unresponsive view on 2 factors authentication screen #23481

Closed

6 tasks

pac-guerreiro mentioned this pull request Aug 2, 2023

[$1000] Home address - Blank space between City / Zip input and keyboard #24007

Closed

6 tasks

s77rt reviewed Aug 15, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#20709: Use windowHeight in getNavigationModalCardStyles #23222

#20709: Use windowHeight in getNavigationModalCardStyles #23222

jscardona12 commented Jul 19, 2023 •

edited

Loading

melvin-bot bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023 •

edited

Loading

s77rt commented Jul 20, 2023

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

s77rt Jul 20, 2023

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

s77rt commented Jul 20, 2023

s77rt left a comment

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

s77rt Aug 15, 2023

		@@ -8,4 +8,5 @@ export default ({windowHeight, isSmallScreenWidth}) => ({
		// https://github.com/Expensify/App/issues/12005
		// https://github.com/Expensify/App/issues/17824

#20709: Use windowHeight in getNavigationModalCardStyles #23222

#20709: Use windowHeight in getNavigationModalCardStyles #23222

Conversation

jscardona12 commented Jul 19, 2023 • edited Loading

Details

Fixed Issues

Tests

First Scenario

Second Scenario

Offline tests

QA Steps

First Scenario

Second Scenario

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023 • edited Loading

s77rt commented Jul 20, 2023

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

s77rt Jul 20, 2023

Choose a reason for hiding this comment

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

s77rt commented Jul 20, 2023

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

s77rt commented Jul 20, 2023

jscardona12 commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

s77rt Aug 15, 2023

Choose a reason for hiding this comment

jscardona12 commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading