Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-05-11 #18764

Closed
51 tasks done
OSBotify opened this issue May 11, 2023 · 30 comments
Closed
51 tasks done

Deploy Checklist: New Expensify 2023-05-11 #18764

OSBotify opened this issue May 11, 2023 · 30 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 11, 2023

Release Version: 1.3.13-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 11, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.13-0 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.13-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-1 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.13-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-2 has been deployed to staging 🎉

@Beamanator
Copy link
Contributor

Ok #18486 finallyyy got successfully CP'd to staging, it's in the process of being deployed to all platforms now - https://github.com/Expensify/App/actions/runs/4959306332

@Beamanator
Copy link
Contributor

One more possible CP here: #18788

@mvtglobally
Copy link

@Beamanator We are just wrapping few last PRs in the checklist TR is completed

#18469 is failing #18793
#18485 is failing #18794

@mvtglobally
Copy link

Can you also check #18081 (comment) We are not sure if thats expected now

@Beamanator
Copy link
Contributor

Beamanator commented May 12, 2023

Ok it looks like #18793 (caused by #18469) is being fixed by #18842

@Beamanator
Copy link
Contributor

Can you also check #18081 (comment) We are not sure if thats expected now

For this one, everyone should be on passwordless now so we can check it off, I'm not sure why we still have that passwordless form still anyway 😅

@Beamanator
Copy link
Contributor

For #18794, it shouldn't be related to #18485 so i'm marking that one off 👍

@Beamanator
Copy link
Contributor

Beamanator commented May 12, 2023

Looks like #18840 was made when testing #16750 so i'll check that out now

  • Yeah setting as default works as expected so i'll make sure that one's closed out too!

@Beamanator
Copy link
Contributor

There's no QA steps on this one so i'll check it off: #18778

@Beamanator
Copy link
Contributor

I gotta head out for the day real soon so I asked internally for some help getting this across the line today

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.13-3 🚀

@mvtglobally
Copy link

mvtglobally commented May 12, 2023

@Beamanator
#16750 is failing #18840 repro in PROD. checking off
#18328 is failing #18852. please double check as we cant verify PROD and it is also blocked on Native aps due to Account list for New Chat or Request money is not displayed while offline
#18466 is failing on Android with #17368 (comment). checking off

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-3 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.13-4 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-4 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.13-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.13-5 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

Checking off the deploy blockers and PRs, confirmed it was fixed in staging

@mountiny
Copy link
Contributor

Checking off #18469 since #18793 has been cped to staging to fix the discovered issue

@mountiny
Copy link
Contributor

Checking off #18486 as follow up issue is not a deploy blocker and handled by contributors

@mountiny
Copy link
Contributor

Checking this of #18328 since the linked issues are not blockers

@mountiny
Copy link
Contributor

mountiny commented May 14, 2023

This is ready to deploy on Monday morning, assigning myself to handle this unless someone will do that before me :D

@mountiny mountiny self-assigned this May 14, 2023
@mountiny mountiny added the Daily KSv2 label May 14, 2023
@Beamanator
Copy link
Contributor

Added some thoughts about firebase crashlitics here - https://expensify.slack.com/archives/C07J32337/p1684132624221449?thread_ts=1684026901.091199&cid=C07J32337

I think we can move forward with deploy

@Beamanator
Copy link
Contributor

@mountiny & I agreed we can ship 👍

@Beamanator Beamanator self-assigned this May 15, 2023
@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants