Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Gboard swipe on backspace to delete text doesn’t work properly on message box #18873

Closed
1 of 6 tasks
kavimuru opened this issue May 12, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented May 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat,
  2. Type long text,
  3. Swipe on backspace key back and forth.

Expected Result:

Text selection should change according to backspace swipe and selected text should be deleted

Actual Result:

Text selection freezes while adjusting swipe length and text isn’t deleted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Swipe.mp4
az_recorder_20230512_172450.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nishan-Chhetri
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683868631422409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ab890488ee034d1
  • Upwork Job ID: 1660646653359689728
  • Last Price Increase: 2023-05-22
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sonialiap
Copy link
Contributor

will triage tomorrow

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 16, 2023
@sonialiap
Copy link
Contributor

I can reproduce this bug on an android device

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@sonialiap sonialiap added the External Added to denote the issue can be worked on by a contributor label May 22, 2023
@melvin-bot melvin-bot bot changed the title Gboard swipe on backspace to delete text doesn’t work properly on message box [$1000] Gboard swipe on backspace to delete text doesn’t work properly on message box May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016ab890488ee034d1

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@naveensingh
Copy link

naveensingh commented May 24, 2023

This bug is very similar to #8349 and is resolved by an existing RN pull request Expensify/react-native#55.
I have tested the fix and can confirm that it works as expected. There are no other changes required.

@pecanoro
Copy link
Contributor

Two totally unrelated comments:

  • I didn't even know you could do that on Android and I had Android phones for more than 15 years 😄
  • I completely agree it's extremely similar and the fact that this was proposed to be fixed in RN before even this was reported, I am going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants