[Ready for payment via newdot][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat

[kidroca]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation
2. Type anything in compose box
3. Select it

Expected Result:

Native menu to cut / copy / paste should be displayed

Actual Result:

Native menu to cut / copy / paste is not displayed or displayed for a second and then hidden

Workaround:

User is unable to cut / copy / paste text in the compose box.
Selecting a word/text and then long tapping on another word seems to bring the context menu with copy/cut/paste actions

Additional details

This comment from the previous ticket summarizes what we have found out and tried so far.

We've identified using the selection prop works as expected in iOS, but does not work as expected on Android, resulting in the reported bug.

We're looking for identifying the problem in react-native and proposing a fix
Once a proposal is approved a contributor would be hired to submit a PR against our react-native fork: https://github.com/Expensify/react-native

We're not looking for a workaround solution that

• uses platform specific code e.g. handling selection differently in Composer/index.android|ios|web.js files
• uses setTimeout, setImmediate or requestAnimationFrame

Platform:

Where is this issue occurring?

• Android

Version Number: v1.1.46-3
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2021-12-22.at.11.37.59.AM.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640179428463500
Previous ticket: #6876

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kidroca]

Created as continuation for: #6876 (comment)

cc @mallenexpensify @parasharrajat @rushatgabhane @stitesExpensify

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[greg-schroeder]

I reproduced this one so sending to my friends in Eng

[Julesssss]

I assigned @parasharrajat and made the issue the same price as the original, as this is not a simple fix.

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NicMendonca]

Upwork job post: https://www.upwork.com/jobs/~0191b930fd2b38bae8

[melvin-bot]

Current assignee @parasharrajat is eligible for the Exported assigner, not assigning anyone new.

[melvin-bot]

Current assignee @Julesssss is eligible for the Exported assigner, not assigning anyone new.

[hannojg]

Pardon, we do have an issue for the RN 0.72 upgrade:

• [HOLD for payment 2023-08-14] Update App to React native 0.72 version #18444

Seems like for RN 0.72 we will still use the fork. We can hold this issue for the one named above (Version 0.72 includes the fix for this issue)

[Julesssss]

Updated the hold, thanks!

[parasharrajat]

RN version upgrade in progress.

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @parasharrajat, @kadiealexander eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[janicduplessis]

RN upgrade is done so this should be solved I think

[parasharrajat]

Yes, I was waiting on the RN version upgrade to be deployed to PROD which is done yesterday. It is resolved now. We can process the payments for this issue now @kadiealexander

[kadiealexander]

@mallenexpensify I'm struggling a little with working out who needs to be paid and how much here, and I see you were intending on taking this over in this comment. Could you please help me make sense of the payments needed here?

[kadiealexander]

@parasharrajat could you please help me by summarising who needs to be paid with this issue?

It seems like it's just you that is due a reporting bonus? Am I missing anything?

[parasharrajat]

Sure @kadiealexander.

Here is the summary.

1. Reporting: @parasharrajat

2. C+: @parasharrajat This does involve C+ payment as there have been 2 issues and about 3 lengthy PRs for this issue before we found a purely native solution. This issue is a continuation of old issues which we closed to change the perspective.

3. Contributor: @hannojg & @janicduplessis [Ready for payment via newdot][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat #8349 (comment)

4. Apart from it, I think @kidroca also presented conclusive evidence of the solution and was involved in research a long time back around August 2022. Not sure if they are already paid as they were being paid hourly earlier.

Both Contributors were involved. I don't know if both are linked to the same agency or different. As Agency payments are handled separately, I think it is already managed.

[kadiealexander]

@parasharrajat could you please link all the related PRs and issues here? This is a big payment and it's not a simple 1 PR = 1 payment issue like usual, so I really want to ensure I understand what happened.

[parasharrajat]

Sure.

Related issues and PR.

3. This issue, Main PR perf: fix (comment) input performance  #11684

4. Issue [$1000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat  #6876 PR Fix android copy paste menu doens't show up in compose box #7717 , PR Fix Android text selection context menu (copy, paste) #7815

5. Issue [HOLD for payment 2022-09-07] [$2000] IOU - User is unable to modify the IOU amount - Reported by: @Santhosh-Sellavel  #6154, PR Added ability to modify IOU Amount #7433

6. PR Composer: Control selection using setSelection #17687, We closed this in favor of this issue.

7. PR fix(android): selection menu missing controlled textinput react-native#50

8. PR Fix and simplify controlled text selection on Android react-native#55

9. This issue, Main PR perf: fix (comment) input performance  #11684

10. Slack discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1645191589301989. I might be missing a few.

11. Now, the Agency team has been working on upgrading many libs internally to upgrade the RN version to the latest and enable new architecture. Those all issues are handled separately but required before we could merge the final solution in our app.

These are the main issues and PR which I remember but I think there have been more in the past which we closed.

I have been involved directly or indirectly in all of these PRs where I have run tests from time to time and tracked them.

[hannojg]

There is also this issue which should be fixed now:

• [HOLD setSelection refactor] [$2000] Android - Cursor is placed in wrong position after write/paste the emoji between the word Hello and nice - Reported by: @AndreasBBS #12854

[kadiealexander]

Payouts due:

• Issue Reporter: $250 @parasharrajat
• Contributor: n/a, handled by expert contributors
• Contributor+: $16000 @parasharrajat

Eligible for 50% #urgency bonus? No

All payments to be paid via Newdot.

[Julesssss]

Hi @kadiealexander, that seems reasonable to me but maybe we should just check in with @kidroca to confirm?

Apart from it, I think @kidroca also presented conclusive evidence of the solution and was involved in research a long time back around August 2022. Not sure if they are already paid as they were being paid hourly earlier.

[kidroca]

Hey @Julesssss, @kadiealexander,

Thanks for reaching out and considering my contributions. While I did invest time in research and provided insights, I wasn't tracking my hours as I was aiming for the fixed price job. I remember highlighting that the issue might naturally resolve with our migration to the new architecture. However, I'm aware that the solution wasn't as straightforward and there were overlaps with other issues.

Ultimately, the main work was carried out by another contributor. I genuinely appreciate the acknowledgment, but I'm not seeking any compensation for this. It's challenging to measure the exact impact of my input, and I'm just glad I could assist in some way.

Best,
@kidroca

[kadiealexander]

Thank you @kidroca!! That's very generous of you to be willing to share your expertise with us like that.

In that case @parasharrajat if you could please request your portion via newdot we should be good here. Thanks to everyone who worked on this!

[parasharrajat]

Payment requested.

[JmillsExpensify]

Reviewed the details for @parasharrajat. Approved for payment in NewDot based on the BZ summary above.