fix(android): selection menu missing controlled textinput #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to trace the code and understand the impact of change. Though, RN codebase complexity is very high so my odds are less 😄 |
|
Responsible commit hannojg@29f3f55 |
|
@hannojg can you update this to target Expensify-0.71.2-alpha.3 ? |
hannojg
force-pushed
the
fix-android-selection-menu-missing
branch
from
ff9ae72
to
0140b4f
Compare
|
@roryabraham updated! |
|
There is a problem from this solution as per the upstream PR. |
|
Closed in favour of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR Link
Summary
This PR solves this bug:
So the bug wasn't a bug caused by Expensify App code, but was really a native bug that existed within react native.
Changelog
[ANDROID] [FIXED] - Selection menu missing when TextInput uses controlled selection prop
Test Plan
Manually test text inputs