[HOLD for payment 2023-06-07] [$1000] Center QR image turns into difference avatar for a moment after being removed.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login app in 2 tabs.
2. From the first tab open Share QR image, from second tab, try to remove the user avatar.
3. Observe the center Qr image.

Expected Result:

Center QR image should turn into default avatar.

Actual Result:

Center QR image turns into difference avatar for a moment after being removed.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.22.07.57.mov

Recording.646.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684249640364239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e69cb0f1402572c0
• Upwork Job ID: 1659379434933579776
• Last Price Increase: 2023-05-19

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Center QR image turns into difference avatar for a moment after being removed

What is the root cause of that problem?

When we delete user avatar, we set optimisticData of user's avatar to oldDot default avatar (e.i: https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/avatar_4.png).

App/src/libs/actions/PersonalDetails.js

Line 376 in 2090c05

const defaultAvatar = ReportUtils.getOldDotDefaultAvatar(currentUserEmail);

Later on, the API returns default avatar with newDot (e.i: https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_4.png)

In ShareCodePage, we're using this.props.currentUserPersonalDetails.avatar to generate QR code, which uses above value directly => it explains why we see the oldDot avatar in QR code for a moment then see newDot avatar.

What changes do you think we should make in order to solve the problem?

We can't reuse the util ReportUtils.getAvatar like other places. Because it will return a SVG component if the current avatar is the default one. QRCode library expect a string of URL not a React component.
So we can make another ReportUtils.getAvatarUrl same as ReportUtils.getAvatar but it returns a newDot default URL instead of SVG component when it's a default avatar.

The function to get newDot default URL is almost same with oldDot. But instead of avatar_${loginHashBucket}.png, it should be default-avatar_${loginHashBucket}.png

What alternative solutions did you explore? (Optional)

Instead of use oldDot default avatar, we can use newDot default avatar for optimisticData, because later on, the API still return the newDot default avatar. So it doesn't make sense to use oldDot default avatar anymore => Write a new util ReportUtils.getNewDotDefaultAvatar same as oldDot, but return with prefix default- (I.e default-avatar_4.png)

App/src/libs/actions/PersonalDetails.js

Line 376 in 2090c05

const defaultAvatar = ReportUtils.getOldDotDefaultAvatar(currentUserEmail);

[kadiealexander]

Reproduced in Chrome:

2023-05-19_14-03-36.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e69cb0f1402572c0

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[fedirjh]

Hey @hoangzinh thanks for the proposal . I wonder if we can achieve the same result as the chat avatars , check my video below , the avatar in the chat doesn’t change to oldDot default avatar .

Avatar.mov

[hoangzinh]

@fedirjh I thought about it too. For other place, we usually use this util to get avatar ReportUtils.getAvatar, it will return an SVG image if it's default avatar. I have tried for QR code, but it's expecting a image URL/number.

[fedirjh]

@hoangzinh QR code accept base64 strings , so we can convert the Svg to base64. Anyway I think we have a simpler option.

@grgia Is there any specific reason that we keep using the oldDot default avatar ? Can we update getOldDotDefaultAvatar to return the newDot default avatar ? specifically this line

App/src/libs/ReportUtils.js

Line 686 in 2090c05

return `${CONST.CLOUDFRONT_URL}/images/avatars/avatar_${loginHashBucket}.png`;

Could be update to :

    return `${CONST.CLOUDFRONT_URL}/images/avatars/default-avatar_${loginHashBucket}.png`;

[tgolen]

I think we can go ahead and make that update. I don't think there is any reason to keep using the old avatar.

[grgia]

The old avatar is required in order to update the avatar only on both Old and New Dot. On Old dot we do not use our new default avatar designs

[grgia]

To illustrate:

vs

To support both platforms, we set the default avatar URL for Old Expensify whereas in New Expensify we calculate which one to show at render

[hoangzinh]

@grgia I think it makes sense if we store default avatar URL of oldDot in BE, so it works for both oldDot and newDot. But from what I observe:

• We set optimisticData in newDot with old default avatar. But after that, BE API returns new default avatar
  => Does that mean BE is storing with new default avatar?
• Another interesting thing is, atm, if we remove the avatar for an user then login to oldDot, we are see new default avatar.
  

[fedirjh]

I think it makes sense if we store default avatar URL of oldDot in BE, so it works for both oldDot and newDot.

I agree with this point, getOldDotDefaultAvatar is used to set defaultAvatar optimistically. The request sent from newDot doesn’t include the oldDot default avatar

oldDat	newDot

Another interesting thing is, atm, if we remove the avatar for an user then login to oldDot, we are see new default avatar.

I can confirm the same thing , It looks this should be fixed in the BE as the new avatar is displayed on oldDot

[tgolen]

OK, what updates to the proposal need to be made? Is it just a matter of changing the reference in the optimistic data?

[grgia]

The problem is in /src/pages/ShareCodePage.js

                            logo={isReport ? roomAvatar : this.props.currentUserPersonalDetails.avatar}

we should be using ReportUtils.getAvatar( ... ) here instead of this.props.currentUserPersonalDetails.avatar

[fedirjh]

we should be using ReportUtils.getAvatar( ... ) here instead of this.props.currentUserPersonalDetails.avatar

We discussed that solution in #19211 (comment) , ReportUtils.getAvatar may return String/Function however react-native-qrcode-svg only accepts String/Number

@hoangzinh, can we implement a new function similar to ReportUtils.getAvatar, but instead of returning an SVG component, it returns a URL?

[hoangzinh]

@fedirjh definitely we can. I have updated my proposal to reflect above thing.

[melvin-bot]

📣 @hoangzinh You have been assigned to this job by @kadiealexander!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kadiealexander]

@tgolen the assigned engineer assigns in Github, that doesn't need to wait for me. I'll ensure the Upwork contracts get sent and everyone gets paid 😊

[tgolen]

Cool, I didn't know about that. I'll try to remember it in the future. Thanks!

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @danieldoglas (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

Unfortunately, I need to reassign this due to going on extended leave.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix QR image show OldDot avatar for a moment after profile avatar being removed #19521

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Assigned - May 25th 2:50pm (GMT+12) - Thursday
Merged - May 29th 5:32pm (GMT+12) - Monday

PR was merged within 3 business days, eligible for speed bonus.

[kadiealexander]

Contracts sent to all, @fedirjh please don't forget about the checklist!

[fedirjh]

• Link to the PR: Feat: Share QR Code #18636
• Link to comment: Feat: Share QR Code #18636 (comment)
• Link to discussion: N/A , This looks an edge case , testing different scenario would help catch this bug earlier (well for this case it doesn’t look like a realistic test case). I don't think we have anything to add to the current checklist. Let me know if we should create a discussion thread for that.
• Regression Test: N/A This is an edge case where user has to open the same page on two different devices simultaneously and then tries to remove avatar. Doesn’t looks like a realistic test case.

[kadiealexander]

Thanks @fedirjh! Everyone is paid so I'm closing this out. Great work team!