[HOLD for payment 2023-06-07] [$1000] Pencil icon is not appearing in LHN of the Money Request/Owes chat.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Write anything and notice the pencil icon will appear on LHN as soon as the first letter is typed
3. Now go to any chat of Money Request/Owes.
4. Write anything and notice the pencil icon will not appear on LHN as soon as the first letter is typed but if witch to any other chat it will appear
5. Once the Pencil icon appears, it will not remove even if the user deletes the typed information

Expected Result:

Icon should appear on LHN as soon as the first letter is typed in Money Request/Owes chat.

Actual Result:

Icon doesn’t not appear on LHN as soon as the first letter is typed in Money Request/Owes chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.1.mp4

Recording.753.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684821755647069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0132317dd6e85d9c6b
• Upwork Job ID: 1661711412176367616
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Draft icon not appearing in LHN of the Money request / owe chat.

What is the root cause of that problem?

The root cause of the issue is that we're not re-rendering the SidebarList component if the report type is IOU. This can be seen here.

What changes do you think we should make in order to solve the problem?

I think we can remove this check.

What alternative solutions did you explore? (Optional)

We can also just re-render the IOU report if there is a change in the draft property ie this changes to:

if (ReportUtils.isIOUReport(report)) {
        return {
            hasDraft: report.hasDraft
        };
    }

I prefer the former approach more because IMO IOU reports are more and more becoming like chat reports.

[bfitzexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0132317dd6e85d9c6b

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @yuwenmemon (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@allroundexperts 's proposal looks good to me. Now are creating reports for iOUs so it makes sense to render those as well.

cc: @yuwenmemon

🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @allroundexperts You have been assigned to this job by @yuwenmemon!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allroundexperts]

PR created #19644

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: allow chatReportSelector to return the object for IOU reports #19644

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @allroundexperts] Determine if we should create a regression test for this bug.
• [@parasharrajat / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bfitzexpensify]

Hey @anmurali - I'm heading OOO this week. I've sent out offers to @allroundexperts @parasharrajat @usmantariq96 (including the $500 bonus for this being merged within 3 days of assignment).

Assuming there are no regressions, this one will need payment in a couple of days so assigning a BZ buddy. Thank you for the help!

[usmantariq96]

@bfitzexpensify applied

[parasharrajat]

Regression Test Steps

1. Open the app (any platform).
2. Create an IOU request of any type. This redirects you to the chat report page with the user for whom the request is meant for.
3. Click on the IOU preview component that appears in the chat. It will open a new report for that particular IOU.
4. Write anything in the composer and verify that the draft icon appears for that chat in the Left-hand navigation list.
5. Remove the draft from the composer, verify that the pencil icon is removed.

Do you agree 👍 or 👎 ?

[parasharrajat]

[@parasharrajat / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR: #18604
[@parasharrajat / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #18604 (comment)
[@parasharrajat / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1686013235502849

[@parasharrajat / @allroundexperts] Determine if we should create a regression test for this bug. Yes
[@parasharrajat / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #19570 (comment)

[parasharrajat]

So PR causing this issue should be the one that implemented the IOU reports in LHN. Although the issue originated from https://github.com/allroundexperts/Expensify/blob/8f01fcc29af7767670ea9b75228a27855f6710f3/src/pages/home/sidebar/SidebarLinks.js#L222-L224 , At that time we didn't show IOU reports in LHN and thus there was no possibility of this bug.

@allroundexperts Do you know which PR added the IOU reports as chats? I couldn't figure the exact one.

[yuwenmemon]

@allroundexperts bump!

[allroundexperts]

Sorry, checking now.

[allroundexperts]

@parasharrajat I think its this PR.

[parasharrajat]

Ok, Thanks. It might be the one. For now, I have updated the checklist to have this but we might be wrong at pin-pointing the exact PR. It's fine.

cc: @anmurali

[bfitzexpensify]

All payments issued and contracts ended

[bfitzexpensify]

Testrail update here https://github.com/Expensify/Expensify/issues/291254

[bfitzexpensify]

Think we're all done here. Thanks for the work everyone!