[PAID] [$1000] recovery code cut from bottom

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to settings > Security > Two factor Authentication

Expected Result:

recovery code should not cut from bottom

Actual Result:

some recovery code font(like g, j) cut from bottom

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684822389953109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf08b4ce365db968
• Upwork Job ID: 1661828618471395328
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

recovery code cut from bottom

What is the root cause of that problem?

We are setting the height of the Text in here which caused the issue

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Lines 85 to 88 in 4d6a25f

	_.map(props.account.recoveryCodes.split(', '), (code) => (
	<Text
	style={styles.twoFactorAuthCode}
	key={code}

App/src/styles/styles.js

Lines 2141 to 2146 in 4d6a25f

	twoFactorAuthCode: {
	fontFamily: fontFamily.MONOSPACE,
	width: 100,
	height: 18,
	textAlign: 'center',
	},

What changes do you think we should make in order to solve the problem?

Due to difference dimensions screens, that's bad idea to fix height for a text.
We should remove the height of the text, or remove the height with minHeight that will fix the issue:

    twoFactorAuthCode: {
        fontFamily: fontFamily.MONOSPACE,
        width: 100,
       minHeight: 18 // or we can remove it as well
       // height: 18,
        textAlign: 'center',
    },

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

recovery code text cuts from bottom

What is the root cause of that problem?

Default font size is 15 and the line height is 20, giving a height of 18px for the Text is the conflict and causing this issue.

What changes do you think we should make in order to solve the problem?

We can remove the height given to the text from here so it will take the required 20px default lineheight for the font size of 15px.

App/src/styles/styles.js

Line 2144 in 6c7d479

height: 18,

Or we can change the lineHeight to 18 for this and reduce the font-size which fit with the same line height, maybe 14px.

[strepanier03]

I'm able to recreate this easily on a test account on Android Native, sending on.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf08b4ce365db968

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MrJithil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Two Factor Auth Code showing inside the Two Factor Auth Codes Container is showing text cut on some devices.

What is the root cause of that problem?

The lineHeight inheriting from the Text component is causing lower lineHeight because of a condition inside the Text component. This is because, there is no lineHeight mentioned in the CodesPage component for the codes displaying, and so some wrong calculation of lineHeight being applied.

The line height is being set from below:

if (!componentStyle.lineHeight && componentStyle.fontSize === variables.fontSizeNormal) {
        componentStyle.lineHeight = variables.fontSizeNormalHeight;
}

What changes do you think we should make in order to solve the problem?

We need to set the line height from the CodesPage component for the codes being displayed. So, the better way is to define the lineHeight in the twoFactorAuthCode of styles.js. The important thing is we need to use getValueUsingPixelRatio(20, 28) for avoiding lineHeight calculation.

So, the code will be lineHeight: variables.fontSizeNormalHeight , because the variables.fontSizeNormalHeight is using getValueUsingPixelRatio(20, 28) for calculating the height values.

What alternative solutions did you explore? (Optional)

• Reducing the height of the code (text field) values
• Increasing the lineHeight using static values

[abdulrahuman5196]

Thanks everyone for the proposals.

@hungvu193 proposal here - #19571 (comment) is good. We can remove the height. Proposal is working fine on other platforms as well

🎀👀🎀
C+ Reviewed

cc: @johnmlee101

[melvin-bot]

@johnmlee101, @strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abdulrahuman5196]

@johnmlee101 Gentle ping to check on the above #19571 (comment)

[johnmlee101]

I was OOO. Looking now

[melvin-bot]

📣 @hungvu193 You have been assigned to this job by @johnmlee101!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hungvu193]

Thanks. I'll raise a PR in next hour!

[hungvu193]

@johnmlee101 @abdulrahuman5196 #19822 is ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix recovery code cut from bottom #19822

If no regressions arise, payment will be issued on 2023-06-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @gadhiyamanan - $250
• Contributor that fixed the issue - @hungvu193 - $1000 + $500 (speed bonus) = $1500
• Contributor+ that helped on the issue and/or PR - @abdulrahuman5196 - $1000 + $500 (speed bonus) = $1500

Speed assessment bonus: Contributor hired on May 30 / PR merged on May 31 = Eligible for bonus

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR: feat: add 2-factor authentication #18576 During implementation itself this bug was present
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: feat: add 2-factor authentication #18576 (comment)
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.: No
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.: N/A
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[abdulrahuman5196]

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR:

#18576
During implementation itself this bug was present

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#18576 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Very minor UI bug. I don't think a regression test would be beneficial for this.

[strepanier03]

I've updated the checklist and hired @abdulrahuman5196 and @hungvu193 to the job in Upwork.

@gadhiyamanan - I created a reporting job and hired you as well!

Will circle back tomorrow when the hold is removed.

[strepanier03]

I've paid everyone, ended contracts, and left feedback.

Thank you for working so hard to fix this and move it forward quickly. 🎉