[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

kavimuru · 2023-05-25T12:04:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to android
Go to any chat
Send just emoji
Now edit the message and add one more emoji and save it (Do not add any text)
Notice that the top part of the emoji message is totally cut off

Expected Result:

The top part of emoji should not be cut off on editing the emoji message

Actual Result:

The top part of the emoji is cut off on editing the emoji message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.18-1
Reproducible in staging?: y
**Reproducible in production?:**n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

emoji.mp4

az_recorder_20230525_080215.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685014708492129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014c149c7f2dfb4aae
Upwork Job ID: 1661744463659536384
Last Price Increase: 2023-05-25

melvin-bot · 2023-05-25T12:05:00Z

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-05-25T12:05:02Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-05-25T12:06:39Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-05-25T12:06:43Z

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

lschurr · 2023-05-25T14:36:13Z

@cristipaval - does this need to go through the typical Bug Zero process? Should I be testing and adding External or is this an Internal fix?

cristipaval · 2023-05-25T14:37:18Z

Hmm.. it looks like this is a deploy blocker. Let me triage this one.

cristipaval · 2023-05-25T14:41:53Z

This also happens in production 1.3.17-5
Not a deploy blocker, so making it external.

melvin-bot · 2023-05-25T14:42:11Z

Job added to Upwork: https://www.upwork.com/jobs/~014c149c7f2dfb4aae

melvin-bot · 2023-05-25T14:42:13Z

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-05-25T14:42:18Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

melvin-bot · 2023-05-25T14:42:21Z

Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new.

kushu7 · 2023-05-25T17:59:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Editing just emoji on a chat cuts the top part on android

What is the root cause of that problem?

Its happening because space between message and edited text.

App/src/pages/home/report/ReportActionItemFragment.js

Lines 126 to 131 in fe67d69

    
           <Text 
        
               selectable={false} 
        
               style={[styles.w1, styles.userSelectNone]} 
        
           > 
        
               {' '} 
        
           </Text>

We are not providing fontSize or lineHeight to it. so its uses default variables.fontSizeNormalHeight depends on metrics. if its smaller than styles.onlyEmojisText then we can see kind of behavior.

What changes do you think we should make in order to solve the problem?

We have 2 ways to fix it. first is we can provide same fontSize as its parent:

1st option:

App/src/pages/home/report/ReportActionItemFragment.js

Line 122 in fe67d69

fontSize={variables.fontSizeSmall}

 <Text
    fontSize={variables.fontSizeSmall} <-- add this
    selectable={false}
    ...
>
    {' '}
</Text>

2nd Option
If we want to keep spacing of fontSizeNormal then we can provide lineHeight to styles of Space Text same as onlyEmojisText.lineHeight only when EmojiUtils.containsOnlyEmojis(text) is true.

IMO, 2nd option is good it will keep same spacing between edited and message.

Screenshot

What alternative solutions did you explore? (Optional)

None

AlexanderDmitriev · 2023-05-25T18:47:21Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Editing just emoji on a chat cuts the top part on android

What is the root cause of that problem?

Space between emojis and (edited) was problem

App/src/pages/home/report/ReportActionItemFragment.js

Lines 126 to 131 in fe67d69

    
           <Text 
        
               selectable={false} 
        
               style={[styles.w1, styles.userSelectNone]} 
        
           > 
        
               {' '} 
        
           </Text>

What changes do you think we should make in order to solve the problem?

Remove the Text element for space and add space like this:

                {Boolean(props.fragment.isEdited) && (
                    <Text
                        fontSize={variables.fontSizeSmall}
                        color={themeColors.textSupporting}
                        style={[styles.alignItemsBaseline, editedLabelStyles]}
                    >
                        {` ${props.translate('reportActionCompose.edited')}`}
                    </Text>
                )}

What alternative solutions did you explore? (Optional)

N/A

qasimkhan23 · 2023-05-26T07:48:02Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Editing just emoji on a chat cuts the top part on android

What is the root cause of that problem?

The provided space between the emoticon and the edited text
https://github.com/Expensify/App/blob/0f1188de4d7b69ecb2b16485e9f03d92f54afe84/src/pages/home/report/ReportActionItemFragment.js#L124C5-L139

                    {Boolean(props.fragment.isEdited) && (
                        <Text
                            fontSize={variables.fontSizeSmall}
                            color={themeColors.textSupporting}
                            style={[styles.alignItemsBaseline, editedLabelStyles]}
                        >
                            <Text
                                selectable={false}
                                style={[styles.w1, styles.userSelectNone]}
                            >
                                {' '}
                            </Text>
                            {props.translate('reportActionCompose.edited')}
                        </Text>
                    )}
                </Text>

What changes do you think we should make in order to solve the problem?

The simple solution is mentioned below, no need to add extra <Text> component.

                {Boolean(props.fragment.isEdited) && (
                    <Text
                        fontSize={variables.fontSizeSmall}
                        color={themeColors.textSupporting}
                        style={[styles.alignItemsBaseline, editedLabelStyles]}
                    >
                        {` ${props.translate('reportActionCompose.edited')}`}
                    </Text>
                )}

mananjadhav · 2023-05-31T05:08:06Z

Thanks for the ping @kushu7. @cristipaval will get it checked. No action needed from your end.

laurenreidexpensify · 2023-06-05T09:59:14Z

@lschurr heads up for payment it looks like @pubudu-ranasinghe actually reported this issue on 22 May - see https://expensify.slack.com/archives/C049HHMV9SM/p1684775756347189 - which led to the creation of this #20083, which is a dupe of this. Can we please compensate @pubudu-ranasinghe $250 for the bonus here too, as well as @priya-zha as this was our error. Thanks

melvin-bot · 2023-06-05T18:49:09Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-06-05T18:49:10Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix editing just emoji cuts top part android #19798

If no regressions arise, payment will be issued on 2023-06-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-06-05T18:49:11Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/291734

lschurr · 2023-06-08T21:35:25Z

@pubudu-ranasinghe @priya-zha @mananjadhav @kushu7 - can you apply for the job in Upwork? https://www.upwork.com/jobs/~014c149c7f2dfb4aae

kushu7 · 2023-06-08T23:19:09Z

@pubudu-ranasinghe @priya-zha @mananjadhav @kushu7 - can you apply for the job in Upwork? https://www.upwork.com/jobs/~014c149c7f2dfb4aae

@lschurr applied 👍

priya-zha · 2023-06-09T03:28:14Z

Submitted the proposal. Thanks.

mananjadhav · 2023-06-09T13:27:33Z

@lschurr The job leads to me a login page, and then after logging in, it doesn't redirect to the job post. Can you please send an invite?

lschurr · 2023-06-09T15:11:04Z

Hmm @mananjadhav try logging in first and then click the job link? https://www.upwork.com/jobs/~014c149c7f2dfb4aae

Otherwise, can you send me your profile and I'll try inviting you

mananjadhav · 2023-06-09T15:29:06Z

@lschurr https://www.upwork.com/freelancers/~01916123f547b928d6 For some reason my session times out every time with Upwork.

mananjadhav · 2023-06-11T22:51:11Z

@lschurr Here's are the items from the checklist.

Offending PR Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523
Commented on the PR https://github.com/Expensify/App/pull/18523/files#r1225946551
I don't think we need any changes in the checklist. This was an edge case which required only emojis to reproduce.
I think it makes sense to add regression test for this one, so that we don't leave out only emojis test during editing the chat. Test steps from the PR look good for the regression test.

lschurr · 2023-06-12T18:02:57Z

@mananjadhav - I sent an invite to the job in Upwork.

@pubudu-ranasinghe please apply to the job in Upwork: https://www.upwork.com/jobs/~014c149c7f2dfb4aae

mananjadhav · 2023-06-13T03:07:44Z

Applied @lschurr. Thank you!

lschurr · 2023-06-13T17:22:41Z

Great, just need @pubudu-ranasinghe to accept the offer in Upwork.

I'll create a GH for a new regression test today.

mananjadhav · 2023-06-13T17:28:18Z

@lschurr this issue is eligible for the timeline bonus. Can you please help with the same?

lschurr · 2023-06-13T17:39:55Z

Ah, yep. Let me apply those bonuses.

lschurr · 2023-06-13T17:40:57Z

Done!

mananjadhav · 2023-06-13T17:51:40Z

Thanks @lschurr for the prompt action!

lschurr · 2023-06-14T15:34:40Z

Done: https://github.com/Expensify/Expensify/issues/291734

kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 25, 2023

melvin-bot bot assigned lschurr May 25, 2023

OSBotify mentioned this issue May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 25, 2023

melvin-bot bot assigned cristipaval May 25, 2023

cristipaval added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels May 25, 2023

melvin-bot bot changed the title ~~Editing just emoji on a chat cuts the top part on android~~ [$1000] Editing just emoji on a chat cuts the top part on android May 25, 2023

cristipaval added the Daily KSv2 label May 25, 2023

melvin-bot bot assigned mananjadhav May 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 25, 2023

cristipaval removed the Hourly KSv2 label May 25, 2023

priya-zha mentioned this issue Jun 3, 2023

Android - Edited emoji messages are clipped and disappearing in Android #20083

Closed

6 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 5, 2023

melvin-bot bot changed the title ~~[$1000] Editing just emoji on a chat cuts the top part on android~~ [HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android Jun 5, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jun 5, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 11, 2023

mananjadhav mentioned this issue Jun 11, 2023

Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523

Merged

56 tasks

lschurr closed this as completed Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

kavimuru commented May 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

OSBotify commented May 25, 2023

melvin-bot bot commented May 25, 2023

lschurr commented May 25, 2023

cristipaval commented May 25, 2023

cristipaval commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

kushu7 commented May 25, 2023 •

edited

Loading

AlexanderDmitriev commented May 25, 2023 •

edited

Loading

qasimkhan23 commented May 26, 2023

mananjadhav commented May 31, 2023

laurenreidexpensify commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023 •

edited by lschurr

Loading

melvin-bot bot commented Jun 5, 2023 •

edited by lschurr

Loading

lschurr commented Jun 8, 2023

kushu7 commented Jun 8, 2023 •

edited

Loading

priya-zha commented Jun 9, 2023

mananjadhav commented Jun 9, 2023

lschurr commented Jun 9, 2023

mananjadhav commented Jun 9, 2023

mananjadhav commented Jun 11, 2023

lschurr commented Jun 12, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 13, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 13, 2023

lschurr commented Jun 13, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 14, 2023

[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

Comments

kavimuru commented May 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented May 25, 2023

melvin-bot bot commented May 25, 2023

lschurr commented May 25, 2023

cristipaval commented May 25, 2023

cristipaval commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

melvin-bot bot commented May 25, 2023

kushu7 commented May 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Screenshot

What alternative solutions did you explore? (Optional)

AlexanderDmitriev commented May 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

qasimkhan23 commented May 26, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mananjadhav commented May 31, 2023

laurenreidexpensify commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023 • edited by lschurr Loading

melvin-bot bot commented Jun 5, 2023 • edited by lschurr Loading

lschurr commented Jun 8, 2023

kushu7 commented Jun 8, 2023 • edited Loading

priya-zha commented Jun 9, 2023

mananjadhav commented Jun 9, 2023

lschurr commented Jun 9, 2023

mananjadhav commented Jun 9, 2023

mananjadhav commented Jun 11, 2023

lschurr commented Jun 12, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 13, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 13, 2023

lschurr commented Jun 13, 2023

mananjadhav commented Jun 13, 2023

lschurr commented Jun 14, 2023

kavimuru commented May 25, 2023 •

edited by melvin-bot bot

Loading

kushu7 commented May 25, 2023 •

edited

Loading

AlexanderDmitriev commented May 25, 2023 •

edited

Loading

melvin-bot bot commented Jun 5, 2023 •

edited by lschurr

Loading

melvin-bot bot commented Jun 5, 2023 •

edited by lschurr

Loading

kushu7 commented Jun 8, 2023 •

edited

Loading