Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523

Ollyws · 2023-05-06T11:23:45Z

Details

Fixed Issues

$ #15194
PROPOSAL: #15194 (comment)

Tests

Navigate to any conversation
Send an message -> Edit that message (make sure it has the (edited) label at end)
Select the message by triple clicking on the message itself
Verify that the message, and not the (edited) label are selected

Verify that no errors appear in the JS console

Offline tests

Navigate to any conversation
Send an message -> Edit that message (make sure it has the (edited) label at end)
Select the message by triple clicking on the message itself
Verify that the message, and not the (edited) label are selected

QA Steps

Navigate to any conversation
Send an message -> Edit that message (make sure it has the (edited) label at end)
Select the message by triple clicking on the message itself
Verify that the message, and not the (edited) label are selected

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

MacOS_Chrome.mp4

Mobile Web - Chrome

Android_Chrome.mp4

Mobile Web - Safari

iOS_Safari.mp4

Desktop

MacOS_Desktop.mp4

iOS

iOS_Native.mp4

Android

Android_Native.mp4

melvin-bot · 2023-05-06T11:23:50Z

@marcochavezf @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-05-07T10:44:50Z

@Ollyws Please change the title and replace #2 with something else. You can use Att# 2.

parasharrajat · 2023-05-07T11:32:32Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-05-02.at.5.01.48.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-05-02.at.4.46.03.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-05-02.at.5.16.27.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-05-02.at.4.47.08.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-05-02.at.5.08.47.PM.mov

🔲 Android / native

parasharrajat · 2023-05-07T11:58:21Z

@Ollyws It seems that this will still cause #18042.

Ollyws · 2023-05-07T12:00:20Z

@parasharrajat Will be fixed by #17781

parasharrajat · 2023-05-08T07:30:46Z

@Ollyws I tried reproducing the #18358 by moving the Mini menu up like the old PR but I couldn't. I am trying to think a way where we can fix the other emoji selection issue as well.

IMO, we can just keep the UnreadIndicator above in the Mini Menu in JSX that should not cause #18358.

Ollyws · 2023-05-08T07:40:49Z

@parasharrajat That issue was fixed by #18228, but it seemed like that PR also got reverted.

parasharrajat · 2023-05-09T16:38:07Z

Thanks for waiting. I will check this as soon as possible. Busy with high-priority issues.

marcochavezf · 2023-05-11T18:37:47Z

Oops another conflict

parasharrajat · 2023-05-15T18:41:00Z

@Ollyws IMO, we can just keep the UnreadIndicator above in the Mini Menu in JSX that should not cause #18358.

Do you think we should attempt that?

Ollyws · 2023-05-15T18:48:15Z

@parasharrajat Yeah seems like #18684 isn't going to fix the copying issues like the original PR did. So we could add the original fixes for that but move it below UnreadIndicator. Shall I remove userSelectNone from the emoji reaction again too?

parasharrajat · 2023-05-15T18:55:26Z

src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js

        >
-            {` ${props.translate('reportActionCompose.edited')}`}
+            {/* Native devices do not support margin between nested text */}
+            <Text style={[styles.w1, styles.userSelectNone]}>{' '}</Text>


Suggested change

<Text style={[styles.w1, styles.userSelectNone]}>{' '}</Text>

<Text selectable={false} style={[styles.w1, styles.userSelectNone]}>{' '}</Text>

Should there be selectable={false}?

@parasharrajat We didn't have it in the original PR, as far as I'm aware it just adds userSelectNone so is redundant in this case.

But this is the proper way so let's add this as well.

parasharrajat · 2023-05-15T18:55:33Z

src/pages/home/report/ReportActionItemFragment.js

+                        color={themeColors.textSupporting}
+                        style={[styles.alignItemsBaseline, editedLabelStyles]}
+                    >
+                        <Text style={[styles.w1, styles.userSelectNone]}>{' '}</Text>


parasharrajat · 2023-05-15T18:56:23Z

Shall I remove userSelectNone from the emoji reaction again too?

Can you please enlighten me on this? Where are we doing this?

Ollyws · 2023-05-15T19:02:12Z

@parasharrajat We have a discussion here in the original PR. But #18228 was reverted and the replacement PR no longer fixes the emoji copy issue.

parasharrajat · 2023-05-15T19:06:07Z

It seems we decided to not do that in that PR so let's follow the same. I wasn't able to reproduce #18358. Can you please test this issue after making MiniMenu adjustments?

Ollyws · 2023-05-15T20:05:19Z

@parasharrajat Ok but the copying of the reaction emoji (underneath the message) will persist.
I can reproduce the issue if we move MiniReportActionContextMenu above the UnreadActionIndicator, but not if we place it below it.

parasharrajat · 2023-05-15T20:11:30Z

So if we keep userSelectNone on emojis then the triple select will select the reactions from the message, and if we remove it then selecting the messages via cursor will select the reactions as well.

Seems like both paths have an issue. IMO, userSelectNone should not be the root cause for triple selection. Did we have this discussion somewhere? Can you please share the link here if any?

What if we refactor the Reaction UI in a way that prevents it from quick selection?

Ollyws · 2023-05-15T20:44:01Z

@parasharrajat

So if we keep userSelectNone on emojis then the triple select will select the reactions from the message, and if we remove it then selecting the messages via cursor will select the reactions as well.

Correct.

The only discussion we had is the one I linked.

What if we refactor the Reaction UI in a way that prevents it from quick selection?

One potential solution is to put an empty View with a height and width of 1px above the EmojiReactionBubbles. It can be positioned absolutely so it doesn't affect the layout.

parasharrajat · 2023-05-16T05:22:46Z

I don't think that is a good idea. Let's not worry about that issue for now. That can be handled separately. Do we have a GH issue for this already?

parasharrajat · 2023-05-16T10:59:52Z

Please update me when changes are done.

Ollyws · 2023-05-16T11:12:38Z

@parasharrajat Updated. Prettier also made some aesthetic changes to the code.

Ollyws · 2023-05-16T12:00:00Z

@parasharrajat Did you want me to move MiniReportActionContextMenu or should we fix all selection issues seperately?

parasharrajat · 2023-05-16T13:06:53Z

I think we should do MiniMenu change as it is not causing issues.

Ollyws · 2023-05-16T15:18:11Z

@parasharrajat Ok, updated.

marcochavezf · 2023-05-16T17:03:23Z

Conflict issue

parasharrajat · 2023-05-17T16:57:13Z

Testing...

parasharrajat

LGTM.

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@marcochavezf

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-05-19T10:07:09Z

bump @marcochavezf

OSBotify · 2023-05-19T18:16:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:50:51Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mvtglobally · 2023-05-24T14:10:29Z

@Ollyws @parasharrajat @marcochavezf Team is still able to repro the issue on Desktop

Screen.Recording.2023-05-23.at.6.23.26.PM.mov

Ollyws · 2023-05-24T15:34:08Z

@mvtglobally Strange, I can't reproduce. It's working fine on mine with the latest main:

norepro.mp4

mvtglobally · 2023-05-24T15:37:20Z

no longer repro on our side as well. Checking it off

parasharrajat · 2023-05-24T16:31:28Z

It might be a browser cache. Happens sometimes.

OSBotify · 2023-05-25T00:22:43Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav · 2023-06-11T22:44:17Z

src/pages/home/report/ReportActionItemFragment.js

-                            {` ${props.translate('reportActionCompose.edited')}`}
+                            <Text
+                                selectable={false}
+                                style={[styles.w1, styles.userSelectNone]}


Because we didn't set a line height for this Text, it caused a regression here.

Ollyws added 3 commits May 6, 2023 12:16

Add dInlineFlex to display

8f36a4b

Created editedLabelStyles

15b4bf6

Added styles to edited label

16d5cf1

Ollyws requested a review from a team as a code owner May 6, 2023 11:23

melvin-bot bot requested review from marcochavezf and parasharrajat and removed request for a team May 6, 2023 11:23

Ollyws changed the title ~~Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message #2~~ Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 May 7, 2023

pubudu-ranasinghe mentioned this pull request May 7, 2023

Fix Edited Line Through Alignment #17781

Merged

56 tasks

Merge branch 'main' into fix2-15194

f5a69c1

sobitneupane mentioned this pull request May 12, 2023

[HOLD for payment 2023-06-07] [$1000] The horizontal line (for deleted message) is not in the center for the text 'edited' but is center for the 'chat messages' on web chrome (offline mode) #17181

Closed

6 tasks

parasharrajat suggested changes May 15, 2023

View reviewed changes

Ollyws added 2 commits May 16, 2023 12:08

Run prettier

3928939

Added selectable prop

0ffaa22

Re-run prettier

fe67d69

Moved MiniReportActionContextMenu to top of View

e56c452

Merge branch 'main' into fix2-15194

dd8c5b4

parasharrajat approved these changes May 18, 2023

View reviewed changes

marcochavezf approved these changes May 19, 2023

View reviewed changes

marcochavezf merged commit 8a3d79c into Expensify:main May 19, 2023

0xmiros mentioned this pull request May 21, 2023

Refactor ReportActionItem to use hooks #18809

Merged

53 tasks

jasperhuangg added a commit that referenced this pull request May 21, 2023

apply changes from #18523

c52ac84

marcochavezf mentioned this pull request May 22, 2023

[HOLD for payment 2023-05-26] [$4000] Web - Triple clicking an edited message select’s the (edited) label along with the actual message #15194

Closed

6 tasks

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

Ollyws deleted the fix2-15194 branch May 30, 2023 14:52

mananjadhav reviewed Jun 11, 2023

View reviewed changes

mananjadhav mentioned this pull request Jun 11, 2023

[HOLD for payment 2023-06-12] [$1000] Editing just emoji on a chat cuts the top part on android #19605

Closed

6 tasks

	<Text style={[styles.w1, styles.userSelectNone]}>{' '}</Text>
	<Text selectable={false} style={[styles.w1, styles.userSelectNone]}>{' '}</Text>

Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523

Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523

Conversation

Ollyws commented May 6, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 6, 2023

parasharrajat commented May 7, 2023

parasharrajat commented May 7, 2023

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented May 7, 2023

Ollyws commented May 7, 2023

parasharrajat commented May 8, 2023 • edited Loading

Ollyws commented May 8, 2023

parasharrajat commented May 9, 2023

marcochavezf commented May 11, 2023

parasharrajat commented May 15, 2023

Ollyws commented May 15, 2023 • edited Loading

parasharrajat May 15, 2023

Choose a reason for hiding this comment

Ollyws May 16, 2023

Choose a reason for hiding this comment

parasharrajat May 16, 2023

Choose a reason for hiding this comment

parasharrajat May 15, 2023

Choose a reason for hiding this comment

parasharrajat commented May 15, 2023

Ollyws commented May 15, 2023 • edited Loading

parasharrajat commented May 15, 2023 • edited Loading

Ollyws commented May 15, 2023

parasharrajat commented May 15, 2023

Ollyws commented May 15, 2023 • edited Loading

parasharrajat commented May 16, 2023

parasharrajat commented May 16, 2023

Ollyws commented May 16, 2023 • edited Loading

Ollyws commented May 16, 2023

parasharrajat commented May 16, 2023

Ollyws commented May 16, 2023

marcochavezf commented May 16, 2023

parasharrajat commented May 17, 2023

parasharrajat left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented May 19, 2023

OSBotify commented May 19, 2023

OSBotify commented May 22, 2023

mvtglobally commented May 24, 2023

Ollyws commented May 24, 2023

mvtglobally commented May 24, 2023

parasharrajat commented May 24, 2023

OSBotify commented May 25, 2023

mananjadhav Jun 11, 2023

Choose a reason for hiding this comment

parasharrajat commented May 8, 2023 •

edited

Loading

Ollyws commented May 15, 2023 •

edited

Loading

Ollyws commented May 15, 2023 •

edited

Loading

parasharrajat commented May 15, 2023 •

edited

Loading

Ollyws commented May 15, 2023 •

edited

Loading

Ollyws commented May 16, 2023 •

edited

Loading

parasharrajat left a comment •

edited

Loading