[HOLD for payment 2023-05-26] [$4000] Web - Triple clicking an edited message select’s the (edited) label along with the actual message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app -> Login in account
2. Navigate to any conversation
3. Send an message -> Edit that message (make sure that has (edited) label at end of statement)
4. Try to select that message by triple clicking on message -> Notice message is selected along with (edited) label

Expected Result:

(edited) label should not get selected

Actual Result:

(edited) label get selected along with message

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.72-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1531.mp4

Screen.Recording.2023-02-15.at.12.13.05.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676445116253349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d2bbf84b58c19ab3
• Upwork Job ID: 1628536904239013888
• Last Price Increase: 2023-03-29

[MelvinBot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d2bbf84b58c19ab3

[MelvinBot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

📣 @MelvinBot! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[kevinksullivan]

Exported with Help wanted applied

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edited text gets selected when message is double clicked along with the actual message.

What is the root cause of that problem?

The edited text is user-selectable by default. As such, the edited text gets copied along with the original message.

What changes do you think we should make in order to solve the problem?

We can disable the userSelect style in the edit tag renderer:
style={{userSelect: 'none'}}

Works well after the fix.

Screen.Recording.2023-02-23.at.4.47.47.AM.mov

What alternative solutions did you explore? (Optional)

None

[dhairyasenjaliya]

Proposal (added along with bug report)

Please re-state the problem that we are trying to solve in this issue.

• Web - Triple-clicking an edited message selects the (edited) label along with the actual message

What is the root cause of that problem?

• Here we don’t differentiate between message and edited label and render components in uniformity thus making text selectable on triple click along with the entire message

What changes do you think we should make in order to solve the problem?

• We are placing edited labels on a 2-page simple message and HTML message

1. EditedRenderer
2. ReportActionItemFragment

• We need to pass selectable false to component on 2 pages

1. EditedRenderer.js
   

   App/src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js

   Line 18 in 731fbd2

   <Text

     <Text
      // eslint-disable-next-line react/jsx-props-no-spreading
      {...defaultRendererProps}
      fontSize={variables.fontSizeSmall}
      color={themeColors.textSupporting}
+      selectable={false} 
    >

2. ReportActionItemFragment.js
   

   App/src/pages/home/report/ReportActionItemFragment.js

   Line 127 in 731fbd2

   {props.fragment.isEdited && (

{props.fragment.isEdited && (
          <Text
            fontSize={variables.fontSizeSmall}
            color={themeColors.textSupporting}
+            selectable={false}
          >
            {` ${props.translate(‘reportActionCompose.edited’)}`}
          </Text>
          )}

What alternative solutions did you explore? (Optional)

• Along with the above change we could add <EditedRenderer> component to ReportActionItemFragment.js seems like that does the same job

Edited Comment

• During the latest test I found one more bug regarding text copy here we should wait until this bug gets resolved since it randomly copies on triple click text https://expensify.slack.com/archives/C049HHMV9SM/p1677122727940939

[getusha]

I believe I reported this issue previously. (Jan 20th)
https://expensify.slack.com/archives/C049HHMV9SM/p1674203776202409

cc @kavimuru

[parasharrajat]

Is this issue happening on all platforms?

Is the Expected Result Correct? Should we completely disable selection on Edited label?

Triage Checklist was not modified so making sure. cc: @kevinksullivan

[kavimuru]

@parasharrajat I have updated the platforms affected.

[parasharrajat]

Thanks, @kavimuru. @kevinksullivan Can you please also confirm the Expected behaviour #15194 (comment).

[kevinksullivan]

Good question actually @parasharrajat . Going to bring to the room before going further.

[marcochavezf]

Last PR has been merged but has not been deployed yet.

[arielgreen]

Merged May 19, updating payment date accordingly.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix for: Triple clicking an edited message select’s the (edited) label along with the actual message Att# 2 #18523

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@arielgreen] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arielgreen]

Reassigning, OOO tomorrow and Monday.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

Just waiting on you @parasharrajat for the contract: https://www.upwork.com/nx/wm/offer/24481238

And the BZ Checklist: #15194 (comment)

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: This was a browser standard behavior so not caused by us.

[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #15194 (comment)

[parasharrajat]

Regression Test Steps

1. Navigate to any conversation
2. Send an message -> Edit that message (make sure it has the (edited) label at end)
3. Select the message by triple-clicking on the message itself.
4. Verify that only the message, and not the (edited) label is selected.

Do you agree 👍 or 👎 ?

[parasharrajat]

@twisterdotcom done.

[melvin-bot]

@marcochavezf, @twisterdotcom, @Ollyws, @parasharrajat, @arielgreen Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Payment sent.

[twisterdotcom]

Test Case addition requested.