[HOLD for payment 2023-08-02] [$1000] IOS - Long Pressing on Attachment in chat history in Safari opens the native image menu

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat on Safari iOS.
2. Send a few image attachments.
3. Long Press any of the sent attachments in chat history.

Expected Result:

Native image menu should be blocked as we have a custom menu.

Actual Result:

Safari opens a native menu over the image which interfere with the custom context menu.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3

Reproducible in staging?:

Reproducible in production?:

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-16.at.1.54.15.PM.mov

RPReplay_Final1687460312.MP4

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686903910528619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012b0bba0a353f1098
• Upwork Job ID: 1672040116386263040
• Last Price Increase: 2023-06-23

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long pressing on attachment in chat history in iOS safari shows the default image menu

What is the root cause of that problem?

This is the default behavior of img elements in iOS safari browser. We didn't disable it yet.

What changes do you think we should make in order to solve the problem?

We have CSS styles for img elements here

App/src/styles/styles.js

Lines 132 to 136 in 2669f79

	img: {
	borderColor: themeColors.border,
	borderRadius: variables.componentBorderRadiusNormal,
	borderWidth: 1,
	},

Add the following CSS

            '-webkit-touch-callout': 'none',

This works as expected

Result

21344_mac_chrome.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012b0bba0a353f1098

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[pauldriggers911]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The long-press behavior on images on iOS safari shows a contextual menu.

What is the root cause of that problem?

In Safari, the long-press behavior on images specifically triggers a contextual menu rather than the standard context menu by default.

What changes do you think we should make in order to solve the problem?

There is a workaround you can try to prevent the contextual menu from appearing. It involves adding the CSS property -webkit-touch-callout: none to the image element. By setting -webkit-touch-callout: none on the image element, you can attempt to prevent the contextual menu from appearing when the user long-presses on the image.

-webkit-touch-callout: none;

To solve this issue, insert this CSS property to webViewStyles.tagStyles.img style here.

App/src/styles/styles.js

Lines 132 to 136 in a777544

	img: {
	borderColor: themeColors.border,
	borderRadius: variables.componentBorderRadiusNormal,
	borderWidth: 1,
	},

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NicMendonca]

@johncschuster I am going OOO until Wednesday. Can you watch this while I am away? I'll unassign you when I am back. Thank you!

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long pressing on Image attachment opens the native menu

What is the root cause of that problem?

This is the default behavior of safari browser

What changes do you think we should make in order to solve the problem?

We should use pointerEvents to disable the default option to show up by stoping it from being a target.
We can add pointerEvents: "none" to the wrapper View or the <Image> component

App/src/components/ImageWithSizeCalculation.js

Lines 76 to 86 in 820fa93

	<View style={[styles.w100, styles.h100, this.props.style]}>
	<Image
	style={[styles.w100, styles.h100]}
	source={{uri: this.props.url}}
	isAuthTokenRequired={this.props.isAuthTokenRequired}
	resizeMode={Image.resizeMode.cover}
	onLoadStart={this.imageLoadingStart}
	onLoadEnd={this.imageLoadingEnd}
	onError={this.onError}
	onLoad={this.imageLoadedSuccessfully}
	/>

Additionally we need to add styles.userSelectNone to the wrapper View to prevent the selection event for the image to not propagate to the menu items.

Result:

Screen.Recording.2023-06-24.at.9.10.15.AM.mov

What alternative solutions did you explore? (Optional)

Note: We should not use -webkit-touch-callout since it's not reliable for every user and on the docs, it's clearly stated that to not use it on production sites.

[johncschuster]

@rushatgabhane what are your thoughts on the above proposals?

[rushatgabhane]

Confirmed that this issue is mWeb Safari only. (doesn't happen on macos safari)

So the browser compatibility of webkit-touch-callout is fine.

https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout#browser_compatibility

[rushatgabhane]

We should not use -webkit-touch-callout since it's not reliable for every user and on the docs, it's clearly stated that to not use it on production sites

I think it's fine to use it. It's "non-standard" to use it simply means it has bad cross-browser compatibility. But we only care about iOS Safari.

[rushatgabhane]

Hi @s-alves10, I like your proposal. Looking forward to more contributions from your 🚀

C+ reviewed 🎀 👀 🎀

[getusha]

@hayata-suenaga i respect the decision but i addressed the concern and was not able to reproduce it.

[s-alves10]

@rushatgabhane

PR is ready for review

[NicMendonca]

@rushatgabhane bump ^^

[getusha]

The first concern of mine was

1. using css directly is not appreciated
2. the docs state to not use it

but now there is additional thing adding browser/platform specific code, which only targets safari browser. which is both bad thing.

can we get the proposals re-evaluated to go with pointerEvents addressing the issues clearly please? i addressed the concerns here thank you! ❤️

cc: @rushatgabhane @hayata-suenaga

[parasharrajat]

@getusha Thanks for your concern. We already have made a decision after evaluating the same above.

[s-alves10]

@parasharrajat
Can you take a look at the PR again?

[melvin-bot]

@NicMendonca, @rushatgabhane, @hayata-suenaga, @s-alves10 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hayata-suenaga]

PR is reviewed here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: disable the default callout in ios safari #22216

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @s-alves10 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

Reporting payment requested.

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: This bug existed ever since we have long press for attachments. Will have to go years back. So we can leave this.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No. Won't happen again

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - No

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/3188378132507359

[NicMendonca]

• Reporter: @parasharrajat $250
• Contributor: @s-alves10 $1000
• C+: @rushatgabhane $1000

@rushatgabhane thanks for getting that BZ checklist done so quick! 🎉

[JmillsExpensify]

Reviewed details for @parasharrajat. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

[NicMendonca]

@s-alves10 has been paid via upwork ✅

[NicMendonca]

all set here!

[JmillsExpensify]

Reviewed details for @rushatgabhane. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.