[HOLD for payment 2023-06-15] [$1000] The cursor does not move to the next line after pressing Shift+Enter while using the mention feature.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat.
2. Type "@" and press Shift+Enter.
3. Notice that instead of moving to the next line, the user is selected from the popup.

Expected Result:

The cursor should move to the next line when Shift+Enter is pressed.

Actual Result:

The cursor does not move to the next line when Shift+Enter is pressed. Instead, the first option from the popup is selected when using the mention feature.
NOTE: Same happening with emoji too

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.2.mp4

Recording.760.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684834428858769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01830e384c4fcaaa98
• Upwork Job ID: 1663633838374625280
• Last Price Increase: 2023-05-30

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The cursor should move to the next line when Shift+Enter is pressed.

What is the root cause of that problem?

• The root cause is we are have not defined the key if we have pressed Enter + shift and if there are suggestion list (mentioned or emoji) then we need to have a new line (more sort of feature request since we never have defined this )

What changes do you think we should make in order to solve the problem?

• In order to have a new line while the suggestion is open we need to define the logical condition on triggerHotkeyActions on ReportActionCompose.js

• After testing we find that there is no need to add additional validation as proposed earlier, we just need to modify the current condition to check if we press shiftKey along with enter key based on that we can simply return early

• Above condition works for both the mentioned user and also works well on the emojisuggestion list basically these conditionals will work the same as Slack does 


        if (((!e.shiftKey && e.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey) || e.key === CONST.KEYBOARD_SHORTCUTS.TAB.shortcutKey) && suggestionsExist) {
            e.preventDefault();
            if (this.state.suggestedEmojis.length > 0) {
                this.insertSelectedEmoji(this.state.highlightedEmojiIndex);
            }
            if (this.state.suggestedMentions.length > 0) {
                this.insertSelectedMention(this.state.highlightedMentionIndex);
            }
            return;
        }

Result



Screen.Recording.2023-05-26.at.1.23.01.AM.mov

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor does not move to the next line after pressing Shift+Enter while using the mention feature

What is the root cause of that problem?

https://github.com/Expensify/App/blob/21fefdb19cd7262f9caaad132d30ea426426f017/src/pages/home/report/ReportActionCompose.js#L796-805
If the suggestion is open and we click Enter, we will insert the suggestion into the composer (even if Enter is triggered with another button)

What changes do you think we should make in order to solve the problem?

App/src/pages/home/report/ReportActionCompose.js

Line 796 in 21fefdb

if ((e.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey || e.key === CONST.KEYBOARD_SHORTCUTS.TAB.shortcutKey) && suggestionsExist) {

Here we should add a condition !e.shiftKey like this

 if (((e.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey && !e.shiftKey) || e.key === CONST.KEYBOARD_SHORTCUTS.TAB.shortcutKey) && suggestionsExist) {

What alternative solutions did you explore? (Optional)

NA

[twisterdotcom]

Okay, making it external: https://expensify.slack.com/archives/C049HHMV9SM/p1685126834069999?thread_ts=1684834428.858769&cid=C049HHMV9SM

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01830e384c4fcaaa98

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[code0406]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor does not move to the next line when Shift+Enter is pressed (when suggestions and emoji panels are opened.)

What is the root cause of that problem?

The root cause is:
in this case, the emoji or suggestion panel is shown first(when type '@' or ':'), it's correct logic.
and then when pressing SHIFT + ENTER, we should catch it on the parent side, and ignore the "Emoji" or "Suggestion" selection. but it was skipped.

What changes do you think we should make in order to solve the problem?

We should consider the "Shift" key-pressed event in the current key event module.
The target code to be fixed is in the function "triggerHotkeyActions" of the "ReportActionCompose.js" file.

1. Check if the "Shift" key is pressed in Emoji, suggestion cases. Other cases are working well. 
if (e.shiftKey) //detect the shift key pressed

2. if the key was pressed, then skip the Emoji, and suggestion actions and close the panel.
if (this.state.suggestedMentions.length > 0) {
  if (e.shiftKey)
    e.preventDefault();
    this.setShouldShowSuggestionsMenuToFalse();
    ...

It is fixed by simple code updating using already implemented functions.

What alternative solutions did you explore? (Optional)

I've checked and confirmed it 100%.
I shared the video that I fixed this issue.

issues19624.mp4

If github video does not play, then please check it in this uploaded link:
https://drive.google.com/file/d/1F2kOe0Wduc9C5KhBteq2coWf-OpKwk2-/view?usp=sharing

[melvin-bot]

📣 @code0406! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[code0406]

Contributor details
Your Expensify account email: d842443@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5053339c1ddbe12

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mollfpr]

Because it was not processed in the KEY event module.

@code0406 Which key do you mean?

[code0406]

Because it was not processed in the KEY event module.

@code0406 Which key do you mean?

I will share the screenshot.
This is the final code part to be fixed for the issue.

If you need, I will share the code diff.
Thank you.

[dhairyasenjaliya]

@mollfpr can you review this prospal as well #19624 (comment)

[code0406]

Because it was not processed in the KEY event module.

@code0406 Which key do you mean?

The current code is almost perfect.
So we don't need to change or clear any data.

1. just check the Shift Key pressed case,
2. call the useful function that was implemented already.

That's all.

[mollfpr]

@dhairyasenjaliya Thanks. I almost forget there’s another proposal above.

[twisterdotcom]

@cristipaval bump on this please.

[cristipaval]

@cristipaval the proposal from @dhairyasenjaliya looks good to me!

🎀 👀 🎀 C+ reviewed!

Thanks @mollfpr !

@dhairyasenjaliya you're all set.

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @cristipaval!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dhairyasenjaliya]

@mollfpr @cristipaval PR ready for review

[twisterdotcom]

Oooh! Merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• added shift+enter hotkey #20175

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#18469

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/18469/files#r1231104731

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1686839540389379

[@mollfpr] Determine if we should create a regression test for this bug.

Yes!

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to any chat.
2. Type "@" and press Shift+Enter.
3. Verify the cursor should be placed on the next line without selecting a suggestion, and the suggestion box should be closed
4. 👍 or 👎

[twisterdotcom]

Sorry folks, I've been getting this all day:

[twisterdotcom]

I think I managed to pay you all via the Upwork iOS app on my mobile data.

[twisterdotcom]

https://github.com/Expensify/Expensify/issues/293145